From patchwork Wed Jul 8 12:26:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 50871 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8AE1C22A03 for ; Wed, 8 Jul 2015 12:29:43 +0000 (UTC) Received: by wgjx7 with SMTP id x7sf69760643wgj.3 for ; Wed, 08 Jul 2015 05:29:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=COsOtDj1tdxcjum8loc2vzRI2BAdGC5/fVoWMfbDqkU=; b=QawJ5YYCySf5Fz/aFsVFrvRdrJ1C0TM+SXRkoD2t4FZjoaO7F9sEERCx3/k7hSRU0+ DWBkU+dzoAnB7lkprOjalTLrzKbwyBpBN+XVjjUhYTVC6UU9vGHR2oqSap0BQknIHGpB +trcSV1ISfZVpzFCDbmWkMmgJzgkVO+QpBtIyJp8DexgXeW1oQVAeHYCuzin5VQC+D2N seYofkjF20CWYpaJuXRJZ9OvaudgJuHq7zuy/PkHGUgcWkSbE4UIX4BUxA5cfLSPWzI9 LExZC1V5hgUxVSfOtUN6KrO3fOO4c0Cl6PDsI/fQL32NidBZHPAN5vUA1cyJcvo3IAZJ gppw== X-Gm-Message-State: ALoCoQl85+w/2F0ERWAhEI5xEDDl3R0k4j0DIwFS21aoeTZh3facDL2lni6OodQDJoe6pnOpSyfE X-Received: by 10.112.189.131 with SMTP id gi3mr4651292lbc.6.1436358582827; Wed, 08 Jul 2015 05:29:42 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.37.8 with SMTP id u8ls951169laj.39.gmail; Wed, 08 Jul 2015 05:29:42 -0700 (PDT) X-Received: by 10.152.43.17 with SMTP id s17mr6000456lal.101.1436358582653; Wed, 08 Jul 2015 05:29:42 -0700 (PDT) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com. [209.85.215.54]) by mx.google.com with ESMTPS id ei11si1544622lad.43.2015.07.08.05.29.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jul 2015 05:29:42 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) client-ip=209.85.215.54; Received: by laar3 with SMTP id r3so224699028laa.0 for ; Wed, 08 Jul 2015 05:29:42 -0700 (PDT) X-Received: by 10.112.126.101 with SMTP id mx5mr9354849lbb.35.1436358582509; Wed, 08 Jul 2015 05:29:42 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp3059894lbb; Wed, 8 Jul 2015 05:29:41 -0700 (PDT) X-Received: by 10.68.195.200 with SMTP id ig8mr20058874pbc.33.1436358579923; Wed, 08 Jul 2015 05:29:39 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y14si3903474pdk.111.2015.07.08.05.29.38; Wed, 08 Jul 2015 05:29:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758425AbbGHM3f (ORCPT + 29 others); Wed, 8 Jul 2015 08:29:35 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34860 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758383AbbGHM3b (ORCPT ); Wed, 8 Jul 2015 08:29:31 -0400 Received: by pactm7 with SMTP id tm7so131151462pac.2 for ; Wed, 08 Jul 2015 05:29:31 -0700 (PDT) X-Received: by 10.66.184.133 with SMTP id eu5mr19655464pac.75.1436358571363; Wed, 08 Jul 2015 05:29:31 -0700 (PDT) Received: from localhost.localdomain ([202.62.93.138]) by smtp.gmail.com with ESMTPSA id db1sm2415741pdb.50.2015.07.08.05.29.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Jul 2015 05:29:30 -0700 (PDT) From: Vaibhav Hiremath To: linux-arm-kernel@lists.infradead.org Cc: Vaibhav Hiremath , Samuel Ortiz , Lee Jones , linux-kernel@vger.kernel.org (open list) Subject: [PATCH-v6 1/6] mfd: 88pm800: remove duplicate dev_err calls during probe Date: Wed, 8 Jul 2015 17:56:27 +0530 Message-Id: <1436358392-15449-2-git-send-email-vaibhav.hiremath@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1436358392-15449-1-git-send-email-vaibhav.hiremath@linaro.org> References: <1436358392-15449-1-git-send-email-vaibhav.hiremath@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: vaibhav.hiremath@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , During probe, inside fn device_800_init(), submodule init is happening and the same error message is getting printed in both the places, _init() and inside device_800_init(). So this patch gets rid of dev_err from _init() fns. Signed-off-by: Vaibhav Hiremath Acked-by: Lee Jones --- drivers/mfd/88pm800.c | 32 ++++---------------------------- 1 file changed, 4 insertions(+), 28 deletions(-) diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index 841717a..0c5470e 100644 --- a/drivers/mfd/88pm800.c +++ b/drivers/mfd/88pm800.c @@ -308,59 +308,35 @@ static int device_gpadc_init(struct pm80x_chip *chip, return 0; out: - dev_info(chip->dev, "pm800 device_gpadc_init: Failed!\n"); return ret; } static int device_onkey_init(struct pm80x_chip *chip, struct pm80x_platform_data *pdata) { - int ret; - - ret = mfd_add_devices(chip->dev, 0, &onkey_devs[0], + return mfd_add_devices(chip->dev, 0, &onkey_devs[0], ARRAY_SIZE(onkey_devs), &onkey_resources[0], 0, NULL); - if (ret) { - dev_err(chip->dev, "Failed to add onkey subdev\n"); - return ret; - } - - return 0; } static int device_rtc_init(struct pm80x_chip *chip, struct pm80x_platform_data *pdata) { - int ret; - if (pdata) { rtc_devs[0].platform_data = pdata->rtc; rtc_devs[0].pdata_size = pdata->rtc ? sizeof(struct pm80x_rtc_pdata) : 0; } - ret = mfd_add_devices(chip->dev, 0, &rtc_devs[0], - ARRAY_SIZE(rtc_devs), NULL, 0, NULL); - if (ret) { - dev_err(chip->dev, "Failed to add rtc subdev\n"); - return ret; - } - return 0; + return mfd_add_devices(chip->dev, 0, &rtc_devs[0], + ARRAY_SIZE(rtc_devs), NULL, 0, NULL); } static int device_regulator_init(struct pm80x_chip *chip, struct pm80x_platform_data *pdata) { - int ret; - - ret = mfd_add_devices(chip->dev, 0, ®ulator_devs[0], + return mfd_add_devices(chip->dev, 0, ®ulator_devs[0], ARRAY_SIZE(regulator_devs), NULL, 0, NULL); - if (ret) { - dev_err(chip->dev, "Failed to add regulator subdev\n"); - return ret; - } - - return 0; } static int device_irq_init_800(struct pm80x_chip *chip)