From patchwork Wed Jun 24 15:11:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 50280 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 540BF228FC for ; Wed, 24 Jun 2015 15:12:48 +0000 (UTC) Received: by wicnd19 with SMTP id nd19sf14220780wic.0 for ; Wed, 24 Jun 2015 08:12:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=DZ6j9+c9LiKKIQwiRACGvimWo+e3DfZ07Sx3/WTKfQg=; b=GlQ7Sev2BYZbM+Blw+3b846bi8roRg71fcCPIrNiyfV3dKyynSb39T3FZeZJZ/Qvd3 ujSUSnVZmZc51vZtyOs2LOwPUIijNBBsZSH9s6+lerFSfduSsWg8cn8gNuKuNBM+ADUf e3DDuWq/+myKQV6qLSi6t81sfFbBEgv11j3th83Q2Y1ydavBWWHx8pkVudDzvtpikwX1 gVMmtS77u7Z7QnNxVcvjR0kmSE49qPTH5fOItGly12/+IH/dPjJs0C4Db12d6H3zsoEj LyiFle2lXty4m7K/yZoMj3CTXlM8Kg/ZUoYZPFmmcYcxLVCQ53WDtYsTcH4O4KQ7MynX BgZw== X-Gm-Message-State: ALoCoQnXr+rJ78AmLQziXCwFFoJwrLc7MrXqHCYI3JD78mcjlAha9K1+GaIq+XnHXudw44FQYb2r X-Received: by 10.180.198.172 with SMTP id jd12mr2269976wic.5.1435158767705; Wed, 24 Jun 2015 08:12:47 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.153.5.35 with SMTP id cj3ls229487lad.7.gmail; Wed, 24 Jun 2015 08:12:47 -0700 (PDT) X-Received: by 10.152.5.98 with SMTP id r2mr40553466lar.8.1435158767543; Wed, 24 Jun 2015 08:12:47 -0700 (PDT) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com. [209.85.215.53]) by mx.google.com with ESMTPS id r1si22256586lar.2.2015.06.24.08.12.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jun 2015 08:12:47 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) client-ip=209.85.215.53; Received: by laka10 with SMTP id a10so28050744lak.0 for ; Wed, 24 Jun 2015 08:12:47 -0700 (PDT) X-Received: by 10.152.27.1 with SMTP id p1mr40001434lag.112.1435158767268; Wed, 24 Jun 2015 08:12:47 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp3856797lbb; Wed, 24 Jun 2015 08:12:46 -0700 (PDT) X-Received: by 10.70.44.138 with SMTP id e10mr13092847pdm.121.1435158762130; Wed, 24 Jun 2015 08:12:42 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w10si14735614pas.189.2015.06.24.08.12.41; Wed, 24 Jun 2015 08:12:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753854AbbFXPMD (ORCPT + 8 others); Wed, 24 Jun 2015 11:12:03 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:34765 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753549AbbFXPLe (ORCPT ); Wed, 24 Jun 2015 11:11:34 -0400 Received: by wicnd19 with SMTP id nd19so137768159wic.1 for ; Wed, 24 Jun 2015 08:11:32 -0700 (PDT) X-Received: by 10.194.185.236 with SMTP id ff12mr72431028wjc.134.1435158692536; Wed, 24 Jun 2015 08:11:32 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id ju2sm3018019wid.12.2015.06.24.08.11.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 Jun 2015 08:11:31 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, mchehab@osg.samsung.com Cc: peter.griffin@linaro.org, lee.jones@linaro.org, hugues.fruchet@st.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 03/12] [media] stv0367: Refine i2c error trace to include i2c address Date: Wed, 24 Jun 2015 16:11:01 +0100 Message-Id: <1435158670-7195-4-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1435158670-7195-1-git-send-email-peter.griffin@linaro.org> References: <1435158670-7195-1-git-send-email-peter.griffin@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , When using stv0367 demodulator with STi STB platforms, we can have easily have four or more stv0367 demods running in the system at one time. As typically the b2120 reference design ships with a b2004a daughter board, which can accept two dvb NIM cards, and each b2100A NIM has 2x stv0367 demods and 2x NXPs tuner on it. In such circumstances it is useful to print the i2c address on error messages to know which one is failing due to I2C issues. Signed-off-by: Peter Griffin --- drivers/media/dvb-frontends/stv0367.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c index b31ff26..c3b7e6c 100644 --- a/drivers/media/dvb-frontends/stv0367.c +++ b/drivers/media/dvb-frontends/stv0367.c @@ -791,11 +791,13 @@ int stv0367_writeregs(struct stv0367_state *state, u16 reg, u8 *data, int len) memcpy(buf + 2, data, len); if (i2cdebug) - printk(KERN_DEBUG "%s: %02x: %02x\n", __func__, reg, buf[2]); + printk(KERN_DEBUG "%s: [%02x] %02x: %02x\n", __func__, + state->config->demod_address, reg, buf[2]); ret = i2c_transfer(state->i2c, &msg, 1); if (ret != 1) - printk(KERN_ERR "%s: i2c write error!\n", __func__); + printk(KERN_ERR "%s: i2c write error! ([%02x] %02x: %02x)\n", + __func__, state->config->demod_address, reg, buf[2]); return (ret != 1) ? -EREMOTEIO : 0; } @@ -829,10 +831,12 @@ static u8 stv0367_readreg(struct stv0367_state *state, u16 reg) ret = i2c_transfer(state->i2c, msg, 2); if (ret != 2) - printk(KERN_ERR "%s: i2c read error\n", __func__); + printk(KERN_ERR "%s: i2c read error ([%02x] %02x: %02x)\n", + __func__, state->config->demod_address, reg, b1[0]); if (i2cdebug) - printk(KERN_DEBUG "%s: %02x: %02x\n", __func__, reg, b1[0]); + printk(KERN_DEBUG "%s: [%02x] %02x: %02x\n", __func__, + state->config->demod_address, reg, b1[0]); return b1[0]; }