From patchwork Fri May 29 22:19:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 49243 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F136A24588 for ; Fri, 29 May 2015 22:22:11 +0000 (UTC) Received: by lagv1 with SMTP id v1sf24328168lag.1 for ; Fri, 29 May 2015 15:22:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=8ajLPJXxeGDNrnzVi6yWj05p7X0jh1OC9vTSWvfp998=; b=E30dF40BAW+QrzUbIhqVBK1fh3MDb2e9UTLVjWsr7wxYAISvust7Hb2k+dv3d2oOj6 9sLddvxBnNZpkXPwEPWkwycqTFPzIq3hrZ2Nb0GVXugrUhMmxTTT1/uCdMnx641SFUdm Jvj8qwAAwBzvwnl5Ff1VIPtHQLfkhRoufxn2+f8nqoPyz4mntFtyCVQiHBkvbmgudxa/ 00rHyzVOM86exsnA8jFwm3WKQcrp4GFcWfwP+Ag7ZnBfvGI1mQpDp6cSqX43x/i6iQAO LCmHFtB/OpVA2BoSCiCN1tbE/QOcfc0it7bOZG66Mm5GMNvQBlO1t2fr+z9Aq73U0VXB a0Ag== X-Gm-Message-State: ALoCoQlbNITU+Hda2GpM1Cc0/8IGDNKECVOJrdXJ4WyD7wJjyUUlLx5vsLKCmSud4MtI8vb+3Vq1 X-Received: by 10.113.11.3 with SMTP id ee3mr9215185lbd.9.1432938130645; Fri, 29 May 2015 15:22:10 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.37.166 with SMTP id z6ls385890laj.64.gmail; Fri, 29 May 2015 15:22:10 -0700 (PDT) X-Received: by 10.152.5.164 with SMTP id t4mr10138681lat.16.1432938130496; Fri, 29 May 2015 15:22:10 -0700 (PDT) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com. [209.85.215.53]) by mx.google.com with ESMTPS id is4si5787946lac.103.2015.05.29.15.22.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 May 2015 15:22:10 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) client-ip=209.85.215.53; Received: by labko7 with SMTP id ko7so62127213lab.2 for ; Fri, 29 May 2015 15:22:10 -0700 (PDT) X-Received: by 10.112.234.200 with SMTP id ug8mr9997903lbc.117.1432938130206; Fri, 29 May 2015 15:22:10 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp667017lbb; Fri, 29 May 2015 15:22:09 -0700 (PDT) X-Received: by 10.68.102.1 with SMTP id fk1mr19025178pbb.56.1432938126627; Fri, 29 May 2015 15:22:06 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cn10si10256543pac.193.2015.05.29.15.22.05; Fri, 29 May 2015 15:22:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757447AbbE2WV5 (ORCPT + 7 others); Fri, 29 May 2015 18:21:57 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:34530 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757432AbbE2WVx (ORCPT ); Fri, 29 May 2015 18:21:53 -0400 Received: by pdbki1 with SMTP id ki1so63011718pdb.1 for ; Fri, 29 May 2015 15:21:53 -0700 (PDT) X-Received: by 10.68.136.134 with SMTP id qa6mr18930675pbb.66.1432938113324; Fri, 29 May 2015 15:21:53 -0700 (PDT) Received: from localhost.localdomain ([202.62.77.106]) by mx.google.com with ESMTPSA id nb10sm6605761pdb.76.2015.05.29.15.21.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 May 2015 15:21:52 -0700 (PDT) From: Vaibhav Hiremath To: linux-arm-kernel@lists.infradead.org Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, sameo@linux.intel.com, lee.jones@linaro.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, Vaibhav Hiremath , zhaoy Subject: [PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method Date: Sat, 30 May 2015 03:49:20 +0530 Message-Id: <1432937962-4537-3-git-send-email-vaibhav.hiremath@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1432937962-4537-1-git-send-email-vaibhav.hiremath@linaro.org> References: <1432937962-4537-1-git-send-email-vaibhav.hiremath@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: vaibhav.hiremath@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , >From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the method of clearing interrupt status register of 88pm800; 0: clear on read 1: clear on write Signed-off-by: zhaoy Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 4 +++- include/linux/mfd/88pm80x.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index 06ee058..8ea4467 100644 --- a/drivers/mfd/88pm800.c +++ b/drivers/mfd/88pm800.c @@ -391,7 +391,8 @@ static int device_irq_init_800(struct pm80x_chip *chip) PM800_WAKEUP2_INV_INT | PM800_WAKEUP2_INT_CLEAR | PM800_WAKEUP2_INT_MASK; - data = PM800_WAKEUP2_INT_CLEAR; + data = (chip->irq_mode) ? + PM800_WAKEUP2_INT_WRITE_CLEAR : PM800_WAKEUP2_INT_READ_CLEAR; ret = regmap_update_bits(map, PM800_WAKEUP2, mask, data); if (ret < 0) @@ -514,6 +515,7 @@ static int device_800_init(struct pm80x_chip *chip, } chip->regmap_irq_chip = &pm800_irq_chip; + chip->irq_mode = pdata->irq_mode; ret = device_irq_init_800(chip); if (ret < 0) { diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h index 97cb283..6ed6c16 100644 --- a/include/linux/mfd/88pm80x.h +++ b/include/linux/mfd/88pm80x.h @@ -77,6 +77,8 @@ enum { #define PM800_WAKEUP2 (0x0E) #define PM800_WAKEUP2_INV_INT (1 << 0) #define PM800_WAKEUP2_INT_CLEAR (1 << 1) +#define PM800_WAKEUP2_INT_READ_CLEAR (0 << 1) +#define PM800_WAKEUP2_INT_WRITE_CLEAR (1 << 1) #define PM800_WAKEUP2_INT_MASK (1 << 2) #define PM800_POWER_UP_LOG (0x10)