From patchwork Fri Apr 17 07:14:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 47247 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 7C9B320553 for ; Fri, 17 Apr 2015 07:15:53 +0000 (UTC) Received: by wghm4 with SMTP id m4sf22162260wgh.2 for ; Fri, 17 Apr 2015 00:15:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=D3obTMRMu+qZ8uotYSs56O3DmR9wRC2gHsTKAUiyYc8=; b=lWgWFjRc9ByM1OoznxQ3/J99AgBUo+HSu3y0/OwOoX2nu/vgaZF7ckHrwSmZpePeZt 5efXvSof6zhfmbJ9tBLHaf2TVyMJi3mnWWTrDTe2q+erjgDLZIogbc6KzKar1jH5Trjj ND4L3VU3B9QVtVJe6lZzgW2PeINJIKJBkivout6fF2q5H6oTI1dZ/Flqr4GTn7mbCCLs MR9vhzqifmf2fl3SdZu/K+yJdipTGg0wArFccNdCsyag579rZFagXUM57t0LnMlVs1Hn OoD8ZSG46Ou/segYCE+eoo45blAVy392bghzumVr0YVBNxvC0DHrLgITojqyILedULoM yF4Q== X-Gm-Message-State: ALoCoQkHAfPloaWAtvtJWKUZEbe4R41/WI9wtPAg855sfQxk/tgJJRn6DdOWy5hDi3EtGel2dsEE X-Received: by 10.194.241.200 with SMTP id wk8mr723882wjc.7.1429254952822; Fri, 17 Apr 2015 00:15:52 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.6.200 with SMTP id d8ls408523laa.34.gmail; Fri, 17 Apr 2015 00:15:52 -0700 (PDT) X-Received: by 10.152.18.225 with SMTP id z1mr1371573lad.124.1429254952632; Fri, 17 Apr 2015 00:15:52 -0700 (PDT) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com. [209.85.215.49]) by mx.google.com with ESMTPS id ll7si8109419lac.169.2015.04.17.00.15.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Apr 2015 00:15:52 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) client-ip=209.85.215.49; Received: by laat2 with SMTP id t2so73590611laa.1 for ; Fri, 17 Apr 2015 00:15:52 -0700 (PDT) X-Received: by 10.112.29.36 with SMTP id g4mr1396718lbh.56.1429254952535; Fri, 17 Apr 2015 00:15:52 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp3561156lbt; Fri, 17 Apr 2015 00:15:51 -0700 (PDT) X-Received: by 10.66.140.101 with SMTP id rf5mr3109157pab.50.1429254951154; Fri, 17 Apr 2015 00:15:51 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fk17si15530712pdb.56.2015.04.17.00.15.50; Fri, 17 Apr 2015 00:15:51 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752991AbbDQHPq (ORCPT + 27 others); Fri, 17 Apr 2015 03:15:46 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:33063 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbbDQHPk (ORCPT ); Fri, 17 Apr 2015 03:15:40 -0400 Received: by lbbzk7 with SMTP id zk7so76060154lbb.0 for ; Fri, 17 Apr 2015 00:15:39 -0700 (PDT) X-Received: by 10.112.147.201 with SMTP id tm9mr1374641lbb.40.1429254938978; Fri, 17 Apr 2015 00:15:38 -0700 (PDT) Received: from tn-HP-4.semihalf.local ([80.82.22.190]) by mx.google.com with ESMTPSA id yq18sm2215742lbb.47.2015.04.17.00.15.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Apr 2015 00:15:38 -0700 (PDT) From: Tomasz Nowicki To: bhelgaas@google.com, wangyijing@huawei.com, arnd@arndb.de, hanjun.guo@linaro.org, Liviu.Dudau@arm.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, rjw@rjwysocki.net, al.stone@linaro.org, lorenzo.pieralisi@arm.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linaro-acpi@lists.linaro.org, Tomasz Nowicki Subject: [PATCH v5 1/9] x86, pci: Clean up comment about buggy MMIO config space access for AMD Fam10h CPUs. Date: Fri, 17 Apr 2015 09:14:50 +0200 Message-Id: <1429254898-32743-2-git-send-email-tomasz.nowicki@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1429254898-32743-1-git-send-email-tomasz.nowicki@linaro.org> References: <1429254898-32743-1-git-send-email-tomasz.nowicki@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: tomasz.nowicki@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , - fix typo - improve explanation - add reference to the related document Signed-off-by: Tomasz Nowicki --- arch/x86/include/asm/pci_x86.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x86.h index fa1195d..d024f4d 100644 --- a/arch/x86/include/asm/pci_x86.h +++ b/arch/x86/include/asm/pci_x86.h @@ -152,10 +152,13 @@ extern struct list_head pci_mmcfg_list; /* * AMD Fam10h CPUs are buggy, and cannot access MMIO config space - * on their northbrige except through the * %eax register. As such, you MUST - * NOT use normal IOMEM accesses, you need to only use the magic mmio-config + * on their northbridge except through the * %eax register. As such, you MUST + * NOT use normal IOMEM accesses, you need to only use the magic mmio_config_* * accessor functions. - * In fact just use pci_config_*, nothing else please. + * + * Please refer to the following doc: + * "BIOS and Kernel Developer's Guide (BKDG) For AMD Family 10h Processors", + * rev. 3.48, sec 2.11.1, "MMIO Configuration Coding Requirements". */ static inline unsigned char mmio_config_readb(void __iomem *pos) {