From patchwork Fri Apr 10 09:40:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 47014 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f71.google.com (mail-wg0-f71.google.com [74.125.82.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3912321416 for ; Fri, 10 Apr 2015 09:42:39 +0000 (UTC) Received: by wgin8 with SMTP id n8sf2860045wgi.0 for ; Fri, 10 Apr 2015 02:42:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=KKqi93e05H5nWZxRa/pg4pz9VCTxZJGHTL+0JycNJag=; b=B+28rHwCoQcdXrKhm+zikpFwuoIUc3hGjvbA18UyaxmAdih0MzA804DCeO8dGHbc7J 2zIeAbNjSf6GLcow1B6zFx8GpfVZU+lgPF94MzWmKvBIysYSH0YwGGK9IL29Rs6jfSLL ckE+8i+U9uyUKRGdLdLpGvhhP548fCXtEStQpqc4VTha+e6407kphzsr6Nd9S+cjhxMl t63B9hyY58kgGj/4DRGMhDGApGNXdfAIbgmsSN+9h34PSjiespiAJNiILyIuiM5jfvip oaA6Zddh48/xgEylS8natEKzLycwetLpHzNJo6GEdChsAyeIXoSR54rOLLkPq5sla2BQ JEIw== X-Gm-Message-State: ALoCoQnk0phdCetJ00s1wcDEBT4dQr8BTmZ92naGBUZSZsozdkWuN6BChhdFexkuEK4KSOv0W4iO X-Received: by 10.152.3.70 with SMTP id a6mr155264laa.0.1428658958464; Fri, 10 Apr 2015 02:42:38 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.19.231 with SMTP id i7ls388764lae.85.gmail; Fri, 10 Apr 2015 02:42:38 -0700 (PDT) X-Received: by 10.152.10.66 with SMTP id g2mr658361lab.44.1428658958292; Fri, 10 Apr 2015 02:42:38 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id q6si1044226lby.85.2015.04.10.02.42.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 02:42:38 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by labbd9 with SMTP id bd9so9225097lab.2 for ; Fri, 10 Apr 2015 02:42:38 -0700 (PDT) X-Received: by 10.112.199.133 with SMTP id jk5mr681567lbc.32.1428658958212; Fri, 10 Apr 2015 02:42:38 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp978110lbt; Fri, 10 Apr 2015 02:42:37 -0700 (PDT) X-Received: by 10.68.100.161 with SMTP id ez1mr1110537pbb.81.1428658956452; Fri, 10 Apr 2015 02:42:36 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z10si2213198pdl.29.2015.04.10.02.42.35; Fri, 10 Apr 2015 02:42:36 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932680AbbDJJmb (ORCPT + 27 others); Fri, 10 Apr 2015 05:42:31 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:32846 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932459AbbDJJlD (ORCPT ); Fri, 10 Apr 2015 05:41:03 -0400 Received: by wiax7 with SMTP id x7so12243831wia.0 for ; Fri, 10 Apr 2015 02:41:02 -0700 (PDT) X-Received: by 10.194.243.9 with SMTP id wu9mr1357978wjc.107.1428658862380; Fri, 10 Apr 2015 02:41:02 -0700 (PDT) Received: from localhost.localdomain ([31.105.225.148]) by mx.google.com with ESMTPSA id l1sm23993381wiy.20.2015.04.10.02.40.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Apr 2015 02:41:01 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, ulf.hansson@linaro.org, peppe.cavallaro@st.com Cc: peter.griffin@linaro.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-mmc@vger.kernel.org Subject: [PATCH v5 6/9] mmc: sdhci-st: Update the quirks for this controller. Date: Fri, 10 Apr 2015 10:40:28 +0100 Message-Id: <1428658831-14308-7-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1428658831-14308-1-git-send-email-peter.griffin@linaro.org> References: <1428658831-14308-1-git-send-email-peter.griffin@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Some additional quirks need to be enabled now we support UHS modes. This avoids some spurious warnings like "Got data interrupt 0x00000002 even though no data operation was in progress" Testing on stih410-b2120 board achieves the following speeds with HS200 eMMC card. max-frequency = 200Mhz /dev/mmcblk0p1: Timing buffered disk reads: 270 MB in 3.02 seconds = 89.54 MB/sec max-frequency = 100Mhz root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 /dev/mmcblk0p1: Timing buffered disk reads: 210 MB in 3.00 seconds = 70.00 MB/sec max-frequency = 50Mhz root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 /dev/mmcblk0p1: Timing buffered disk reads: 118 MB in 3.00 seconds = 39.28 MB/sec This is better than the 3.10 kernel which achieves 77.59 MB/sec at 200Mhz clock (same board/soc/eMMC). Signed-off-by: Peter Griffin Signed-off-by: Giuseppe Cavallaro Acked-by: Maxime Coquelin --- drivers/mmc/host/sdhci-st.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c index 42a361c..682f2bb 100644 --- a/drivers/mmc/host/sdhci-st.c +++ b/drivers/mmc/host/sdhci-st.c @@ -340,7 +340,10 @@ static const struct sdhci_ops sdhci_st_ops = { static const struct sdhci_pltfm_data sdhci_st_pdata = { .ops = &sdhci_st_ops, .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC | - SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, + SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN | + SDHCI_QUIRK_NO_HISPD_BIT, + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN | + SDHCI_QUIRK2_STOP_WITH_TC, };