From patchwork Thu Feb 26 13:10:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 45168 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 60E922043C for ; Thu, 26 Feb 2015 13:11:20 +0000 (UTC) Received: by lbdu10 with SMTP id u10sf8129511lbd.3 for ; Thu, 26 Feb 2015 05:11:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=5YUHJvWK9EYXJ79NUJcgyPnGwmAvh1zcaYRo0gEqEiE=; b=ZeCwWgrW723MqIXVWhCy3tXfQj+AFm9Z5/5c73yEqk0aCed9vuEG05z0Dc/+1Pd+MA xs7c1NWvOZjn39/9F49RVTTWBgcpNopZrirpgv7hyZ32tyHsnqoE0TSFZY78f9a+Xu/v zee6jO/j8H58l9R/jRx+B1VOiPftoTuor7x3YLXFz29h6NXemt7wEMCfDXadt3+Hjvpn U5XaBaOizVPadYQYP/cypqL7GjWhOOWVSysFoIHyl8tQThqt1Ok0R9dxhbuEnldMbEFZ VX92QK86L89LPu1hYIlGHN6169PmMBCIzRhdL95I8gHSskHMTBhn8KPiKn94iy0pzVN+ loxQ== X-Gm-Message-State: ALoCoQlgfwaPOgPWHQgioJhdzbGch/vvmPZLMTBgipt0HtoSQhFiJTZcqsU+23P4RTsmsNxFUij0 X-Received: by 10.180.160.176 with SMTP id xl16mr2814117wib.6.1424956279316; Thu, 26 Feb 2015 05:11:19 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.29.201 with SMTP id m9ls33805lah.6.gmail; Thu, 26 Feb 2015 05:11:19 -0800 (PST) X-Received: by 10.152.9.230 with SMTP id d6mr7392851lab.16.1424956279093; Thu, 26 Feb 2015 05:11:19 -0800 (PST) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com. [209.85.217.182]) by mx.google.com with ESMTPS id i6si597139laf.48.2015.02.26.05.11.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2015 05:11:19 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) client-ip=209.85.217.182; Received: by lbjb6 with SMTP id b6so10613796lbj.12 for ; Thu, 26 Feb 2015 05:11:19 -0800 (PST) X-Received: by 10.112.114.230 with SMTP id jj6mr7310725lbb.112.1424956279003; Thu, 26 Feb 2015 05:11:19 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp3289151lbj; Thu, 26 Feb 2015 05:11:18 -0800 (PST) X-Received: by 10.66.156.229 with SMTP id wh5mr14579820pab.119.1424956273745; Thu, 26 Feb 2015 05:11:13 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3si1070240pap.109.2015.02.26.05.11.12; Thu, 26 Feb 2015 05:11:13 -0800 (PST) Received-SPF: none (google.com: linux-mmc-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753821AbbBZNKs (ORCPT + 3 others); Thu, 26 Feb 2015 08:10:48 -0500 Received: from mail-we0-f181.google.com ([74.125.82.181]:35993 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932280AbbBZNKr (ORCPT ); Thu, 26 Feb 2015 08:10:47 -0500 Received: by wevk48 with SMTP id k48so10546944wev.3 for ; Thu, 26 Feb 2015 05:10:45 -0800 (PST) X-Received: by 10.180.80.230 with SMTP id u6mr50151198wix.69.1424956245719; Thu, 26 Feb 2015 05:10:45 -0800 (PST) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id dz6sm23075747wib.0.2015.02.26.05.10.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Feb 2015 05:10:44 -0800 (PST) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, srinivas.kandagatla@gmail.com, chris@printf.net, ulf.hansson@linaro.org Cc: peter.griffin@linaro.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-mmc@vger.kernel.org, peppe.cavallaro@st.com Subject: [PATCH v2 6/8] mmc: sdhci-st: Update the quirks for this controller. Date: Thu, 26 Feb 2015 13:10:25 +0000 Message-Id: <1424956227-18258-7-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1424956227-18258-1-git-send-email-peter.griffin@linaro.org> References: <1424956227-18258-1-git-send-email-peter.griffin@linaro.org> Sender: linux-mmc-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Some additional quirks need to be enabled now we support UHS modes. This avoids some spurious warnings like "Got data interrupt 0x00000002 even though no data operation was in progress" Testing on stih410-b2120 board achieves the following speeds with HS200 eMMC card. max-frequency = 200Mhz /dev/mmcblk0p1: Timing buffered disk reads: 270 MB in 3.02 seconds = 89.54 MB/sec max-frequency = 100Mhz root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 /dev/mmcblk0p1: Timing buffered disk reads: 210 MB in 3.00 seconds = 70.00 MB/sec max-frequency = 50Mhz root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 /dev/mmcblk0p1: Timing buffered disk reads: 118 MB in 3.00 seconds = 39.28 MB/sec This is better than the 3.10 kernel which achieves 77.59 MB/sec at 200Mhz clock (same board/soc/eMMC). Signed-off-by: Peter Griffin Signed-off-by: Giuseppe Cavallaro --- drivers/mmc/host/sdhci-st.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c index d53bc82..c6957b8 100644 --- a/drivers/mmc/host/sdhci-st.c +++ b/drivers/mmc/host/sdhci-st.c @@ -338,7 +338,10 @@ static const struct sdhci_ops sdhci_st_ops = { static const struct sdhci_pltfm_data sdhci_st_pdata = { .ops = &sdhci_st_ops, .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC | - SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, + SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN | + SDHCI_QUIRK_NO_HISPD_BIT, + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN | + SDHCI_QUIRK2_STOP_WITH_TC, };