From patchwork Tue Feb 10 07:27:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Jon Medhurst \(Tixy\)" X-Patchwork-Id: 44515 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2A3E421512 for ; Tue, 10 Feb 2015 07:29:34 +0000 (UTC) Received: by mail-lb0-f199.google.com with SMTP id z11sf585159lbi.2 for ; Mon, 09 Feb 2015 23:29:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:subject:from:to:date :mime-version:cc:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:content-type :content-transfer-encoding:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list; bh=IldDXRKiPYPxqr/cCY4FbGKvLh9w0tfpqYTJiIx5eAc=; b=XuevZ3iU1Bx1J/vVDP4yBkcyZRt/0MBKz7jXNfYANQtWU1j9TEIetAKw0rcg2d3DlF Uen1b7XVSoMc7xcIv5TgbP0iz6bo3oF9CJTA6KTDvVqzI9chAQ9DU9KNid9Jp7S1Jzje RGhUE3HCsxC/YHyNo7sd1njSnLa60e52uVjVJb96xJv77rn918TzL4oP2qe5LDJFB+3O 2WbmL7gLMEgcZfDvNxFJTe2OupwKS7MJycGXgE1I8mw0O+uOnInCFNx+zP7jpbglBfQ8 fEMVusa/VT6ApkEYKo7Of+pwT1iGO8hLS7sB2I13YI/cl2wqOsz1bIS9eVQTeM4qCTR3 Ydug== X-Gm-Message-State: ALoCoQmuLRwzUTReFBn1o9J/OEuAQZKfgX4PuhjLax3ZfLNtUa3R/GyAAVvn0PZghIcYInLuIzP1 X-Received: by 10.180.99.3 with SMTP id em3mr1173632wib.7.1423553373042; Mon, 09 Feb 2015 23:29:33 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.242.164 with SMTP id wr4ls710888lac.79.gmail; Mon, 09 Feb 2015 23:29:32 -0800 (PST) X-Received: by 10.112.92.204 with SMTP id co12mr21467909lbb.43.1423553372885; Mon, 09 Feb 2015 23:29:32 -0800 (PST) Received: from mail-la0-f51.google.com (mail-la0-f51.google.com. [209.85.215.51]) by mx.google.com with ESMTPS id e8si11329110lam.60.2015.02.09.23.29.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Feb 2015 23:29:32 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) client-ip=209.85.215.51; Received: by lams18 with SMTP id s18so18445915lam.13 for ; Mon, 09 Feb 2015 23:29:32 -0800 (PST) X-Received: by 10.152.88.44 with SMTP id bd12mr21591665lab.86.1423553372773; Mon, 09 Feb 2015 23:29:32 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp439383lbj; Mon, 9 Feb 2015 23:29:32 -0800 (PST) X-Received: by 10.66.222.72 with SMTP id qk8mr35460635pac.121.1423553371889; Mon, 09 Feb 2015 23:29:31 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id rp16si25752243pab.7.2015.02.09.23.29.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Feb 2015 23:29:31 -0800 (PST) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YL5F5-0003n6-UH; Tue, 10 Feb 2015 07:28:19 +0000 Received: from smarthost01a.mail.zen.net.uk ([212.23.1.1]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YL5F1-0003gf-Su for linux-arm-kernel@lists.infradead.org; Tue, 10 Feb 2015 07:28:17 +0000 Received: from [210.177.145.245] (helo=[172.16.26.167]) by smarthost01a.mail.zen.net.uk with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YL5Ed-0008hC-Uc; Tue, 10 Feb 2015 07:27:52 +0000 Message-ID: <1423553267.2647.7.camel@linaro.org> Subject: [PATCH] ARM: kprobes: Fix compilation error caused by superfluous '*' From: "Jon Medhurst (Tixy)" To: Russell King Date: Tue, 10 Feb 2015 15:27:47 +0800 X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-Originating-smarthost01a-IP: [210.177.145.245] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150209_232816_122286_25F336E1 X-CRM114-Status: UNSURE ( 6.66 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.3 (/) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (0.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.23.1.1 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.23.1.1 listed in wl.mailspike.net] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Cc: Wang Nan , Janusz =?UTF-8?Q?U=C5=BCycki?= , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: tixy@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 There is a superfluous '*' in the definition of kprobe_decode_insn_t which on older versions of GCC (4.2.4) causes the compilation error: In file included from arch/arm/probes/kprobes/core.c:37: arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other than a declaration Fix this by removing the unneeded character. Reported-by: Janusz Użycki Signed-off-by: Jon Medhurst --- Russell, I also applied this to my branch that you pulled which introduced the bug... git://git.linaro.org/people/tixy/kernel.git kprobes arch/arm/probes/kprobes/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/probes/kprobes/core.h b/arch/arm/probes/kprobes/core.h index b3036c5..ec5d1f2 100644 --- a/arch/arm/probes/kprobes/core.h +++ b/arch/arm/probes/kprobes/core.h @@ -40,7 +40,7 @@ typedef enum probes_insn (kprobe_decode_insn_t)(probes_opcode_t, struct arch_probes_insn *, bool, const union decode_action *, - const struct decode_checker *[*]); + const struct decode_checker *[]); #ifdef CONFIG_THUMB2_KERNEL