From patchwork Sun Jan 11 13:10:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 42949 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-we0-f200.google.com (mail-we0-f200.google.com [74.125.82.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1F4032055F for ; Sun, 11 Jan 2015 13:11:55 +0000 (UTC) Received: by mail-we0-f200.google.com with SMTP id u56sf7593316wes.3 for ; Sun, 11 Jan 2015 05:11:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id :in-reply-to:references:cc:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :content-type:content-transfer-encoding:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list; bh=1lRu4VOJlmauVPuDwfhPKsNnu4bHK4YjKgqMCgUMB4c=; b=kJaCe/+PvImFiQJtB15/N+Kyk3Ry5a4RCZRomJRx+PLP2Ocgm87MVzEO77IyS4Wp+h lQ7UMuNEUFlqhAWCI/xxkMYfXzHlevr/LOaywkCXxfyWc5Gm6hWVwiIjE4CeP8Um8EDE htLibn3cdNgFvXDdMz6qLT8lwpS+ZPgyVFhSUnrM2GnPeroqvpMIlDglNsDJhqmOo8tF B0dlR8CPVaRav6tL17Qn69NguhU7oI2v614nLSBrsEYvhnXPJ/dC5UuMYPwoVY+53zxD 4eh3azeVKw2piequz7nujCKX9ApGrRpLsAhUYkDx4xKclOq9YfDnf7eZ73++dm8ul96d HggA== X-Gm-Message-State: ALoCoQlpbqk33V+OfUFnhnBCvqNFae5NqGMP2mPhfAYMq5i0ixFh5XrHFrQ0F9Ww8LMdP3B0iFff X-Received: by 10.152.26.39 with SMTP id i7mr3106608lag.1.1420981914313; Sun, 11 Jan 2015 05:11:54 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.21.130 with SMTP id v2ls435910lae.98.gmail; Sun, 11 Jan 2015 05:11:54 -0800 (PST) X-Received: by 10.112.198.233 with SMTP id jf9mr32151589lbc.9.1420981914166; Sun, 11 Jan 2015 05:11:54 -0800 (PST) Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com. [209.85.217.170]) by mx.google.com with ESMTPS id v3si18690878lae.26.2015.01.11.05.11.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 11 Jan 2015 05:11:54 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) client-ip=209.85.217.170; Received: by mail-lb0-f170.google.com with SMTP id 10so14149692lbg.1 for ; Sun, 11 Jan 2015 05:11:54 -0800 (PST) X-Received: by 10.112.170.36 with SMTP id aj4mr31415942lbc.3.1420981914043; Sun, 11 Jan 2015 05:11:54 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp831145lbb; Sun, 11 Jan 2015 05:11:53 -0800 (PST) X-Received: by 10.68.57.199 with SMTP id k7mr37511045pbq.25.1420981912182; Sun, 11 Jan 2015 05:11:52 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id ni8si20193470pbc.105.2015.01.11.05.11.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Jan 2015 05:11:52 -0800 (PST) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YAIHg-00056w-E1; Sun, 11 Jan 2015 13:10:24 +0000 Received: from mail-lb0-f182.google.com ([209.85.217.182]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YAIHQ-0003md-JY for linux-arm-kernel@lists.infradead.org; Sun, 11 Jan 2015 13:10:09 +0000 Received: by mail-lb0-f182.google.com with SMTP id u10so14067415lbd.13 for ; Sun, 11 Jan 2015 05:09:46 -0800 (PST) X-Received: by 10.152.36.37 with SMTP id n5mr30896003laj.27.1420981786487; Sun, 11 Jan 2015 05:09:46 -0800 (PST) Received: from localhost.localdomain (188-178-240-98-static.dk.customer.tdc.net. [188.178.240.98]) by mx.google.com with ESMTPSA id q17sm3279475lal.2.2015.01.11.05.09.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 11 Jan 2015 05:09:45 -0800 (PST) From: Christoffer Dall To: Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: [GIT PULL 1/2] arm64: KVM: Fix TLB invalidation by IPA/VMID Date: Sun, 11 Jan 2015 14:10:10 +0100 Message-Id: <1420981811-18731-2-git-send-email-christoffer.dall@linaro.org> X-Mailer: git-send-email 2.1.2.330.g565301e.dirty In-Reply-To: <1420981811-18731-1-git-send-email-christoffer.dall@linaro.org> References: <1420981811-18731-1-git-send-email-christoffer.dall@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150111_051008_902179_1B80CF57 X-CRM114-Status: UNSURE ( 8.11 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.217.182 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.217.182 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Cc: Marc Zyngier , Christoffer Dall , kvm@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: christoffer.dall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Marc Zyngier It took about two years for someone to notice that the IPA passed to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing is not as good as it should be... Paper bag time for me. Reported-by: Mario Smarduch Tested-by: Mario Smarduch Signed-off-by: Marc Zyngier Signed-off-by: Christoffer Dall --- arch/arm64/kvm/hyp.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kvm/hyp.S b/arch/arm64/kvm/hyp.S index fbe909f..c3ca89c 100644 --- a/arch/arm64/kvm/hyp.S +++ b/arch/arm64/kvm/hyp.S @@ -1014,6 +1014,7 @@ ENTRY(__kvm_tlb_flush_vmid_ipa) * Instead, we invalidate Stage-2 for this IPA, and the * whole of Stage-1. Weep... */ + lsr x1, x1, #12 tlbi ipas2e1is, x1 /* * We have to ensure completion of the invalidation at Stage-2,