From patchwork Tue Sep 2 21:19:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 36517 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f199.google.com (mail-pd0-f199.google.com [209.85.192.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 7C796202E4 for ; Tue, 2 Sep 2014 21:19:55 +0000 (UTC) Received: by mail-pd0-f199.google.com with SMTP id ft15sf238242pdb.6 for ; Tue, 02 Sep 2014 14:19:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=/L1sQ5cUmx3I8B5/6uplpcqu5zSMZpF4dS1JluYnKDY=; b=V2Eqhh7i0TgEyqiHWJ/3QEF13eYeAM+ySoAl+iRlWdWgpS9qbhTaKK8oMkdDnAT3cK kZ8o6nbUz0RFT7NCrKYY5vu8RVEfJhPLPCRCgVhgSyvX31uSWNwv3iharoHXMMblFW0J 8+9qU54v7xmIceHnBKA+0h89Z3GPQISjSeADSV84vz5dLJiKwj0pBhcUAcYyTro+8uKn xl8x6ZUC5ME2EdZRm0GJVfhe8KTdDqbrUrDws2CVISFJdVwkb2Ms7vq+BYA/99Mn8ZZA cLZ7JWMIadSqVUw8QElhhGog4bt/5u3I5X9Qya5WSwMH7n6OT1QqsR0OAkWnasdhCFj7 hE2A== X-Gm-Message-State: ALoCoQnOi1qDicmTahetyNg7vhJiIGVVrJfay1ew86e96oW7RVRxSOVlSEHaaIlhbUQvZ0uanivG X-Received: by 10.66.168.197 with SMTP id zy5mr12415637pab.7.1409692794799; Tue, 02 Sep 2014 14:19:54 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.84.47 with SMTP id k44ls2518839qgd.73.gmail; Tue, 02 Sep 2014 14:19:54 -0700 (PDT) X-Received: by 10.220.49.10 with SMTP id t10mr2516604vcf.34.1409692794365; Tue, 02 Sep 2014 14:19:54 -0700 (PDT) Received: from mail-vc0-x232.google.com (mail-vc0-x232.google.com [2607:f8b0:400c:c03::232]) by mx.google.com with ESMTPS id tp5si2828128vcb.100.2014.09.02.14.19.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Sep 2014 14:19:54 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::232 as permitted sender) client-ip=2607:f8b0:400c:c03::232; Received: by mail-vc0-f178.google.com with SMTP id la4so7786029vcb.37 for ; Tue, 02 Sep 2014 14:19:54 -0700 (PDT) X-Received: by 10.221.21.201 with SMTP id qt9mr2481664vcb.39.1409692794284; Tue, 02 Sep 2014 14:19:54 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp587300vcb; Tue, 2 Sep 2014 14:19:53 -0700 (PDT) X-Received: by 10.68.179.66 with SMTP id de2mr50712130pbc.31.1409692793411; Tue, 02 Sep 2014 14:19:53 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ex6si7498862pdb.252.2014.09.02.14.19.52 for ; Tue, 02 Sep 2014 14:19:53 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755372AbaIBVTk (ORCPT + 25 others); Tue, 2 Sep 2014 17:19:40 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:55115 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755184AbaIBVTh (ORCPT ); Tue, 2 Sep 2014 17:19:37 -0400 Received: by mail-pd0-f178.google.com with SMTP id y13so9539564pdi.37 for ; Tue, 02 Sep 2014 14:19:37 -0700 (PDT) X-Received: by 10.68.57.194 with SMTP id k2mr50446588pbq.67.1409692777346; Tue, 02 Sep 2014 14:19:37 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id oa8sm6832952pdb.20.2014.09.02.14.19.35 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 02 Sep 2014 14:19:36 -0700 (PDT) From: Soren Brinkmann To: Michal Simek , Daniel Lezcano Cc: Russell King , "Rafael J. Wysocki" , =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Rob Herring , Mark Rutland , Pawel Moll , Ian Campbell , Kumar Gala Subject: [PATCH v2 6/9] ARM: zynq: cpuidle: Remove pointless code Date: Tue, 2 Sep 2014 14:19:11 -0700 Message-Id: <1409692754-13437-7-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.1.0.1.g27b9230 In-Reply-To: <1409692754-13437-1-git-send-email-soren.brinkmann@xilinx.com> References: <1409692754-13437-1-git-send-email-soren.brinkmann@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Original-Sender: linux-kernel-owner@vger.kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::232 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=neutral (body hash did not verify) header.i=@ Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Daniel Lezcano The core is not powered down, it is pointless to call the cpu_pm notifiers and switch to the global timer. Signed-off-by: Daniel Lezcano Reviewed-and-tested-by: Soren Brinkmann --- drivers/cpuidle/cpuidle-zynq.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/cpuidle/cpuidle-zynq.c b/drivers/cpuidle/cpuidle-zynq.c index aded75928028..c61b8b2a7c77 100644 --- a/drivers/cpuidle/cpuidle-zynq.c +++ b/drivers/cpuidle/cpuidle-zynq.c @@ -26,7 +26,6 @@ */ #include -#include #include #include #include @@ -38,15 +37,9 @@ static int zynq_enter_idle(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { - /* Devices must be stopped here */ - cpu_pm_enter(); - /* Add code for DDR self refresh start */ cpu_do_idle(); - /* Add code for DDR self refresh stop */ - cpu_pm_exit(); - return index; } @@ -59,8 +52,7 @@ static struct cpuidle_driver zynq_idle_driver = { .enter = zynq_enter_idle, .exit_latency = 10, .target_residency = 10000, - .flags = CPUIDLE_FLAG_TIME_VALID | - CPUIDLE_FLAG_TIMER_STOP, + .flags = CPUIDLE_FLAG_TIME_VALID, .name = "RAM_SR", .desc = "WFI and RAM Self Refresh", },