From patchwork Fri Aug 15 12:40:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 35458 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f72.google.com (mail-oa0-f72.google.com [209.85.219.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4473920523 for ; Fri, 15 Aug 2014 12:40:35 +0000 (UTC) Received: by mail-oa0-f72.google.com with SMTP id m1sf15004344oag.7 for ; Fri, 15 Aug 2014 05:40:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=1Z7gN7areTc6NH3wcc01DKV+UcHrl8NlFWZMLWKG4sY=; b=OyW349VX68NnhmDtycYvXrvpST3Tm43prJqF3R7iPjTkF0dTAunLrV8rA+GT3dtWhw ZXj6CpBjhYFN+NCeN92iwGGm78xPSHhyBSK/E0ittPqaPvNOMLRX3Y1o5dxRmbjqUN0z glwUk1XfpET1cxFetz54ZfNpUjYnZmCS1muSXe0wL51M48iQz7qyHZImpGNRQlJklfb3 NwzvywS9NAUUIzRbQ6Q4P7yPI2vlOA+AGw4D0wurRQ39mxQ/kGcTYE6a9OsZ+IGJ4Xmn DWdS8ntze7FF2CLqMu0lVEOredXEiwO5ndKLauV2NQAnY4hr4esx+oaZ2vrgT5LM+V2n CHZw== X-Gm-Message-State: ALoCoQmN8CPwo/Qb7l7uZgxy/bC8s51+cAYkzOvoX89hXZ/X+Ar3aalp9hWjOO8kCf9NkalN9+H0 X-Received: by 10.50.112.68 with SMTP id io4mr2718300igb.0.1408106434809; Fri, 15 Aug 2014 05:40:34 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.39.148 with SMTP id v20ls597693qgv.93.gmail; Fri, 15 Aug 2014 05:40:34 -0700 (PDT) X-Received: by 10.224.166.195 with SMTP id n3mr24278343qay.22.1408106434736; Fri, 15 Aug 2014 05:40:34 -0700 (PDT) Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by mx.google.com with ESMTPS id g8si887906qgd.7.2014.08.15.05.40.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 05:40:34 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) client-ip=209.85.220.170; Received: by mail-vc0-f170.google.com with SMTP id lf12so2855253vcb.15 for ; Fri, 15 Aug 2014 05:40:34 -0700 (PDT) X-Received: by 10.52.232.200 with SMTP id tq8mr13231938vdc.32.1408106434537; Fri, 15 Aug 2014 05:40:34 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp109573vcb; Fri, 15 Aug 2014 05:40:34 -0700 (PDT) X-Received: by 10.180.85.136 with SMTP id h8mr3753922wiz.67.1408106433854; Fri, 15 Aug 2014 05:40:33 -0700 (PDT) Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by mx.google.com with ESMTPS id fl1si2465035wib.76.2014.08.15.05.40.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 05:40:33 -0700 (PDT) Received-SPF: pass (google.com: domain of peter.griffin@linaro.org designates 209.85.212.182 as permitted sender) client-ip=209.85.212.182; Received: by mail-wi0-f182.google.com with SMTP id d1so758975wiv.15 for ; Fri, 15 Aug 2014 05:40:33 -0700 (PDT) X-Received: by 10.180.14.5 with SMTP id l5mr20754387wic.50.1408106433429; Fri, 15 Aug 2014 05:40:33 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id fr2sm6486559wib.7.2014.08.15.05.40.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Aug 2014 05:40:32 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kishon@ti.com, kgene.kim@samsung.com, maxime.ripard@free-electrons.com, linux-samsung-soc@vger.kernel.org Cc: peter.griffin@linaro.org, patches@linaro.org, lee.jones@linaro.org Subject: [PATCH 6/9] phy: phy-spear1340-miphy: Remove unncessary site specific OOM messages Date: Fri, 15 Aug 2014 13:40:13 +0100 Message-Id: <1408106416-19044-7-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> References: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin --- drivers/phy/phy-spear1340-miphy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c index 7135ba2..ee4d66f 100644 --- a/drivers/phy/phy-spear1340-miphy.c +++ b/drivers/phy/phy-spear1340-miphy.c @@ -249,10 +249,8 @@ static int spear1340_miphy_probe(struct platform_device *pdev) struct phy_provider *phy_provider; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(dev, "can't alloc spear1340_miphy private date memory\n"); + if (!priv) return -ENOMEM; - } priv->misc = syscon_regmap_lookup_by_phandle(dev->of_node, "misc");