From patchwork Fri Aug 15 12:40:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 35456 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f70.google.com (mail-yh0-f70.google.com [209.85.213.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 36D4F20523 for ; Fri, 15 Aug 2014 12:40:33 +0000 (UTC) Received: by mail-yh0-f70.google.com with SMTP id b6sf7337002yha.9 for ; Fri, 15 Aug 2014 05:40:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=1LtMIZHK+IxnfD3g+9tknDdDNQE++oRs99vx5gMz3Aw=; b=F743RPowkS6MmOYsQloGviVFzw5SOvVofHFCO53fLqtC9uGT8DHI4PhrNZUFT+snIk nMd1petP65GSzh+rzZslOVFwBAQoOV+KlhvLqdLqRD1RuBSdWhQWsZlNTwP+0ZM8JKM6 cZ+qI//grCb4D6NY7/Q1yJupSrCWcJdGPXzu1qE6paY+T/iIwpqjl+dJh7bM2eTjqwob D/JcX0nONuMEzEWPjg0n8puwsULSQsLw2RnOA62Tnyb1ea9m9PDX/vb2+pHqlq6Q8AYz a+4V0brUmlNAhTHath3Vri+JUByzV3GQOiwcbnLKFD/m4XMHGTOv8y+YXo+29vCUtX3e TVuQ== X-Gm-Message-State: ALoCoQnmQt2j/q3KAJqd2mY2eSN7gFi9vIVdV/Sns6GNWZ4dtwuwg4WAqwtRtndUnHZQ2dvQHwlM X-Received: by 10.52.29.72 with SMTP id i8mr9101947vdh.6.1408106432994; Fri, 15 Aug 2014 05:40:32 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.47.45 with SMTP id l42ls1324208qga.61.gmail; Fri, 15 Aug 2014 05:40:32 -0700 (PDT) X-Received: by 10.140.44.67 with SMTP id f61mr13169860qga.44.1408106432902; Fri, 15 Aug 2014 05:40:32 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id x73si11644090qge.65.2014.08.15.05.40.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 05:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id le20so2877794vcb.28 for ; Fri, 15 Aug 2014 05:40:32 -0700 (PDT) X-Received: by 10.52.142.102 with SMTP id rv6mr3231267vdb.26.1408106432625; Fri, 15 Aug 2014 05:40:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp109571vcb; Fri, 15 Aug 2014 05:40:32 -0700 (PDT) X-Received: by 10.180.73.139 with SMTP id l11mr20155891wiv.30.1408106431662; Fri, 15 Aug 2014 05:40:31 -0700 (PDT) Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by mx.google.com with ESMTPS id n2si2493227wic.30.2014.08.15.05.40.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 05:40:31 -0700 (PDT) Received-SPF: pass (google.com: domain of peter.griffin@linaro.org designates 74.125.82.176 as permitted sender) client-ip=74.125.82.176; Received: by mail-we0-f176.google.com with SMTP id q58so2301077wes.21 for ; Fri, 15 Aug 2014 05:40:31 -0700 (PDT) X-Received: by 10.180.198.78 with SMTP id ja14mr2664672wic.12.1408106431182; Fri, 15 Aug 2014 05:40:31 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id fr2sm6486559wib.7.2014.08.15.05.40.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Aug 2014 05:40:30 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kishon@ti.com, kgene.kim@samsung.com, maxime.ripard@free-electrons.com, linux-samsung-soc@vger.kernel.org Cc: peter.griffin@linaro.org, patches@linaro.org, lee.jones@linaro.org Subject: [PATCH 5/9] phy: phy-spear1310-miphy: Remove unncessary site specific OOM messages Date: Fri, 15 Aug 2014 13:40:12 +0100 Message-Id: <1408106416-19044-6-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> References: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin --- drivers/phy/phy-spear1310-miphy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c index 6dcbfcd..911d25b 100644 --- a/drivers/phy/phy-spear1310-miphy.c +++ b/drivers/phy/phy-spear1310-miphy.c @@ -212,10 +212,8 @@ static int spear1310_miphy_probe(struct platform_device *pdev) struct phy_provider *phy_provider; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(dev, "can't alloc spear1310_miphy private date memory\n"); + if (!priv) return -ENOMEM; - } priv->misc = syscon_regmap_lookup_by_phandle(dev->of_node, "misc");