From patchwork Tue Jul 22 11:11:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 34073 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9864F20540 for ; Tue, 22 Jul 2014 11:11:54 +0000 (UTC) Received: by mail-vc0-f199.google.com with SMTP id la4sf24088426vcb.6 for ; Tue, 22 Jul 2014 04:11:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=MFHcoNvedsDqiPPOuiNG+WLWlbHf19R7pC2qJT8zZro=; b=nG90ZPBAvvDpg8Y8bORbz65sRZXnlR+wFIrNhdcpJOYYLg89T/XCNV7+GjxWou9RUn HtHxlb/dlSAaM7faqdpBINNg/f+T5RKw4LqokhtxdhXt1fbLiZoC/7O7qUaZdahaB4MN yt60ePoDGscJSsp07Iq6XMmCb61W4x8rZyOVQ869ALpvGFRirWaE77CCqlzSoiIgHenA 3A1qLF95yrSAMRRxnsjBO+KJPCTbFd8LVtfw+LzBQJ8Is0Ejg9FdLEiRqbBeMCQqXEIU QY45tNsRNY/N1BzAo0bSTP3t41HbKVJ//paPFotwxn4rSaK2wtbz47qC91OYcwscXWWM vwnQ== X-Gm-Message-State: ALoCoQnN1kzuktCkQVA96lR0sZg5XXSu0fQ3skyFDhiXhwYfP7HYc6Yx/psrAUb6oX9vcNeUnYjZ X-Received: by 10.236.99.8 with SMTP id w8mr13527229yhf.31.1406027514432; Tue, 22 Jul 2014 04:11:54 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.41.82 with SMTP id y76ls1475559qgy.75.gmail; Tue, 22 Jul 2014 04:11:54 -0700 (PDT) X-Received: by 10.52.34.46 with SMTP id w14mr16465183vdi.64.1406027514309; Tue, 22 Jul 2014 04:11:54 -0700 (PDT) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id na9si88969vcb.64.2014.07.22.04.11.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:11:54 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id im17so14738732vcb.17 for ; Tue, 22 Jul 2014 04:11:54 -0700 (PDT) X-Received: by 10.52.244.81 with SMTP id xe17mr32723560vdc.24.1406027514230; Tue, 22 Jul 2014 04:11:54 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp186634vcb; Tue, 22 Jul 2014 04:11:53 -0700 (PDT) X-Received: by 10.42.93.84 with SMTP id w20mr22230740icm.49.1406027513775; Tue, 22 Jul 2014 04:11:53 -0700 (PDT) Received: from mail-ie0-f173.google.com (mail-ie0-f173.google.com [209.85.223.173]) by mx.google.com with ESMTPS id ih4si36444294igb.48.2014.07.22.04.11.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:11:53 -0700 (PDT) Received-SPF: pass (google.com: domain of lee.jones@linaro.org designates 209.85.223.173 as permitted sender) client-ip=209.85.223.173; Received: by mail-ie0-f173.google.com with SMTP id tr6so7996527ieb.18 for ; Tue, 22 Jul 2014 04:11:53 -0700 (PDT) X-Received: by 10.50.13.102 with SMTP id g6mr15590729igc.20.1406027513574; Tue, 22 Jul 2014 04:11:53 -0700 (PDT) Received: from localhost.localdomain (host109-148-232-149.range109-148.btcentralplus.com. [109.148.232.149]) by mx.google.com with ESMTPSA id lo3sm1302829igb.22.2014.07.22.04.11.51 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:11:53 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: sameo@linux.intel.com, Lee Jones Subject: [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch Date: Tue, 22 Jul 2014 12:11:15 +0100 Message-Id: <1406027485-15657-10-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1406027485-15657-1-git-send-email-lee.jones@linaro.org> References: <1406027485-15657-1-git-send-email-lee.jones@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This is part of an effort to clean-up the MFD subsystem. WARNING: Missing a blank line after declarations + u32 flags; + void (*callback)(void *, u16[]); WARNING: sizeof t should be sizeof(t) + memset(&t, 0, sizeof t); WARNING: void function return statements are not generally useful + return; +} total: 0 errors, 3 warnings, 542 lines checked Signed-off-by: Lee Jones --- drivers/mfd/ezx-pcap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c index 2ed774e..5a9a35e 100644 --- a/drivers/mfd/ezx-pcap.c +++ b/drivers/mfd/ezx-pcap.c @@ -25,8 +25,9 @@ struct pcap_adc_request { u8 bank; u8 ch[2]; u32 flags; - void (*callback)(void *, u16[]); void *data; + + void (*callback)(void *, u16[]); }; struct pcap_adc_sync_request { @@ -62,7 +63,7 @@ static int ezx_pcap_putget(struct pcap_chip *pcap, u32 *data) struct spi_message m; int status; - memset(&t, 0, sizeof t); + memset(&t, 0, sizeof(t)); spi_message_init(&m); t.len = sizeof(u32); spi_message_add_tail(&t, &m); @@ -211,7 +212,6 @@ static void pcap_irq_handler(unsigned int irq, struct irq_desc *desc) desc->irq_data.chip->irq_ack(&desc->irq_data); queue_work(pcap->workqueue, &pcap->isr_work); - return; } /* ADC */