From patchwork Wed Jun 4 15:01:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 31366 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f200.google.com (mail-ve0-f200.google.com [209.85.128.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2123A208CF for ; Wed, 4 Jun 2014 15:02:18 +0000 (UTC) Received: by mail-ve0-f200.google.com with SMTP id pa12sf38066893veb.3 for ; Wed, 04 Jun 2014 08:02:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=9XIHkMEeLR2+rs9Mi8H1TXWX9AXPnslv89hjICzdSiU=; b=F4D1RouK0PspJ82iQV7aGtxoPTD09iBcAvnpsJt18WvCKNeXgLRBkl0gOFlBz+n+rt Dc2Uon++oCCQuWlUZ6K4RmhnGCAlQFRQWb2KFL5RMtgwSJxvSFExrtEA8RQnvyUZIw6X 8M/r2SEjipIDHmkyKV0ACUYVsf6WpNMh0jYAhhQjLZNfvr5EgGqxa+Yf5htTFwTLajSG sT8S43S4vaHpu1rok+1Lj/XL1TdYfUnUHLEzxLGxVApBACpl29PhIHQdZPAqgNZCsX3I PkQSHG/X+jfDdUQqciwvx4dpIlamP7NBwwieGhIVPUgpyNK8TeZC2Rq24ZSo8Eh0nUVv bdNA== X-Gm-Message-State: ALoCoQlyHJLLBe3XPxNVLo0vGx13zgjPkS7AEm7rhCy8uHy0tuwTwj2Iy8M2Gy8BCbZHBgdtCjIn X-Received: by 10.58.220.4 with SMTP id ps4mr8302038vec.38.1401894134083; Wed, 04 Jun 2014 08:02:14 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.96.201 with SMTP id k67ls3131403qge.22.gmail; Wed, 04 Jun 2014 08:02:14 -0700 (PDT) X-Received: by 10.52.12.229 with SMTP id b5mr2512540vdc.52.1401894133963; Wed, 04 Jun 2014 08:02:13 -0700 (PDT) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx.google.com with ESMTPS id g7si1814342vek.12.2014.06.04.08.02.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Jun 2014 08:02:13 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) client-ip=209.85.128.172; Received: by mail-ve0-f172.google.com with SMTP id oz11so9061433veb.3 for ; Wed, 04 Jun 2014 08:02:13 -0700 (PDT) X-Received: by 10.52.25.130 with SMTP id c2mr32814611vdg.27.1401894133880; Wed, 04 Jun 2014 08:02:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp51986vcb; Wed, 4 Jun 2014 08:02:13 -0700 (PDT) X-Received: by 10.194.238.134 with SMTP id vk6mr5649852wjc.93.1401894132841; Wed, 04 Jun 2014 08:02:12 -0700 (PDT) Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by mx.google.com with ESMTPS id kd7si5146828wjc.149.2014.06.04.08.02.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Jun 2014 08:02:06 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 209.85.212.177 as permitted sender) client-ip=209.85.212.177; Received: by mail-wi0-f177.google.com with SMTP id f8so1668977wiw.10 for ; Wed, 04 Jun 2014 08:02:05 -0700 (PDT) X-Received: by 10.194.186.210 with SMTP id fm18mr5834173wjc.67.1401894125125; Wed, 04 Jun 2014 08:02:05 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id vc2sm4097654wjc.2.2014.06.04.08.02.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jun 2014 08:02:03 -0700 (PDT) From: Daniel Thompson To: Thomas Gleixner , Jason Cooper Cc: Daniel Thompson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org Subject: [PATCH v2] irqchip: nvic: Use the generic noop function Date: Wed, 4 Jun 2014 16:01:52 +0100 Message-Id: <1401894112-13386-1-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1401885425-12378-1-git-send-email-daniel.thompson@linaro.org> References: <1401885425-12378-1-git-send-email-daniel.thompson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Using the generic function saves looking up this custom one in a source navigator. Signed-off-by: Daniel Thompson Cc: Thomas Gleixner Cc: Jason Cooper --- drivers/irqchip/irq-nvic.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c index 70bdf6e..4ff0805 100644 --- a/drivers/irqchip/irq-nvic.c +++ b/drivers/irqchip/irq-nvic.c @@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) handle_IRQ(irq, regs); } -static void nvic_eoi(struct irq_data *d) -{ - /* - * This is a no-op as end of interrupt is signaled by the exception - * return sequence. - */ -} - static int __init nvic_of_init(struct device_node *node, struct device_node *parent) { @@ -102,7 +94,10 @@ static int __init nvic_of_init(struct device_node *node, gc->chip_types[0].regs.disable = NVIC_ICER; gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg; gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg; - gc->chip_types[0].chip.irq_eoi = nvic_eoi; + /* This is a no-op as end of interrupt is signaled by the + * exception return sequence. + */ + gc->chip_types[0].chip.irq_eoi = irq_gc_noop; /* disable interrupts */ writel_relaxed(~0, gc->reg_base + NVIC_ICER);