From patchwork Thu Apr 24 16:40:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pawel Moll X-Patchwork-Id: 28997 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f69.google.com (mail-qg0-f69.google.com [209.85.192.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 57D4B2036A for ; Thu, 24 Apr 2014 16:42:28 +0000 (UTC) Received: by mail-qg0-f69.google.com with SMTP id a108sf6122238qge.0 for ; Thu, 24 Apr 2014 09:42:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id :in-reply-to:references:cc:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-type:content-transfer-encoding; bh=g5W9XB6uURrlTeBgP3MEXLxvNocFNYihxKmw5vBqxsk=; b=IB+1HzBSlxFekabAVWladJY9p/x4u31CGU6N4VfqELxOJOFDz0+dEv/HfZzuqQNcW+ 062IvpGthrGzV4qujjw05GRHUQCcRbvZs3UK0ThSLaj4UtN9uOC3/7LJMQg67ZKRiy4n NrM15MABK/JnTLQEMjI3mZp0dUOYINJj4rVw3oQcgaGxwj6sf3K5yZSntdwm2rMafnUp ArCQ9A3JugQ2d0OKgZFnl6pAa6Gsw1dL9I7pyT32MbW4GwiP3KASqhBd2nI/EhhoI7TY CPysZ9a43OeVDAkQooS2qrgDaeWKqqz0qTORl85CGZ2A4NImAKgYLvOJ7tpnCFpsWYS3 8+Tg== X-Gm-Message-State: ALoCoQk5gGxQvqkvMdsTHYTBir0y4QAh6t5jyN63hREiUryIVj8/1hjc33KVj3Wx2TepDSopeFhD X-Received: by 10.236.203.113 with SMTP id e77mr1469861yho.15.1398357748156; Thu, 24 Apr 2014 09:42:28 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.49.112 with SMTP id p103ls1319461qga.41.gmail; Thu, 24 Apr 2014 09:42:28 -0700 (PDT) X-Received: by 10.58.171.229 with SMTP id ax5mr1936675vec.24.1398357747967; Thu, 24 Apr 2014 09:42:27 -0700 (PDT) Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by mx.google.com with ESMTPS id jb7si1054422vec.35.2014.04.24.09.42.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 24 Apr 2014 09:42:27 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.220.170; Received: by mail-vc0-f170.google.com with SMTP id hr9so3343334vcb.1 for ; Thu, 24 Apr 2014 09:42:27 -0700 (PDT) X-Received: by 10.52.108.228 with SMTP id hn4mr974259vdb.43.1398357747791; Thu, 24 Apr 2014 09:42:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp30574vcb; Thu, 24 Apr 2014 09:42:27 -0700 (PDT) X-Received: by 10.224.67.195 with SMTP id s3mr4374375qai.96.1398357746801; Thu, 24 Apr 2014 09:42:26 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id 75si2487059qgm.131.2014.04.24.09.42.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Apr 2014 09:42:26 -0700 (PDT) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WdMhn-0000fd-FP; Thu, 24 Apr 2014 16:40:59 +0000 Received: from fw-tnat.austin.arm.com ([217.140.110.23] helo=collaborate-mta1.arm.com) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WdMha-0000TL-LR for linux-arm-kernel@lists.infradead.org; Thu, 24 Apr 2014 16:40:47 +0000 Received: from hornet.Cambridge.Arm.com (hornet.cambridge.arm.com [10.2.201.45]) by collaborate-mta1.arm.com (Postfix) with ESMTP id 6C7FE13FB3D; Thu, 24 Apr 2014 11:40:20 -0500 (CDT) From: Pawel Moll To: arm@kernel.org Subject: [PATCH 1/4] clk: vexpress: NULL dereference on error path Date: Thu, 24 Apr 2014 17:40:15 +0100 Message-Id: <1398357618-11050-2-git-send-email-pawel.moll@arm.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1398357618-11050-1-git-send-email-pawel.moll@arm.com> References: <1398357618-11050-1-git-send-email-pawel.moll@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140424_094046_747103_6DFC6769 X-CRM114-Status: UNSURE ( 7.53 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.3.2 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_PASS SPF: sender matches SPF record Cc: Pawel Moll , Dan Carpenter , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: pawel.moll@arm.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Dan Carpenter If the allocation fails then we dereference the NULL in the error path. Just return directly. Fixes: ed27ff1db869 ('clk: Versatile Express clock generators ("osc") driver') Signed-off-by: Dan Carpenter Signed-off-by: Pawel Moll --- drivers/clk/versatile/clk-vexpress-osc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c index 2dc8b41..a535c7b 100644 --- a/drivers/clk/versatile/clk-vexpress-osc.c +++ b/drivers/clk/versatile/clk-vexpress-osc.c @@ -102,7 +102,7 @@ void __init vexpress_osc_of_setup(struct device_node *node) osc = kzalloc(sizeof(*osc), GFP_KERNEL); if (!osc) - goto error; + return; osc->func = vexpress_config_func_get_by_node(node); if (!osc->func) {