From patchwork Fri Apr 18 02:30:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 28604 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A05332013D for ; Fri, 18 Apr 2014 02:31:14 +0000 (UTC) Received: by mail-pa0-f71.google.com with SMTP id kq14sf4433370pab.6 for ; Thu, 17 Apr 2014 19:31:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=polCa05rFITkpSRMNQdwqhzHDZQO4gcjisTja2L41J4=; b=IwYrYnnyTgZXK/YJjFm+uAndyDnL2ZB1ycVhKEkww+0Iyp1pOBlImXF/ztLqTu8/Cd SZKoQzhntlx3Dzc02NNMHz8WXDW+Oqs+OvCpGems6ZaJVHm/j32DV5EUAnstfmmjGI+S l/1w4U1O+driEhXQW5+l+kXMjBIuq4bWqXf9Buobe9lJiRyOeArtOPTyM6j2bZcVzp9x rNKwehx447gOeLiT0YGo8uQOUGEYf+CVo6+2gI8+qmETU/Cle5n9+Zu6zf8pzJviCKtT I1oJdQ+kilhrtG7814r2Ajis1ZTfZduZlilHRrJo7C/GPP7S5hzarhnGYtZirs/NzdDO yvfw== X-Gm-Message-State: ALoCoQm5PJqvdHw/NV+rSSCZ/6Jv0556hF4HwLhdR9qet9DnHvn9Ba6MssVCNleLcBSw+7Q5ZGlQ X-Received: by 10.66.251.70 with SMTP id zi6mr5390130pac.37.1397788273424; Thu, 17 Apr 2014 19:31:13 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.101.245 with SMTP id u108ls1321730qge.79.gmail; Thu, 17 Apr 2014 19:31:13 -0700 (PDT) X-Received: by 10.220.103.141 with SMTP id k13mr111666vco.25.1397788273279; Thu, 17 Apr 2014 19:31:13 -0700 (PDT) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id ie18si4756347vec.175.2014.04.17.19.31.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Apr 2014 19:31:13 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id oy12so1787809veb.4 for ; Thu, 17 Apr 2014 19:31:13 -0700 (PDT) X-Received: by 10.221.29.137 with SMTP id ry9mr11588860vcb.6.1397788273207; Thu, 17 Apr 2014 19:31:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp80006vcb; Thu, 17 Apr 2014 19:31:12 -0700 (PDT) X-Received: by 10.68.215.68 with SMTP id og4mr19244852pbc.112.1397788271378; Thu, 17 Apr 2014 19:31:11 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8si15554312pbc.329.2014.04.17.19.31.10; Thu, 17 Apr 2014 19:31:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751519AbaDRCbF (ORCPT + 26 others); Thu, 17 Apr 2014 22:31:05 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:59949 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbaDRCaT (ORCPT ); Thu, 17 Apr 2014 22:30:19 -0400 Received: by mail-ie0-f173.google.com with SMTP id rl12so1174093iec.32 for ; Thu, 17 Apr 2014 19:30:19 -0700 (PDT) X-Received: by 10.50.43.135 with SMTP id w7mr928787igl.12.1397788219002; Thu, 17 Apr 2014 19:30:19 -0700 (PDT) Received: from localhost.localdomain (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id m8sm673967igx.9.2014.04.17.19.30.17 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Apr 2014 19:30:18 -0700 (PDT) From: Alex Elder To: bcm@fixthebug.org, mporter@linaro.org Cc: bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/10] ARM: bcm: use memory accessors for ioremapped area Date: Thu, 17 Apr 2014 21:30:06 -0500 Message-Id: <1397788215-20279-2-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1397788215-20279-1-git-send-email-elder@linaro.org> References: <1397788215-20279-1-git-send-email-elder@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: elder@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The pointer used to pass parameters to an "smc" call is produced through a call to ioremap(). As such, we should be using functions like writel() to access it. Signed-off-by: Alex Elder Reviewed-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/mach-bcm/bcm_kona_smc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c index 5e31e91..d881c72 100644 --- a/arch/arm/mach-bcm/bcm_kona_smc.c +++ b/arch/arm/mach-bcm/bcm_kona_smc.c @@ -79,11 +79,11 @@ static void __bcm_kona_smc(void *info) /* Check map in the bounce area */ BUG_ON(!bridge_data.initialized); - /* Copy one 32 bit word into the bounce area */ - args[0] = data->arg0; - args[1] = data->arg1; - args[2] = data->arg2; - args[3] = data->arg3; + /* Copy the four 32 bit argument values into the bounce area */ + writel_relaxed(data->arg0, args++); + writel_relaxed(data->arg1, args++); + writel_relaxed(data->arg2, args++); + writel(data->arg3, args); /* Flush caches for input data passed to Secure Monitor */ if (data->service_id != SSAPI_BRCM_START_VC_CORE)