From patchwork Fri Aug 30 22:59:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 19646 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f70.google.com (mail-yh0-f70.google.com [209.85.213.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4BEE724694 for ; Fri, 30 Aug 2013 23:00:09 +0000 (UTC) Received: by mail-yh0-f70.google.com with SMTP id z20sf2937912yhz.5 for ; Fri, 30 Aug 2013 16:00:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=qSb5DAyu7ISmamqGqm4/iF/pOJZLJoPlQ/JjlA/Bpac=; b=JcU3mWYZLnqQLzSq/K/tu4fQPAhMEC6FK/oXy0jdYhuUTWAZ21jYYs9WF/LXbb0F3y wOHMkGBLO4sYTs5S1MsJD98XucAPWECvr5rMQwDiU88XsZVaEMYrat2jWC+c2CXTpQ51 oJnx8ynuiJAylZsiI6GQnc9/LWXMCV8tsb/Mb0XLXTASZS6jxu0uOtVuG0498CCO9ZgC BNaSg9jtTp6TzWKTjJ1NgufCAETYWZ12Sjt9me+Im3Ndyvoxa8wN3kmEb2OdF4ZDZ+Kv asJmEcBzx8B8z0kuHIK07IYezU07p2emuZhbvfCriqEPiFDNG+ajbxUlzPP1jDBp0mxz wbjA== X-Received: by 10.236.207.103 with SMTP id m67mr2364760yho.1.1377903609094; Fri, 30 Aug 2013 16:00:09 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.29.229 with SMTP id n5ls1563172qeh.73.gmail; Fri, 30 Aug 2013 16:00:09 -0700 (PDT) X-Received: by 10.52.170.111 with SMTP id al15mr115126vdc.43.1377903608989; Fri, 30 Aug 2013 16:00:08 -0700 (PDT) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by mx.google.com with ESMTPS id vr9si71862vcb.126.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 30 Aug 2013 16:00:08 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.175; Received: by mail-vc0-f175.google.com with SMTP id ia10so1718726vcb.34 for ; Fri, 30 Aug 2013 16:00:08 -0700 (PDT) X-Gm-Message-State: ALoCoQnCdaYQytDbsfmnscjMjIwI1j9NzgHZbgZyiHlzWWPBbQpllU9QzBa4gUNqxRNNBpXnmwMd X-Received: by 10.58.198.13 with SMTP id iy13mr10393045vec.11.1377903608906; Fri, 30 Aug 2013 16:00:08 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp117356vcz; Fri, 30 Aug 2013 16:00:08 -0700 (PDT) X-Received: by 10.66.138.74 with SMTP id qo10mr5809694pab.140.1377903607898; Fri, 30 Aug 2013 16:00:07 -0700 (PDT) Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) by mx.google.com with ESMTPS id zp6si182724pbc.127.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 30 Aug 2013 16:00:07 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.192.175 is neither permitted nor denied by best guess record for domain of christoffer.dall@linaro.org) client-ip=209.85.192.175; Received: by mail-pd0-f175.google.com with SMTP id q10so2404920pdj.20 for ; Fri, 30 Aug 2013 16:00:07 -0700 (PDT) X-Received: by 10.66.159.132 with SMTP id xc4mr13517918pab.27.1377903607479; Fri, 30 Aug 2013 16:00:07 -0700 (PDT) Received: from localhost.localdomain (c-67-169-183-77.hsd1.ca.comcast.net. [67.169.183.77]) by mx.google.com with ESMTPSA id om2sm241835pbc.30.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 30 Aug 2013 16:00:06 -0700 (PDT) From: Christoffer Dall To: Gleb Natapov , Paolo Bonzini Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, patches@linaro.org, Christoffer Dall Subject: [PATCH 1/4] ARM: KVM: Fix kvm_set_pte assignment Date: Fri, 30 Aug 2013 15:59:54 -0700 Message-Id: <1377903597-18704-2-git-send-email-christoffer.dall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1377903597-18704-1-git-send-email-christoffer.dall@linaro.org> References: <1377903597-18704-1-git-send-email-christoffer.dall@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: christoffer.dall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , THe kvm_set_pte function was actually assigning the entire struct to the structure member, which should work because the structure only has that one member, but it is still not very nice. Acked-by: Marc Zyngier Signed-off-by: Christoffer Dall --- arch/arm/include/asm/kvm_mmu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/asm/kvm_mmu.h b/arch/arm/include/asm/kvm_mmu.h index 472ac70..9b28c41 100644 --- a/arch/arm/include/asm/kvm_mmu.h +++ b/arch/arm/include/asm/kvm_mmu.h @@ -64,7 +64,7 @@ void kvm_clear_hyp_idmap(void); static inline void kvm_set_pte(pte_t *pte, pte_t new_pte) { - pte_val(*pte) = new_pte; + *pte = new_pte; /* * flush_pmd_entry just takes a void pointer and cleans the necessary * cache entries, so we can reuse the function for ptes.