From patchwork Wed May 15 09:51:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 16952 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ye0-f199.google.com (mail-ye0-f199.google.com [209.85.213.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EA1CD2396C for ; Wed, 15 May 2013 09:53:52 +0000 (UTC) Received: by mail-ye0-f199.google.com with SMTP id l11sf1916227yen.2 for ; Wed, 15 May 2013 02:53:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=t9mSnaIYJP9MNC52yN4g6PWkSCoBJApwKaYdRAs+Ty4=; b=B+4Zw3xqTmTnJIPuAh7GIn3+YxZ+8y3S50CXLL8/wFnf108EdDsKcJH2mDh+GsA69s kp7l2u3dIvs1aggF4RLTGNIix4YPDe8dia7RoOWaocsAXyFZ3JHRLMUfOfuHYL0x50OF wwFXWSG91UseI4AHvRgI822DwyDaMXwNAs8+59EApZ5QT5JvO0caH7l1LJJFaeTHLk96 mdqp0gBDGDGvwJ6ay7Ww4A/yZ/C15zzUUz/HkLU6m2U1Y3Se1oVWAQXQhyRHLmYqRBP6 6MPIf79lhQI/l0Qv3kWC4dGA60l2tTrTBPNsNzlHKCmBMS1LA4IgN/R4yJP09Lp/dGsB 4Iew== X-Received: by 10.236.59.39 with SMTP id r27mr6008705yhc.47.1368611596387; Wed, 15 May 2013 02:53:16 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.105.7 with SMTP id gi7ls631517qeb.56.gmail; Wed, 15 May 2013 02:53:16 -0700 (PDT) X-Received: by 10.52.175.71 with SMTP id by7mr20468585vdc.85.1368611596242; Wed, 15 May 2013 02:53:16 -0700 (PDT) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by mx.google.com with ESMTPS id gr7si1040105vdc.51.2013.05.15.02.53.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 15 May 2013 02:53:16 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.181; Received: by mail-vc0-f181.google.com with SMTP id lf11so1596405vcb.26 for ; Wed, 15 May 2013 02:53:16 -0700 (PDT) X-Received: by 10.52.173.108 with SMTP id bj12mr858284vdc.57.1368611596073; Wed, 15 May 2013 02:53:16 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.217.15 with SMTP id hk15csp11387vcb; Wed, 15 May 2013 02:53:15 -0700 (PDT) X-Received: by 10.194.58.141 with SMTP id r13mr2791076wjq.11.1368611595031; Wed, 15 May 2013 02:53:15 -0700 (PDT) Received: from mail-we0-x236.google.com (mail-we0-x236.google.com [2a00:1450:400c:c03::236]) by mx.google.com with ESMTPS id bw19si6867290wib.95.2013.05.15.02.53.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 15 May 2013 02:53:15 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:400c:c03::236 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=2a00:1450:400c:c03::236; Received: by mail-we0-f182.google.com with SMTP id t60so1421939wes.13 for ; Wed, 15 May 2013 02:53:14 -0700 (PDT) X-Received: by 10.194.19.2 with SMTP id a2mr2793272wje.8.1368611594502; Wed, 15 May 2013 02:53:14 -0700 (PDT) Received: from localhost.localdomain (cpc34-aztw25-2-0-cust250.18-1.cable.virginmedia.com. [86.16.136.251]) by mx.google.com with ESMTPSA id q13sm2898210wie.8.2013.05.15.02.53.12 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 15 May 2013 02:53:13 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, balbi@ti.com, linux-usb@vger.kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net, herbert@gondor.apana.org.au, vinod.koul@intel.com Cc: arnd@arndb.de, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, Lee Jones , Dan Williams , Per Forlin , Rabin Vincent Subject: [PATCH 35/39] dmaengine: ste_dma40_ll: Replace meaningless register set with comment Date: Wed, 15 May 2013 10:51:58 +0100 Message-Id: <1368611522-9984-36-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQk47MlPgSF6yfYfW9gz44xOkA/b7Z1GYrY2H/fwvpV96LIkvJYftIQbLMUysATSfv0bUPa/ X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Unsure of the author's intentions, rather than just removing the nop, we're replacing it with a comment containing the possible intention of the statement OR:ing with 0. Cc: Vinod Koul Cc: Dan Williams Cc: Per Forlin Cc: Rabin Vincent Signed-off-by: Lee Jones --- drivers/dma/ste_dma40_ll.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma/ste_dma40_ll.c b/drivers/dma/ste_dma40_ll.c index a035dfe..27b818d 100644 --- a/drivers/dma/ste_dma40_ll.c +++ b/drivers/dma/ste_dma40_ll.c @@ -182,8 +182,10 @@ static int d40_phy_fill_lli(struct d40_phy_lli *lli, else lli->reg_cfg &= ~BIT(D40_SREG_CFG_TIM_POS); - /* Post link */ - lli->reg_lnk |= 0 << D40_SREG_LNK_PHY_PRE_POS; + /* + * Post link - D40_SREG_LNK_PHY_PRE_POS = 0 + * Relink happens after transfer completion. + */ return 0; }