From patchwork Fri May 3 14:32:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 16690 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f72.google.com (mail-qa0-f72.google.com [209.85.216.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CADD323905 for ; Fri, 3 May 2013 14:35:41 +0000 (UTC) Received: by mail-qa0-f72.google.com with SMTP id i13sf1237153qae.3 for ; Fri, 03 May 2013 07:35:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=t9mSnaIYJP9MNC52yN4g6PWkSCoBJApwKaYdRAs+Ty4=; b=TFAo73h/dAtoFjF0uNc9VU0k36ZrVZPCAsjM5BxIckNJ7DsGcUfwmFHTPVrN/WZVMW M3eXe+bRxqr0ZG9+JnkddLDxm0exQxjVixRRzfZk9HJaPgLsfNbT1fXtSm8PoGrgo49B kLawQTtmFjG0dWaoyghwg5ySlAqJ9nNCP2giXhiEc6d8NU2jV/UhcJsTorkrE0WZewC2 6oEklGLfZ+tMoHEQN20856+bHLtxGUtKrTNEoAwkzPjnbSg+l9JqYL3itZp43C437YjV 087+ErLWDztaLZ5TMQfs/YB22mYCn8yew9o5pssnIGFuXOVagUoxJH8Nd3da+ym9WiRF 3uBQ== X-Received: by 10.236.19.198 with SMTP id n46mr8366947yhn.8.1367591731961; Fri, 03 May 2013 07:35:31 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.96.2 with SMTP id do2ls1873106qeb.62.gmail; Fri, 03 May 2013 07:35:31 -0700 (PDT) X-Received: by 10.52.230.164 with SMTP id sz4mr3233739vdc.118.1367591731712; Fri, 03 May 2013 07:35:31 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id ha8si5186541vdb.9.2013.05.03.07.35.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 03 May 2013 07:35:31 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id hz10so1447002vcb.24 for ; Fri, 03 May 2013 07:35:31 -0700 (PDT) X-Received: by 10.58.48.166 with SMTP id m6mr3650690ven.59.1367591731637; Fri, 03 May 2013 07:35:31 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp25298veb; Fri, 3 May 2013 07:35:31 -0700 (PDT) X-Received: by 10.180.82.74 with SMTP id g10mr27328486wiy.10.1367591730685; Fri, 03 May 2013 07:35:30 -0700 (PDT) Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [2a00:1450:400c:c05::236]) by mx.google.com with ESMTPS id m2si9815756wie.86.2013.05.03.07.35.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 03 May 2013 07:35:30 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:400c:c05::236 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=2a00:1450:400c:c05::236; Received: by mail-wi0-f182.google.com with SMTP id m6so679451wiv.15 for ; Fri, 03 May 2013 07:35:30 -0700 (PDT) X-Received: by 10.194.122.131 with SMTP id ls3mr14223875wjb.55.1367591730281; Fri, 03 May 2013 07:35:30 -0700 (PDT) Received: from localhost.localdomain (cpc34-aztw25-2-0-cust250.18-1.cable.virginmedia.com. [86.16.136.251]) by mx.google.com with ESMTPSA id o3sm17516019wia.2.2013.05.03.07.35.28 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 03 May 2013 07:35:29 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, Lee Jones , Vinod Koul , Dan Williams , Per Forlin , Rabin Vincent Subject: [PATCH 59/63] dmaengine: ste_dma40_ll: Replace meaningless register set with comment Date: Fri, 3 May 2013 15:32:45 +0100 Message-Id: <1367591569-32197-60-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1367591569-32197-1-git-send-email-lee.jones@linaro.org> References: <1367591569-32197-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQlp6PXjjNKXEL9uXCfS+FOi0c5VqbAPYkpCFx/BVTA5a82uWcefW1Q0C/afr6I/hf17u4aE X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Unsure of the author's intentions, rather than just removing the nop, we're replacing it with a comment containing the possible intention of the statement OR:ing with 0. Cc: Vinod Koul Cc: Dan Williams Cc: Per Forlin Cc: Rabin Vincent Signed-off-by: Lee Jones --- drivers/dma/ste_dma40_ll.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma/ste_dma40_ll.c b/drivers/dma/ste_dma40_ll.c index a035dfe..27b818d 100644 --- a/drivers/dma/ste_dma40_ll.c +++ b/drivers/dma/ste_dma40_ll.c @@ -182,8 +182,10 @@ static int d40_phy_fill_lli(struct d40_phy_lli *lli, else lli->reg_cfg &= ~BIT(D40_SREG_CFG_TIM_POS); - /* Post link */ - lli->reg_lnk |= 0 << D40_SREG_LNK_PHY_PRE_POS; + /* + * Post link - D40_SREG_LNK_PHY_PRE_POS = 0 + * Relink happens after transfer completion. + */ return 0; }