From patchwork Thu May 2 15:48:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 16596 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f71.google.com (mail-qa0-f71.google.com [209.85.216.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 182CD238EC for ; Thu, 2 May 2013 15:48:39 +0000 (UTC) Received: by mail-qa0-f71.google.com with SMTP id hg5sf1126120qab.6 for ; Thu, 02 May 2013 08:48:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-beenthere:x-received:received-spf:x-received :x-forwarded-to:x-forwarded-for:delivered-to:x-received:received-spf :x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type:content-transfer-encoding; bh=vlt/TmOLSxRDIZOTn98x1VlMOFmZSQ+d71SUopZ9kUA=; b=S/dsP8+zEGb3RD9aWez8NUEbCJE/hPSGrN243LE5YfW+1vKi/heAMUhTMfNr0dwPKe rHt+cDfuFomNq9izyt37b2rmvkyNG3c0tOdwHuTRkmc39TE+A4TMLoPUvHdVnL0RmMnR CqL5YJ7OeQNSfDUCEcQ4qqG5IhhD2P9AL59l1THqDcov+t+/PQHtDCXy0zirtnb0WnCO o1mRp2h5u+OS99qa08oUr/QMriQXTwvi/+/KoBvkiYvUzrpoDZZYhSlqKsPGvdH+d//Y VSndfVu0Zw/HtdAAow+pBTQPSgVAe5PZjPq98Ho41Ea/4ii70taC1bFNgjRQE144wlK9 trhg== X-Received: by 10.59.5.138 with SMTP id cm10mr6304695ved.36.1367509711416; Thu, 02 May 2013 08:48:31 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.36.69 with SMTP id o5ls1194535qej.55.gmail; Thu, 02 May 2013 08:48:31 -0700 (PDT) X-Received: by 10.58.120.14 with SMTP id ky14mr2364318veb.16.1367509710903; Thu, 02 May 2013 08:48:30 -0700 (PDT) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id c9si3141451vcw.73.2013.05.02.08.48.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 02 May 2013 08:48:30 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id hx10so626625vcb.3 for ; Thu, 02 May 2013 08:48:30 -0700 (PDT) X-Received: by 10.52.66.101 with SMTP id e5mr2008628vdt.57.1367509710802; Thu, 02 May 2013 08:48:30 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp208396veb; Thu, 2 May 2013 08:48:30 -0700 (PDT) X-Received: by 10.180.86.38 with SMTP id m6mr13734168wiz.25.1367509709486; Thu, 02 May 2013 08:48:29 -0700 (PDT) Received: from mail-wi0-x234.google.com (mail-wi0-x234.google.com [2a00:1450:400c:c05::234]) by mx.google.com with ESMTPS id e15si2159997wjz.153.2013.05.02.08.48.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 02 May 2013 08:48:29 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:400c:c05::234 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=2a00:1450:400c:c05::234; Received: by mail-wi0-f180.google.com with SMTP id h11so748741wiv.7 for ; Thu, 02 May 2013 08:48:29 -0700 (PDT) X-Received: by 10.194.122.131 with SMTP id ls3mr8796752wjb.55.1367509709074; Thu, 02 May 2013 08:48:29 -0700 (PDT) Received: from localhost.localdomain (cpc34-aztw25-2-0-cust250.18-1.cable.virginmedia.com. [86.16.136.251]) by mx.google.com with ESMTPSA id a9sm39857525wiv.0.2013.05.02.08.48.27 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 02 May 2013 08:48:28 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, Lee Jones , Russell King , Chris Ball Subject: [PATCH 3/4] mmc: mmci: Ensure return value of regulator_enable() is checked Date: Thu, 2 May 2013 16:48:09 +0100 Message-Id: <1367509690-24022-4-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1367509690-24022-1-git-send-email-lee.jones@linaro.org> References: <1367509690-24022-1-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 X-Gm-Message-State: ALoCoQlCIRWwewcrUvJKawprEUo+dJ2ZQldyhYjlyIy0W74DyF7LIAtCiOLZ2bzbfNRVXzfB3BvJ X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch suppresses the warning below: drivers/mmc/host/mmci.c: In function ‘mmci_set_ios’: drivers/mmc/host/mmci.c:1165:20: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result] Cc: Russell King Cc: Chris Ball Signed-off-by: Lee Jones --- drivers/mmc/host/mmci.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index 375c109..f4f3038 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -1130,6 +1130,7 @@ static void mmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) struct variant_data *variant = host->variant; u32 pwr = 0; unsigned long flags; + int ret; pm_runtime_get_sync(mmc_dev(mmc)); @@ -1161,8 +1162,12 @@ static void mmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) break; case MMC_POWER_ON: if (!IS_ERR(mmc->supply.vqmmc) && - !regulator_is_enabled(mmc->supply.vqmmc)) - regulator_enable(mmc->supply.vqmmc); + !regulator_is_enabled(mmc->supply.vqmmc)) { + ret = regulator_enable(mmc->supply.vqmmc); + if (ret < 0) + dev_err(mmc_dev(mmc), + "failed to enable vqmmc regulator\n"); + } pwr |= MCI_PWR_ON; break;