From patchwork Fri Apr 26 11:38:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 16432 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f198.google.com (mail-vc0-f198.google.com [209.85.220.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 162442397A for ; Fri, 26 Apr 2013 12:24:29 +0000 (UTC) Received: by mail-vc0-f198.google.com with SMTP id ha12sf2287597vcb.5 for ; Fri, 26 Apr 2013 05:23:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=5jJ1uYjCBkm21BLyWzRhp8mL0qSuEdFyzzPsGUNQM9o=; b=Phh+V8+brZlJLsRzAFh0/lgVpjd+eKAyC6fbpImxqX7IT5kg6zESCcRGWygsRCi2D1 QYARlvShFE9FytnsvOcwE97dV6x6g7ZIDRVZyGpqWc/rYqPmwUV83UjgcApmwas8V8Fe HSUo7DiJseC6l4JXeIB2/va3vsnyhQQEUjnTG/AJTeKKhvbkfDl9+QJAdfHOANIFp/RJ RfAOVhqgTl6BarDf/3yoxCNwjIod/Ghp462b3RqCc72Yq7PITAhLKBL8Zy3GY4yjSkh8 r27R/J/tdJxYWyfXyv2LsOoKtfmr/T+ss0nr04/WkkBno3t3MMiIbtfXHqO/MdXzj2+l LfNg== X-Received: by 10.236.81.115 with SMTP id l79mr5765173yhe.20.1366979013519; Fri, 26 Apr 2013 05:23:33 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.71.202 with SMTP id x10ls1747906qeu.56.gmail; Fri, 26 Apr 2013 05:23:33 -0700 (PDT) X-Received: by 10.52.37.4 with SMTP id u4mr6192081vdj.54.1366979013311; Fri, 26 Apr 2013 05:23:33 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id ij9si5286595vdb.17.2013.04.26.05.23.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Apr 2013 05:23:33 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id gd11so3800170vcb.28 for ; Fri, 26 Apr 2013 05:23:33 -0700 (PDT) X-Received: by 10.52.69.109 with SMTP id d13mr2390153vdu.75.1366979013189; Fri, 26 Apr 2013 05:23:33 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp66308veb; Fri, 26 Apr 2013 05:23:31 -0700 (PDT) X-Received: by 10.194.10.129 with SMTP id i1mr66764656wjb.21.1366979010373; Fri, 26 Apr 2013 05:23:30 -0700 (PDT) Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [2a00:1450:400c:c00::22c]) by mx.google.com with ESMTPS id eg10si684994wic.103.2013.04.26.05.23.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Apr 2013 05:23:30 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:400c:c00::22c is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=2a00:1450:400c:c00::22c; Received: by mail-wg0-f44.google.com with SMTP id a12so2060273wgh.23 for ; Fri, 26 Apr 2013 05:23:30 -0700 (PDT) X-Received: by 10.180.183.210 with SMTP id eo18mr3679238wic.17.1366979007376; Fri, 26 Apr 2013 05:23:27 -0700 (PDT) Received: from localhost.localdomain (cpc34-aztw25-2-0-cust250.18-1.cable.virginmedia.com. [86.16.136.251]) by mx.google.com with ESMTPSA id ge7sm3509340wib.6.2013.04.26.05.23.25 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Apr 2013 05:23:26 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, linus.walleij@stericsson.com, Lee Jones , Vinod Koul , Dan Williams , Per Forlin , Rabin Vincent Subject: [PATCH 6/6] dmaengine: ste_dma40_ll: Replace meaningless register set with comment Date: Fri, 26 Apr 2013 12:38:15 +0100 Message-Id: <1366976295-11728-7-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1366976295-11728-1-git-send-email-lee.jones@linaro.org> References: <1366976295-11728-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQnNh5ay9F0nwSNFZjcpRAjS8Qr/6MvjczinOYktJ1s9Fi4pfKaPHOT+Je0rcrBf81OhB1Sx X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Unsure of the author's intentions, rather than just removing the nop, we're replacing it with a comment containing the possible intention of the statement OR:ing with 0. Cc: Vinod Koul Cc: Dan Williams Cc: Per Forlin Cc: Rabin Vincent Signed-off-by: Lee Jones --- drivers/dma/ste_dma40_ll.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma/ste_dma40_ll.c b/drivers/dma/ste_dma40_ll.c index ec03000..f2e15ac 100644 --- a/drivers/dma/ste_dma40_ll.c +++ b/drivers/dma/ste_dma40_ll.c @@ -189,8 +189,10 @@ static int d40_phy_fill_lli(struct d40_phy_lli *lli, else lli->reg_cfg &= ~BIT(D40_SREG_CFG_TIM_POS); - /* Post link */ - lli->reg_lnk |= 0 << D40_SREG_LNK_PHY_PRE_POS; + /* + * Post link - D40_SREG_LNK_PHY_PRE_POS = 0 + * Relink happens after transfer completion. + */ return 0; }