From patchwork Fri Mar 8 11:09:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 15275 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 4DDDF23E00 for ; Fri, 8 Mar 2013 11:20:29 +0000 (UTC) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by fiordland.canonical.com (Postfix) with ESMTP id F37C9A186E2 for ; Fri, 8 Mar 2013 11:20:28 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id n11so849464vch.33 for ; Fri, 08 Mar 2013 03:20:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=wHMqOrjnSnLTtT5GCVxEBe14ejG+Ti70AHyv8QWSvrM=; b=RewFfRh8klwciVEA25ua4d/abkFE9VR4SucSPjF5ho8aE1jycLKBV2tHKOVTTntuuk olkHQ5gWz2EJYE/IVmlB6xhfPBWRmyAuCJGHf2ClJt+100Mw7lakNJmr8z8O1KWZwjiO 9fVQzWsZFFEzJsum0xnWtFtlP7cPX3Gxz6+htiOejmMrFf3pThe7sDJ/oqFfmoZkGfbf KbTlGRSdhQqyGuBXnscvN8QGzkBuT9Aw1Jefw0IxzLsZHyDnc1vZ+AYIsPaPu0UFFkFt YTkHwK22tpZ6PfO1OU2/2sT94vcwXJtwadNWMvVuSPiXIiDjaV5c1njWaMahYj6hZYPv aC9w== X-Received: by 10.52.29.18 with SMTP id f18mr652316vdh.57.1362741628354; Fri, 08 Mar 2013 03:20:28 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp113411veb; Fri, 8 Mar 2013 03:20:27 -0800 (PST) X-Received: by 10.66.14.69 with SMTP id n5mr3345652pac.203.1362741627104; Fri, 08 Mar 2013 03:20:27 -0800 (PST) Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by mx.google.com with ESMTPS id ib1si5247705pbc.103.2013.03.08.03.20.25 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 08 Mar 2013 03:20:27 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.48 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) client-ip=209.85.220.48; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.48 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) smtp.mail=tushar.behera@linaro.org Received: by mail-pa0-f48.google.com with SMTP id hz10so1236375pad.7 for ; Fri, 08 Mar 2013 03:20:25 -0800 (PST) X-Received: by 10.68.136.42 with SMTP id px10mr2774811pbb.32.1362741625659; Fri, 08 Mar 2013 03:20:25 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id e7sm2798892pbm.10.2013.03.08.03.20.22 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 08 Mar 2013 03:20:24 -0800 (PST) From: Tushar Behera To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: linux@arm.linux.org.uk, kgene.kim@samsung.com, patches@linaro.org Subject: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower Date: Fri, 8 Mar 2013 16:39:48 +0530 Message-Id: <1362740988-16483-1-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQk3qEHomc5K90qi4roWaTdojU7Y2wPTUBbkTdFAlKG0yR0ToLUjErDbLALxHrZVt14KmB3g As per commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro in platform_do_lowpower."), wfi macro should be used instead of the hardcoded WFI instruction. This fixes following oops when the kernel is compiled in Thumb-2 mode on EXYNOS5. (Tested on EXYNOS5250 based Arndale board) $ reboot Disabling non-boot CPUs ... IRQ153 no longer affine to CPU1 CPU1: shutdown Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP THUMB2 Modules linked in: CPU: 1 Not tainted (3.9.0-rc1-00015-gce76372 #1) PC is at 0xc065858e LR is at exynos_cpu_die+0x53/0xc0 Signed-off-by: Tushar Behera --- arch/arm/mach-exynos/hotplug.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c index c3f825b..d9712fe 100644 --- a/arch/arm/mach-exynos/hotplug.c +++ b/arch/arm/mach-exynos/hotplug.c @@ -99,13 +99,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) if (cpu == 1) __raw_writel(0, S5P_ARM_CORE1_CONFIGURATION); - /* - * here's the WFI - */ - asm(".word 0xe320f003\n" - : - : - : "memory", "cc"); + wfi(); if (pen_release == cpu_logical_map(cpu)) { /*