From patchwork Fri Feb 15 12:57:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 14918 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 3D14A23E01 for ; Fri, 15 Feb 2013 12:58:30 +0000 (UTC) Received: from mail-vb0-f52.google.com (mail-vb0-f52.google.com [209.85.212.52]) by fiordland.canonical.com (Postfix) with ESMTP id E88FAA18769 for ; Fri, 15 Feb 2013 12:58:29 +0000 (UTC) Received: by mail-vb0-f52.google.com with SMTP id fa15so2073472vbb.39 for ; Fri, 15 Feb 2013 04:58:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=CNXaD9aahzd7SAkvHsT8fXJM/mUVKiT1jLlcVKPyymc=; b=PA4FU+MZi1MS5CddyeHlzSZk4MPP6cOGobTN74i964tL8qTQYjk+34d3zJIwA3BjEd 4SqHDy7baHM/gRW8qmb8PQRYvRH9RWdw6f5gb7MhVm0pbJ9KzpQm13kts7ydru9PfDn6 ZNgsIvB+kjH8bkpQie5Exvckh3zMQW5OuZixX/smJQ7XgHjw64wKkrQ95ka7D9+KM0EJ 5lo/D3ohk0gVzWMc7bWmC1Uu/PneGIKyAFfcWTOYk2w/fnVGlKPix+CLCSONYmiqOjk1 fjpWsRw5Wn31soFv8SFl7UVTJs+wx93LLD0YGquuO6rabZR9q9OI/aH46r2iQRPmj+PW /Tfg== X-Received: by 10.221.0.79 with SMTP id nl15mr2926650vcb.41.1360933109470; Fri, 15 Feb 2013 04:58:29 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.221.4.5 with SMTP id oa5csp11439vcb; Fri, 15 Feb 2013 04:58:29 -0800 (PST) X-Received: by 10.180.106.34 with SMTP id gr2mr3947139wib.18.1360933108594; Fri, 15 Feb 2013 04:58:28 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by mx.google.com with ESMTPS id ba10si1050489wib.62.2013.02.15.04.58.28 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Feb 2013 04:58:28 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.181 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=209.85.212.181; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.181 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) smtp.mail=lee.jones@linaro.org Received: by mail-wi0-f181.google.com with SMTP id hm6so1119743wib.2 for ; Fri, 15 Feb 2013 04:58:28 -0800 (PST) X-Received: by 10.180.105.232 with SMTP id gp8mr5627996wib.33.1360933107966; Fri, 15 Feb 2013 04:58:27 -0800 (PST) Received: from localhost.localdomain (cpc34-aztw25-2-0-cust250.18-1.cable.virginmedia.com. [86.16.136.251]) by mx.google.com with ESMTPS id j4sm2852410wiz.10.2013.02.15.04.58.25 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Feb 2013 04:58:26 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com Cc: arnd@arndb.de, linus.walleij@stericsson.com, Lee Jones Subject: [PATCH 33/35] mfd: ab8500-debug: Add explicit dependencies Date: Fri, 15 Feb 2013 12:57:04 +0000 Message-Id: <1360933026-30325-34-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1360933026-30325-1-git-send-email-lee.jones@linaro.org> References: <1360933026-30325-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQm4r5O8Posz44m+3KpNwz0N2UVlXp9rllGqWbyVsOwhEsC6jnZYqiITfPTXYNtCDcVpxd1V From: Linus Walleij As I am working on SPARSE_IRQ a number of implicit resource grabs in the kernel become evident. For example, some includes like would implicitly include and then from there . In many cases it is masking the fact that drivers do not properly use resources to pass their dependencies, base addresses etc. So write explicit #include statements with TODO items to have this fixed the proper way to all drivers doing this. Signed-off-by: Linus Walleij Signed-off-by: Lee Jones Reviewed-by: Philippe LANGLAIS --- drivers/mfd/ab8500-debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index b5af8be..37f595d 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -90,6 +90,9 @@ #include #endif +/* TODO: this file should not reference IRQ_DB8500_AB8500! */ +#include + static u32 debug_bank; static u32 debug_address;