From patchwork Fri Feb 15 12:57:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 14915 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 6F75123E01 for ; Fri, 15 Feb 2013 12:58:23 +0000 (UTC) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by fiordland.canonical.com (Postfix) with ESMTP id E5E03A1870B for ; Fri, 15 Feb 2013 12:58:22 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id n11so2097690vch.19 for ; Fri, 15 Feb 2013 04:58:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:mime-version:content-type :content-transfer-encoding:x-gm-message-state; bh=S880P6fYZPGms/B771QxQh6vZxLE2QA6PozfMNJNFEA=; b=Z3pvNPhNkzaQR5oe0Fjb86nGYpxZBxKvakzN+vMxvgzfF6cu00t5Tvd2+bOR2+x0ik UzZpebgXLH5qmVTS+eZiPaE6haTr4O1kI3xNgCrSbsokE1bVWGauw6hLpqCzQFiRlMOZ 3ek/hngDqYaar2mjplPv/kAgQ2nJYEImoQBc/s6tlDWWWY0ZI10MaK7pkyFmQpHOlHQg OKDXO0d1oPUEymrqJdpwHLiO0IGP2aTLnDT7uwhSHw2thjs/72quxLV22mYLI5xBV2+f jLLeS2yTSNiHerVbW6bF0uC+Q8+NNVt4ytWS8aMa2RXT9ZGdSbf2lnqx8byoGCx4qCpX IAjQ== X-Received: by 10.58.186.241 with SMTP id fn17mr3062268vec.8.1360933102431; Fri, 15 Feb 2013 04:58:22 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.221.4.5 with SMTP id oa5csp11430vcb; Fri, 15 Feb 2013 04:58:21 -0800 (PST) X-Received: by 10.194.118.166 with SMTP id kn6mr4093362wjb.18.1360933101252; Fri, 15 Feb 2013 04:58:21 -0800 (PST) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by mx.google.com with ESMTPS id r6si19390059wja.213.2013.02.15.04.58.20 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Feb 2013 04:58:21 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.178 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=209.85.212.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.178 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) smtp.mail=lee.jones@linaro.org Received: by mail-wi0-f178.google.com with SMTP id o1so1114823wic.11 for ; Fri, 15 Feb 2013 04:58:20 -0800 (PST) X-Received: by 10.180.75.110 with SMTP id b14mr5803431wiw.21.1360933100743; Fri, 15 Feb 2013 04:58:20 -0800 (PST) Received: from localhost.localdomain (cpc34-aztw25-2-0-cust250.18-1.cable.virginmedia.com. [86.16.136.251]) by mx.google.com with ESMTPS id j4sm2852410wiz.10.2013.02.15.04.58.18 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Feb 2013 04:58:19 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com Cc: arnd@arndb.de, linus.walleij@stericsson.com, =?UTF-8?q?Mattias=20Thor=C3=A9n?= , Lee Jones Subject: [PATCH 30/35] mfd: ab8500-debugfs: Change AB8500 debug permissions Date: Fri, 15 Feb 2013 12:57:01 +0000 Message-Id: <1360933026-30325-31-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1360933026-30325-1-git-send-email-lee.jones@linaro.org> References: <1360933026-30325-1-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 X-Gm-Message-State: ALoCoQl1hmCddZhq4RCHJ8y1rr08laGlzszzsyrQLUPz9WiZciQebW6bK/aquKhSAgOm7KgAsCwh From: Mattias Thorén Enable group write permissions for ab8500 debug MFD driver. Signed-off-by: Lee Jones --- drivers/mfd/ab8500-debugfs.c | 56 +++++++++++++++++++++--------------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index ae8660a..148cbd2 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -2622,22 +2622,22 @@ static int ab8500_debug_probe(struct platform_device *plf) if (!file) goto err; - file = debugfs_create_file("register-bank", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("register-bank", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir, &plf->dev, &ab8500_bank_fops); if (!file) goto err; - file = debugfs_create_file("register-address", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("register-address", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir, &plf->dev, &ab8500_address_fops); if (!file) goto err; - file = debugfs_create_file("register-value", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("register-value", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir, &plf->dev, &ab8500_val_fops); if (!file) goto err; - file = debugfs_create_file("irq-subscribe", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("irq-subscribe", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir, &plf->dev, &ab8500_subscribe_fops); if (!file) goto err; @@ -2661,97 +2661,97 @@ static int ab8500_debug_probe(struct platform_device *plf) if (!file) goto err; - file = debugfs_create_file("irq-unsubscribe", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("irq-unsubscribe", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir, &plf->dev, &ab8500_unsubscribe_fops); if (!file) goto err; - file = debugfs_create_file("hwreg", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("hwreg", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir, &plf->dev, &ab8500_hwreg_fops); if (!file) goto err; - file = debugfs_create_file("all-modem-registers", (S_IRUGO | S_IWUGO), + file = debugfs_create_file("all-modem-registers", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir, &plf->dev, &ab8500_modem_fops); if (!file) goto err; - file = debugfs_create_file("bat_ctrl", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("bat_ctrl", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_bat_ctrl_fops); if (!file) goto err; - file = debugfs_create_file("btemp_ball", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("btemp_ball", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_btemp_ball_fops); if (!file) goto err; - file = debugfs_create_file("main_charger_v", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("main_charger_v", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_main_charger_v_fops); if (!file) goto err; - file = debugfs_create_file("acc_detect1", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("acc_detect1", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_acc_detect1_fops); if (!file) goto err; - file = debugfs_create_file("acc_detect2", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("acc_detect2", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_acc_detect2_fops); if (!file) goto err; - file = debugfs_create_file("adc_aux1", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("adc_aux1", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_aux1_fops); if (!file) goto err; - file = debugfs_create_file("adc_aux2", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("adc_aux2", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_aux2_fops); if (!file) goto err; - file = debugfs_create_file("main_bat_v", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("main_bat_v", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_main_bat_v_fops); if (!file) goto err; - file = debugfs_create_file("vbus_v", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("vbus_v", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_vbus_v_fops); if (!file) goto err; - file = debugfs_create_file("main_charger_c", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("main_charger_c", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_main_charger_c_fops); if (!file) goto err; - file = debugfs_create_file("usb_charger_c", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("usb_charger_c", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_usb_charger_c_fops); if (!file) goto err; - file = debugfs_create_file("bk_bat_v", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("bk_bat_v", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_bk_bat_v_fops); if (!file) goto err; - file = debugfs_create_file("die_temp", (S_IRUGO | S_IWUSR), + file = debugfs_create_file("die_temp", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_die_temp_fops); if (!file) goto err; - file = debugfs_create_file("usb_id", (S_IRUGO | S_IWUGO), + file = debugfs_create_file("usb_id", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_usb_id_fops); if (!file) goto err; if (is_ab8540(ab8500)) { - file = debugfs_create_file("xtal_temp", (S_IRUGO | S_IWUGO), + file = debugfs_create_file("xtal_temp", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8540_gpadc_xtal_temp_fops); if (!file) goto err; - file = debugfs_create_file("vbattruemeas", (S_IRUGO | S_IWUGO), + file = debugfs_create_file("vbattruemeas", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8540_gpadc_vbat_true_meas_fops); if (!file) @@ -2778,27 +2778,27 @@ static int ab8500_debug_probe(struct platform_device *plf) &plf->dev, &ab8540_gpadc_bat_temp_and_ibat_fops); if (!file) goto err; - file = debugfs_create_file("otp_calib", (S_IRUGO | S_IWUGO), + file = debugfs_create_file("otp_calib", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8540_gpadc_otp_calib_fops); if (!file) goto err; } - file = debugfs_create_file("avg_sample", (S_IRUGO | S_IWUGO), + file = debugfs_create_file("avg_sample", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_avg_sample_fops); if (!file) goto err; - file = debugfs_create_file("trig_edge", (S_IRUGO | S_IWUGO), + file = debugfs_create_file("trig_edge", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_trig_edge_fops); if (!file) goto err; - file = debugfs_create_file("trig_timer", (S_IRUGO | S_IWUGO), + file = debugfs_create_file("trig_timer", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_trig_timer_fops); if (!file) goto err; - file = debugfs_create_file("conv_type", (S_IRUGO | S_IWUGO), + file = debugfs_create_file("conv_type", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_gpadc_dir, &plf->dev, &ab8500_gpadc_conv_type_fops); if (!file) goto err;