From patchwork Fri Feb 15 12:45:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 14885 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id C231A4C17E5 for ; Fri, 15 Feb 2013 12:53:59 +0000 (UTC) Received: from mail-vb0-f49.google.com (mail-vb0-f49.google.com [209.85.212.49]) by fiordland.canonical.com (Postfix) with ESMTP id 5F5ECA1828F for ; Fri, 15 Feb 2013 12:53:59 +0000 (UTC) Received: by mail-vb0-f49.google.com with SMTP id s24so2109346vbi.36 for ; Fri, 15 Feb 2013 04:53:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=emaG1AjhcnuSj7zWEhvPPxPH5XCcMehXAcMFBBhJ+Tc=; b=jv/GcGQHBvM9Vy7BkdsLjr3VYaC4Di50g62WC7R4eziKJLd31szw8cFpIJHqGm2Uoh DxSDie9MfxQHinAzkAwXSVqZ0OmCBuuWuxWPVMjYc0jG/pF3Gl8mBSB6NHeehQbNNY9k vmmIE4fazGujez2dINqb95AdrJRnUmR9H5EC8HViVolQYV+TTrolBYAvtji7B4EExqUb X8UaNh/uaz48fF7yRS9jGBRC88HAdMJhPupLsqSvJquF6GVSeWAgpxXyhw4szLGX/eLG jus9crp59YQDSd3UxRxvlm3puCmSJukxs04sT4oPA1EqmFF10lJxzeuAAV5gGy39zl7X CzXA== X-Received: by 10.52.38.163 with SMTP id h3mr2659227vdk.35.1360932838878; Fri, 15 Feb 2013 04:53:58 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.221.4.5 with SMTP id oa5csp11221vcb; Fri, 15 Feb 2013 04:53:58 -0800 (PST) X-Received: by 10.180.108.3 with SMTP id hg3mr3777129wib.33.1360932419296; Fri, 15 Feb 2013 04:46:59 -0800 (PST) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by mx.google.com with ESMTPS id en18si1032180wid.108.2013.02.15.04.46.58 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Feb 2013 04:46:59 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.178 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=209.85.212.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.178 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) smtp.mail=lee.jones@linaro.org Received: by mail-wi0-f178.google.com with SMTP id o1so1097254wic.17 for ; Fri, 15 Feb 2013 04:46:58 -0800 (PST) X-Received: by 10.194.9.71 with SMTP id x7mr3859166wja.53.1360932418876; Fri, 15 Feb 2013 04:46:58 -0800 (PST) Received: from localhost.localdomain (cpc34-aztw25-2-0-cust250.18-1.cable.virginmedia.com. [86.16.136.251]) by mx.google.com with ESMTPS id bs6sm5133904wib.4.2013.02.15.04.46.56 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Feb 2013 04:46:58 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, linus.walleij@stericsson.com, cbouatmailru@gmail.com, sameo@linux.intel.com, Marcus Cooper , Lee Jones Subject: [PATCH 35/40] ab8500-bm: Trivially fix up some incorrect and out-of-date comments Date: Fri, 15 Feb 2013 12:45:05 +0000 Message-Id: <1360932310-30065-36-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1360932310-30065-1-git-send-email-lee.jones@linaro.org> References: <1360932310-30065-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQmwGo1ZGisyTEyavufVUhpNce4B/D/9lYwSUFS5KjXv3CJXhHDUuYO2kyy7Bhk/fJq66e81 From: Marcus Cooper Some of the comments in the ab8500 drivers reflect the behaviour of the original device. As this driver now supports newer devices then these comments are now redundant. Also some IRQ comments are incorrect. Signed-off-by: Marcus Cooper Signed-off-by: Lee Jones Reviewed-by: Rabin VINCENT Tested-by: Rabin VINCENT --- drivers/power/ab8500_btemp.c | 4 ++-- drivers/power/ab8500_fg.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/ab8500_btemp.c b/drivers/power/ab8500_btemp.c index 7336dcf..a9486f1 100644 --- a/drivers/power/ab8500_btemp.c +++ b/drivers/power/ab8500_btemp.c @@ -158,7 +158,7 @@ static int ab8500_btemp_batctrl_volt_to_res(struct ab8500_btemp *di, if (di->bm->adc_therm == ABx500_ADC_THERM_BATCTRL) { /* * If the battery has internal NTC, we use the current - * source to calculate the resistance, 7uA or 20uA + * source to calculate the resistance. */ rbs = (v_batctrl * 1000 - di->bm->gnd_lift_resistance * inst_curr) @@ -602,7 +602,7 @@ static int ab8500_btemp_id(struct ab8500_btemp *di) /* * We only have to change current source if the - * detected type is Type 1, else we use the 7uA source + * detected type is Type 1. */ if (di->bm->adc_therm == ABx500_ADC_THERM_BATCTRL && di->bm->batt_id == 1) { diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c index 54c6417..7de5333 100644 --- a/drivers/power/ab8500_fg.c +++ b/drivers/power/ab8500_fg.c @@ -1979,7 +1979,7 @@ static void ab8500_fg_instant_work(struct work_struct *work) } /** - * ab8500_fg_cc_data_end_handler() - isr to get battery avg current. + * ab8500_fg_cc_data_end_handler() - end of data conversion isr. * @irq: interrupt number * @_di: pointer to the ab8500_fg structure * @@ -1999,7 +1999,7 @@ static irqreturn_t ab8500_fg_cc_data_end_handler(int irq, void *_di) } /** - * ab8500_fg_cc_convend_handler() - isr to get battery avg current. + * ab8500_fg_cc_int_calib_handler () - end of calibration isr. * @irq: interrupt number * @_di: pointer to the ab8500_fg structure *