From patchwork Mon Jan 21 12:03:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 14163 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 8969123E33 for ; Mon, 21 Jan 2013 12:05:08 +0000 (UTC) Received: from mail-vb0-f47.google.com (mail-vb0-f47.google.com [209.85.212.47]) by fiordland.canonical.com (Postfix) with ESMTP id 199A5A18EB7 for ; Mon, 21 Jan 2013 12:05:08 +0000 (UTC) Received: by mail-vb0-f47.google.com with SMTP id e21so5535215vbm.6 for ; Mon, 21 Jan 2013 04:05:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=HtksIbEo4h1zfIYDZZ18jFJAugTNwRZUyiwjskQTgbI=; b=dlfcjVjFyJMM2sJrtuH2QcjOW+zyYJx0ptpjquPGOViR6TAIW8nLYZEujbIdJqbhU5 2E76OWyTIsLOf0YrZOw8fksLI4loj8KxZmzrg+JKiGqxR9J/+GqXLwkMlWBRMx3F1/FZ lCg2TWKpx4+6Wz033z3JnEHvoIVusxM1SQvpaRoNzfk/gckns7Qg16UkKRJQKggU+2Wb ST2CjMxyNJFoMwe6THYA2eQNEzgZ8/gBWoGTg4ydALKBkN1vOpEvKP0L0yDAAriyCgyZ 1y4J8bo/6dEMnfrf8Kp510W4B2HKyleb/uK50rBCRUqHeFOx4JV3cbDyjX193/rO3I/4 eBJQ== X-Received: by 10.52.16.6 with SMTP id b6mr13855311vdd.40.1358769907630; Mon, 21 Jan 2013 04:05:07 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.145.101 with SMTP id st5csp197742veb; Mon, 21 Jan 2013 04:05:06 -0800 (PST) X-Received: by 10.194.143.35 with SMTP id sb3mr25826856wjb.30.1358769894866; Mon, 21 Jan 2013 04:04:54 -0800 (PST) Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by mx.google.com with ESMTPS id h7si4795819wjx.132.2013.01.21.04.04.54 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Jan 2013 04:04:54 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.179 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=209.85.212.179; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.179 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) smtp.mail=lee.jones@linaro.org Received: by mail-wi0-f179.google.com with SMTP id o1so4851689wic.12 for ; Mon, 21 Jan 2013 04:04:54 -0800 (PST) X-Received: by 10.194.85.234 with SMTP id k10mr25763627wjz.53.1358769894359; Mon, 21 Jan 2013 04:04:54 -0800 (PST) Received: from localhost.localdomain (cpc34-aztw25-2-0-cust250.18-1.cable.virginmedia.com. [86.16.136.251]) by mx.google.com with ESMTPS id i2sm16575305wiw.3.2013.01.21.04.04.52 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Jan 2013 04:04:53 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, linus.walleij@stericsson.com, anton.vorontsov@linaro.org, cbou@mail.ru, Rajkumar Kasirajan , Lee Jones Subject: [PATCH 18/24] pm2301: Enable vbat low monitoring Date: Mon, 21 Jan 2013 12:03:54 +0000 Message-Id: <1358769840-4763-19-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1358769840-4763-1-git-send-email-lee.jones@linaro.org> References: <1358769840-4763-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQnKsPp60BXdb2x1Vnjh+DIN4AJSje+EOhwro3ETUhQk3LRPlzSldwbUdCUD15tkDJO2Q/pQ From: Rajkumar Kasirajan Enable support for low battery checking. Signed-off-by: Lee Jones Signed-off-by: Rajkumar Kasirajan Reviewed-by: Jonas ABERG Tested-by: Jonas ABERG --- drivers/power/pm2301_charger.c | 86 +++++++++++++++++++++------------------- 1 file changed, 45 insertions(+), 41 deletions(-) diff --git a/drivers/power/pm2301_charger.c b/drivers/power/pm2301_charger.c index 0e41168..c7d92b3 100644 --- a/drivers/power/pm2301_charger.c +++ b/drivers/power/pm2301_charger.c @@ -118,6 +118,8 @@ int pm2xxx_reg_read(struct pm2xxx_charger *pm2, int reg, u8 *val) 1, val); if (ret < 0) dev_err(pm2->dev, "Error reading register at 0x%x\n", reg); + else + ret = 0; return ret; } @@ -130,6 +132,8 @@ int pm2xxx_reg_write(struct pm2xxx_charger *pm2, int reg, u8 val) 1, &val); if (ret < 0) dev_err(pm2->dev, "Error writing register at 0x%x\n", reg); + else + ret = 0; return ret; } @@ -227,7 +231,7 @@ static int pm2xxx_charger_bat_disc_mngt(struct pm2xxx_charger *pm2, int val) static int pm2xxx_charger_detection(struct pm2xxx_charger *pm2, u8 *val) { - int ret = 0; + int ret; ret = pm2xxx_reg_read(pm2, PM2XXX_SRCE_REG_INT2, val); @@ -237,6 +241,7 @@ static int pm2xxx_charger_detection(struct pm2xxx_charger *pm2, u8 *val) } *val &= (PM2XXX_INT2_S_ITVPWR1PLUG | PM2XXX_INT2_S_ITVPWR2PLUG); + out: return ret; } @@ -628,7 +633,7 @@ static int pm2xxx_charging_init(struct pm2xxx_charger *pm2) /* Disable battery low monitoring */ ret = pm2xxx_reg_write(pm2, PM2XXX_BATT_LOW_LEV_COMP_REG, - PM2XXX_VBAT_LOW_MONITORING_DIS); + PM2XXX_VBAT_LOW_MONITORING_ENA); /* Disable LED */ ret = pm2xxx_reg_write(pm2, PM2XXX_LED_CTRL_REG, @@ -677,53 +682,51 @@ static int pm2xxx_charger_ac_en(struct ux500_charger *charger, } ret = pm2xxx_reg_read(pm2, PM2XXX_BATT_CTRL_REG8, &val); - if (ret >= 0) { - val &= ~PM2XXX_CH_VOLT_MASK; - val |= volt_index; - ret = pm2xxx_reg_write(pm2, PM2XXX_BATT_CTRL_REG8, val); - - if (ret < 0) { - dev_err(pm2->dev, - "%s write failed\n", __func__); - goto error_occured; - } - else - dev_err(pm2->dev, "%s read failed\n", __func__); + if (ret < 0) { + dev_err(pm2->dev, "%s pm2xxx read failed\n", __func__); + goto error_occured; + } + val &= ~PM2XXX_CH_VOLT_MASK; + val |= volt_index; + ret = pm2xxx_reg_write(pm2, PM2XXX_BATT_CTRL_REG8, val); + if (ret < 0) { + dev_err(pm2->dev, "%s pm2xxx write failed\n", __func__); + goto error_occured; } ret = pm2xxx_reg_read(pm2, PM2XXX_BATT_CTRL_REG6, &val); - if (ret >= 0) { - val &= ~PM2XXX_DIR_CH_CC_CURRENT_MASK; - val |= curr_index; - ret = pm2xxx_reg_write(pm2, PM2XXX_BATT_CTRL_REG6, val); - if (ret < 0) { - dev_err(pm2->dev, - "%s write failed\n", __func__); - goto error_occured; - } - else - dev_err(pm2->dev, "%s read failed\n", __func__); + if (ret < 0) { + dev_err(pm2->dev, "%s pm2xxx read failed\n", __func__); + goto error_occured; + } + val &= ~PM2XXX_DIR_CH_CC_CURRENT_MASK; + val |= curr_index; + ret = pm2xxx_reg_write(pm2, PM2XXX_BATT_CTRL_REG6, val); + if (ret < 0) { + dev_err(pm2->dev, "%s pm2xxx write failed\n", __func__); + goto error_occured; } if (!pm2->bat->enable_overshoot) { ret = pm2xxx_reg_read(pm2, PM2XXX_LED_CTRL_REG, &val); - if (ret >= 0) { - val |= PM2XXX_ANTI_OVERSHOOT_EN; - ret = pm2xxx_reg_write(pm2, PM2XXX_LED_CTRL_REG, - val); - if (ret < 0){ - dev_err(pm2->dev, "%s write failed\n", - __func__); - goto error_occured; - } + if (ret < 0) { + dev_err(pm2->dev, "%s pm2xxx read failed\n", + __func__); + goto error_occured; + } + val |= PM2XXX_ANTI_OVERSHOOT_EN; + ret = pm2xxx_reg_write(pm2, PM2XXX_LED_CTRL_REG, val); + if (ret < 0) { + dev_err(pm2->dev, "%s pm2xxx write failed\n", + __func__); + goto error_occured; } - else - dev_err(pm2->dev, "%s read failed\n", __func__); } ret = pm2xxx_charging_enable_mngt(pm2); - if (ret) { - dev_err(pm2->dev, "%s write failed\n", __func__); + if (ret < 0) { + dev_err(pm2->dev, "Failed to enable" + "pm2xxx ac charger\n"); goto error_occured; } @@ -739,9 +742,10 @@ static int pm2xxx_charger_ac_en(struct ux500_charger *charger, } ret = pm2xxx_charging_disable_mngt(pm2); - if (ret) { - dev_err(pm2->dev, "%s write failed\n", __func__); - return ret; + if (ret < 0) { + dev_err(pm2->dev, "failed to disable" + "pm2xxx ac charger\n"); + goto error_occured; } dev_dbg(pm2->dev, "PM2301: " "Disabled AC charging\n");