From patchwork Tue Oct 9 20:13:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12083 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 35CA723F6D for ; Tue, 9 Oct 2012 20:14:15 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id D485FA18D88 for ; Tue, 9 Oct 2012 20:14:14 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so12072696iej.11 for ; Tue, 09 Oct 2012 13:14:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-provags-id:x-gm-message-state; bh=2zK2SfU5ZUEFN1n5J58S0RSYPR1I7r7a98XLKQSv66Y=; b=nYghz71UNUCy3ei1CVlBbFmGQkqkKv+KeONQEGyOI8hvY58k/1FZptn6YYhgY0p3Ub chigyDNwxvz8NglLo/H43COO+rZgrULGmu6WQzQGy8BvDix9J6J9MyBCo7lY/cAWh9Nc 9efdoqL1V3ITS7x+bBUd87+T3gfBD5erh9T8V23IqOyamy5QAe+/6wyAGkl+gUBZXBsu jYZRuSAEBr4fFZRSssF/P2KRa/XO5pRkwCfB0KJXK1qPThAe1VfCEnZtH5IkxwaHmL2K O3Xnw60m9q2NukiHWO1R0A5z1f4HRw7bbthJi1cFuCWl/Bqsh+6S0mwtOheCf+0r1vcF 1D2w== Received: by 10.43.7.132 with SMTP id oo4mr16673795icb.6.1349813654614; Tue, 09 Oct 2012 13:14:14 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp113890igt; Tue, 9 Oct 2012 13:14:13 -0700 (PDT) Received: by 10.204.148.21 with SMTP id n21mr7322277bkv.124.1349813653168; Tue, 09 Oct 2012 13:14:13 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de. [212.227.126.187]) by mx.google.com with ESMTPS id b10si40117616bka.27.2012.10.09.13.14.12 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 09 Oct 2012 13:14:13 -0700 (PDT) Received-SPF: neutral (google.com: 212.227.126.187 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.126.187; Authentication-Results: mx.google.com; spf=neutral (google.com: 212.227.126.187 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mail=arnd@arndb.de Received: from klappe2.lan (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis) id 0LiJxI-1TvqLq14Ie-00ceTs; Tue, 09 Oct 2012 22:14:06 +0200 From: Arnd Bergmann To: arm@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Wan ZongShun , Florian Tobias Schandinat , linux-fbdev@vger.kernel.org Subject: [PATCH v2 7/8] video: mark nuc900fb_map_video_memory as __devinit Date: Tue, 9 Oct 2012 22:13:57 +0200 Message-Id: <1349813638-4617-8-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1349813638-4617-1-git-send-email-arnd@arndb.de> References: <1349813638-4617-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:qBSgkGYFMYa4dOCRVCzrF6MsyECZcuEcVvfF7NJVVLk 5x1HyT4Hk3+Sfg8rC16qF9zPDULqK267ZDRGgJ/xtdT5JTWdnw w5NsArf/pu6NABsXK558qI8js3LRNrHaGgKkV6yhCC5yEXSU1e bZk08admbd4o6jq80/T6pVv1rlQoG6Mc4gH223eeFh65iGSt0H xh0bi2Pq4tQw5Xmkh4v+Uo5vweh94hjig5zKTIjGpLEUO6We1N t4JcMu1lx4QhH8lQOaD+ypethPt1fNEjOKp5jljKNskSjDUJTM VBRYiyxINrjauSMlWMk/UUI+16Q/IuXRMjjI3AoYwQ8FD8K6Qb laezmARzsH+IvE3zc2zazPuJClfJjTpI0xngAEOu8 X-Gm-Message-State: ALoCoQkcc0nGOGkwdrmZI5JFSAXczudITAZSL8cuI3/DsXDNhwE521HWeoz1dDbDmcbLE9LO/PMG nuc900fb_map_video_memory is called by an devinit function that may be called at run-time, but the function itself is marked __init and will be discarded after boot. To avoid calling into a function that may have been overwritten, mark nuc900fb_map_video_memory itself as __devinit. Without this patch, building nuc950_defconfig results in: WARNING: drivers/video/built-in.o(.devinit.text+0x26c): Section mismatch in reference from the function nuc900fb_probe() to the function .init.text:nuc900fb_map_video_memory() The function __devinit nuc900fb_probe() references a function __init nuc900fb_map_video_memory(). If nuc900fb_map_video_memory is only used by nuc900fb_probe then annotate nuc900fb_map_video_memory with a matching annotation. Signed-off-by: Arnd Bergmann Cc: Wan ZongShun Cc: Florian Tobias Schandinat Cc: linux-fbdev@vger.kernel.org --- drivers/video/nuc900fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c index e10f551..b31b12b 100644 --- a/drivers/video/nuc900fb.c +++ b/drivers/video/nuc900fb.c @@ -387,7 +387,7 @@ static int nuc900fb_init_registers(struct fb_info *info) * The buffer should be a non-cached, non-buffered, memory region * to allow palette and pixel writes without flushing the cache. */ -static int __init nuc900fb_map_video_memory(struct fb_info *info) +static int __devinit nuc900fb_map_video_memory(struct fb_info *info) { struct nuc900fb_info *fbi = info->par; dma_addr_t map_dma;