From patchwork Fri Oct 5 14:55:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12018 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 5B5AA23EF8 for ; Fri, 5 Oct 2012 14:56:18 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id EA04CA190DA for ; Fri, 5 Oct 2012 14:56:17 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so3893275iej.11 for ; Fri, 05 Oct 2012 07:56:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-provags-id:x-gm-message-state; bh=ZbfJxfO0DsE9dYrZ2KbkkDAs0dRWkRZEKIZyKHfnSdQ=; b=aScKBJ/C9LvSztIa90TsWLgQ9ifFqtCAF+jSpGUvU7ziEA/8xcrKLzyGuImQCOHNuz F3OKNhghjiK/k+FY8sYi0svoTYB/zPy5Z+A6kpwaCJwRWCZDpt8HM2tI88WeOHeHmtKo 449lVwlMpogCloIcTKKv4yKT1Yfmabdoe2qEboI2anUJqIuPMHFzzIks3mBl+jIR09r5 RZ9k9bdALHXxxak6LRXqcZH0jkPNhblnqs0Q98LnC0tUr3sn5J7pPgML+XjFPIyPKc7l KCE5CVGXCp3O9o0DKni7Ibt1/BRS6LVtmlFLsDMgEXly3PZoBjizSu6Q28mho6j4YmNo +ZOg== Received: by 10.50.194.136 with SMTP id hw8mr1400257igc.28.1349448977711; Fri, 05 Oct 2012 07:56:17 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp130658igc; Fri, 5 Oct 2012 07:56:16 -0700 (PDT) Received: by 10.180.73.76 with SMTP id j12mr3937109wiv.11.1349448976178; Fri, 05 Oct 2012 07:56:16 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de. [212.227.17.9]) by mx.google.com with ESMTPS id h2si2909843wie.42.2012.10.05.07.56.15 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 05 Oct 2012 07:56:16 -0700 (PDT) Received-SPF: neutral (google.com: 212.227.17.9 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.17.9; Authentication-Results: mx.google.com; spf=neutral (google.com: 212.227.17.9 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mail=arnd@arndb.de Received: from klappe2.boeblingen.de.ibm.com (deibp9eh1--blueice3n2.emea.ibm.com [195.212.29.180]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0Lvupd-1TU4Pk0GmT-017ofB; Fri, 05 Oct 2012 16:55:45 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, arm@kernel.org, Arnd Bergmann , Greg Ungerer , Russell King Subject: [PATCH 01/16] ARM: warnings in arch/arm/include/asm/uaccess.h Date: Fri, 5 Oct 2012 16:55:15 +0200 Message-Id: <1349448930-23976-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1349448930-23976-1-git-send-email-arnd@arndb.de> References: <1349448930-23976-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:xgkwAi3VsWjkrY6vAMpyEM/iPJLqKEnxkhRRMvqoE4s NPBTd36ONPjlG5lLcL/SACiC35fjBoBZLkmKwqYo3pfxUXH9XU AUtFMJDEprR45BPNAzyaK2BpgEVjknMF+C2fq6+xNytCh6xE6A TK44TZPOarF1rLRSsBhvbdx3Z1xZHnOPSKLSPeljI2V+WcVWMV Wncm7Z9LHtdn4rqTLuCX9yvs2h8DzvBTVyCWxArVyouJWx8Q+o vqAXoQl84idUsMBltDnrGDZDB9sTF2kr1L624WGJ0vUPgC4qJz P7ZAvwzQ8EdMEknIsRqh48SJbnRtPCJdGd19tcW9ReYrmlsJVc q9UA7KCxa4iduqIm/uixDYkDKV8pdVUpo5f3Ii9gcvKgVWkmJ4 25Z9v1F2c0dZxhiFWIxHJvYCzdE+VOxdTg= X-Gm-Message-State: ALoCoQkcWXpFCx4lOQ9zdIlI+ZRENaS6FPFtgKSub7zp5m91eCePLTbBHdLM2dgr9Hy7Qfrkdqpg On NOMMU ARM, the __addr_ok() and __range_ok() macros do not evaluate their arguments, which may lead to harmless build warnings in some code where the variables are not used otherwise. Adding a cast to void gets rid of the warning and does not make any semantic changes. Without this patch, building at91x40_defconfig results in: fs/read_write.c: In function 'rw_copy_check_uvector': fs/read_write.c:684:9: warning: unused variable 'buf' [-Wunused-variable] Signed-off-by: Arnd Bergmann Cc: Greg Ungerer Cc: Russell King --- arch/arm/include/asm/uaccess.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h index 77bd79f..7e1f760 100644 --- a/arch/arm/include/asm/uaccess.h +++ b/arch/arm/include/asm/uaccess.h @@ -200,8 +200,8 @@ extern int __put_user_8(void *, unsigned long long); #define USER_DS KERNEL_DS #define segment_eq(a,b) (1) -#define __addr_ok(addr) (1) -#define __range_ok(addr,size) (0) +#define __addr_ok(addr) ((void)(addr),1) +#define __range_ok(addr,size) ((void)(addr),0) #define get_fs() (KERNEL_DS) static inline void set_fs(mm_segment_t fs)