From patchwork Fri Oct 5 14:55:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12004 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id AC2C123E57 for ; Fri, 5 Oct 2012 14:55:54 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 1305FA190F1 for ; Fri, 5 Oct 2012 14:55:53 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so3893159iej.11 for ; Fri, 05 Oct 2012 07:55:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-provags-id:x-gm-message-state; bh=2zK2SfU5ZUEFN1n5J58S0RSYPR1I7r7a98XLKQSv66Y=; b=lXYe5XEYtN7RP8JuWgK/Eh87qEcvnV1tSuvxh7ksAlU85n2jkVnhNEWaJEmZ5nK6Tz U7rj7e+2nDBaP5uNL7qJ8TcreQ2tcUPWrNvWi13LEAVtHjCbJaroZkZL4wk4EUyLg6JK +7aGpfEsucquPrP5mGXVbWI3GULOsIQq5GfRNVMu0VQteisvZLkc7ihKstGAv7tJ6l+0 DvyFBk9fdGsbi7C6LbEzRox8YtDxNW9MymKza5FMxGBhBRTWzFkronAMmn7af87izUCJ apXIVzh82RLtEcQsnn021/evx/9HqmwAw0MAFQORC+RGVkorxMdsCKUShYjcCoDiCbED tH3A== Received: by 10.42.109.194 with SMTP id m2mr7116285icp.48.1349448953323; Fri, 05 Oct 2012 07:55:53 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp130596igc; Fri, 5 Oct 2012 07:55:52 -0700 (PDT) Received: by 10.217.2.146 with SMTP id p18mr5558402wes.198.1349448951112; Fri, 05 Oct 2012 07:55:51 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de. [212.227.17.8]) by mx.google.com with ESMTPS id q7si12049222wea.154.2012.10.05.07.55.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 05 Oct 2012 07:55:51 -0700 (PDT) Received-SPF: neutral (google.com: 212.227.17.8 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.17.8; Authentication-Results: mx.google.com; spf=neutral (google.com: 212.227.17.8 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mail=arnd@arndb.de Received: from klappe2.boeblingen.de.ibm.com (deibp9eh1--blueice3n2.emea.ibm.com [195.212.29.180]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0LlLtL-1Trphq3mWV-00bIFX; Fri, 05 Oct 2012 16:55:50 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, arm@kernel.org, Arnd Bergmann , Wan ZongShun , Florian Tobias Schandinat , linux-fbdev@vger.kernel.org Subject: [PATCH 12/16] video: mark nuc900fb_map_video_memory as __devinit Date: Fri, 5 Oct 2012 16:55:26 +0200 Message-Id: <1349448930-23976-13-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1349448930-23976-1-git-send-email-arnd@arndb.de> References: <1349448930-23976-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:cc/kpoClP7aUEJhGBNliu/t6XaDfDcP4w0yU2Joapd8 ZaV78CVCDCUhGaLk7tEaY90ebsVpm210oqbJiOkPvwpPe/gAxO hUcoyTma/rFmssnj5Q92aPhUFCJCfF7ohElnyUGSXkPtoOEwUL tLZquttmZEzlDamSnKNbCX2jESpmqSN+mezmeRuCM+l26vTG+H iwTECJUSal75UbucKeqlKPmkPJkkfukoABZX7lcyv2ZklJ59Mw 2TbL/wf0gjEqkP18YRplWNsGzVlz8APEEOrOApvm0XIAvYSkG9 QQ9DANESR/Yy9rJRhW3LjXZllav4DblsXlyg80MNzU3+xz49GJ SPVgoY2BIZMhz6ENeYNATQ7+EwT9D+2USJukRrMcxLnAPHAKCm H5BdGCfxfwpk6GLTSoIsmV/Mr6mxNuCl1g= X-Gm-Message-State: ALoCoQkP9BOH6IVOzzt821inhdm2d89+aqQnYODlZGgSre5+6D/5RUBZsh9CrN4gK/QxFkJZLozP nuc900fb_map_video_memory is called by an devinit function that may be called at run-time, but the function itself is marked __init and will be discarded after boot. To avoid calling into a function that may have been overwritten, mark nuc900fb_map_video_memory itself as __devinit. Without this patch, building nuc950_defconfig results in: WARNING: drivers/video/built-in.o(.devinit.text+0x26c): Section mismatch in reference from the function nuc900fb_probe() to the function .init.text:nuc900fb_map_video_memory() The function __devinit nuc900fb_probe() references a function __init nuc900fb_map_video_memory(). If nuc900fb_map_video_memory is only used by nuc900fb_probe then annotate nuc900fb_map_video_memory with a matching annotation. Signed-off-by: Arnd Bergmann Cc: Wan ZongShun Cc: Florian Tobias Schandinat Cc: linux-fbdev@vger.kernel.org --- drivers/video/nuc900fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c index e10f551..b31b12b 100644 --- a/drivers/video/nuc900fb.c +++ b/drivers/video/nuc900fb.c @@ -387,7 +387,7 @@ static int nuc900fb_init_registers(struct fb_info *info) * The buffer should be a non-cached, non-buffered, memory region * to allow palette and pixel writes without flushing the cache. */ -static int __init nuc900fb_map_video_memory(struct fb_info *info) +static int __devinit nuc900fb_map_video_memory(struct fb_info *info) { struct nuc900fb_info *fbi = info->par; dma_addr_t map_dma;