From patchwork Thu Jan 12 11:14:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 91122 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1567162qgi; Thu, 12 Jan 2017 03:15:31 -0800 (PST) X-Received: by 10.99.158.18 with SMTP id s18mr16781055pgd.88.1484219731657; Thu, 12 Jan 2017 03:15:31 -0800 (PST) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id 7si8967408pll.247.2017.01.12.03.15.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jan 2017 03:15:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cRdLu-0001gr-7T; Thu, 12 Jan 2017 11:15:30 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cRdLk-0000DK-8t for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2017 11:15:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6583FAD7; Thu, 12 Jan 2017 03:14:59 -0800 (PST) Received: from [10.1.210.28] (unknown [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3EED13F24D; Thu, 12 Jan 2017 03:14:58 -0800 (PST) Subject: Re: [PATCH v2 2/2] arm64: dts: juno: Adds missing CoreSight STM component. To: Mike Leach , liviu.dudau@arm.com, lorenzo.pieralisi@arm.com References: <1484167449-14432-1-git-send-email-mike.leach@linaro.org> <1484167449-14432-3-git-send-email-mike.leach@linaro.org> From: Sudeep Holla Organization: ARM Message-ID: <0120ef9b-2e01-e00a-2de8-c540ab70af85@arm.com> Date: Thu, 12 Jan 2017 11:14:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1484167449-14432-3-git-send-email-mike.leach@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170112_031520_373644_8B3EE717 X-CRM114-Status: GOOD ( 10.29 ) X-Spam-Score: -10.1 (----------) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-10.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [217.140.101.70 listed in list.dnswl.org] -3.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org On 11/01/17 20:44, Mike Leach wrote: > Add missing CoreSight STM component definition to Juno CoreSight > infrastructure juno-cs-rX.dtsi files. > > Component connected to different funnels depending on Juno platform variant. > > Signed-off-by: Mike Leach > --- > arch/arm64/boot/dts/arm/juno-cs-r0.dtsi | 16 ++++++++++++++++ > arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 16 ++++++++++++++++ > 2 files changed, 32 insertions(+) > Can we avoid duplication with something like below ? I don't have strong opinion but I just saw the opportunity. I can squash it in if you agree(no need to repost). Regards, Sudeep -->8 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi index 7c89000f954d..15fcd09d9d84 100644 --- a/arch/arm64/boot/dts/arm/juno-base.dtsi +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi @@ -83,6 +83,21 @@ * The actual size is just 4K though 64K is reserved. Access to the * unmapped reserved region results in a DECERR response. */ + stm@20100000 { + compatible = "arm,coresight-stm", "arm,primecell"; + reg = <0 0x20100000 0 0x1000>, + <0 0x28000000 0 0x180000>; + reg-names = "stm-base", "stm-stimulus-base"; + + clocks = <&soc_smc50mhz>; + clock-names = "apb_pclk"; + power-domains = <&scpi_devpd 0>; + port { + stm_out_port: endpoint { + }; + }; + }; + etm0: etm@22040000 { compatible = "arm,coresight-etm4x", "arm,primecell"; reg = <0 0x22040000 0 0x1000>; diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts index 881339536e90..1c16a96ff677 100644 --- a/arch/arm64/boot/dts/arm/juno-r1.dts +++ b/arch/arm64/boot/dts/arm/juno-r1.dts @@ -228,3 +228,7 @@ &gpu1_thermal_zone { status = "okay"; }; + +&stm_out_port { + remote-endpoint = <&csys1_funnel_in_port0>; +}; diff --git a/arch/arm64/boot/dts/arm/juno-r2.dts b/arch/arm64/boot/dts/arm/juno-r2.dts index fca3a1705114..69890cc1edae 100644 --- a/arch/arm64/boot/dts/arm/juno-r2.dts +++ b/arch/arm64/boot/dts/arm/juno-r2.dts @@ -228,3 +228,7 @@ &gpu1_thermal_zone { status = "okay"; }; + +&stm_out_port { + remote-endpoint = <&csys1_funnel_in_port0>; +}; diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts index c90c37b66db5..ad270e090ba4 100644 --- a/arch/arm64/boot/dts/arm/juno.dts +++ b/arch/arm64/boot/dts/arm/juno.dts @@ -204,3 +204,7 @@ &etm5 { cpu = <&A53_3>; }; + +&stm_out_port { + remote-endpoint = <&main_funnel_in_port2>; +};