From patchwork Mon May 29 06:24:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 688350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BCEC77B7A for ; Mon, 29 May 2023 06:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231556AbjE2GZU (ORCPT ); Mon, 29 May 2023 02:25:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbjE2GZR (ORCPT ); Mon, 29 May 2023 02:25:17 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F1F11B6; Sun, 28 May 2023 23:24:44 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2af20198f20so29804651fa.0; Sun, 28 May 2023 23:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685341475; x=1687933475; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OZRQfz643dmJHeeo+jkhXyvA3F1dCaDB2UQgCJF1mJ8=; b=Vv79P5w9D8h+XFDM95DLNQIVFZ5ylVvfzphxGNnUlDerYoJDaJkY43xI3mAuUfZm0z C4fob+gOq8w3UMfh0SSQGKfk9tcsd9Nk/OcAaL2OXUJNrFrebQM6K/eZWFdiBNwewpMR ovK7SpJ8g7eS+u0DK1IbINs6g9baH4okHVEj/GiQforgbnEHTgIE12hpV6YazIkqllSY LN/xGaiY7b4Cb9RDIHHhQvA2vOKR6tslRfXB3vrOwvH/5FBRTamlbXDwtkHwLP8ou34u SLC6CErI3ZG4MJp2VmVs5FKOOe3lIV+ztG5v6vJvTEU5wq/IXgWRfOm9ngHFexvhvY6L wIkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685341475; x=1687933475; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OZRQfz643dmJHeeo+jkhXyvA3F1dCaDB2UQgCJF1mJ8=; b=erMNR6RsSMn6Ry8blTEAuiUoXjJbiJSLpPJ6sW7QkDNGSHI5xpc4fXkTswcN40Iqgv Utn8Txt8t+EQoOfVZ3YgNOiO+qxTt9W9ApETWasTgIBlGLTlFfmpDbOjI1Tc5+XVskUV QDksmm5isMDUtd+O0ZujEQRQdGlsjwmkiQrpy3t5G8dJC+UBgEesKwaEx4lHmK40D6lC B70tKQ/Vhji7buvS/bW7Gll1jtSiLWJmXwTTE+QkYPAmvabotALGMOOBRDVu/3g7O8M0 jbM2QCSO9Vp9kpcaEevYCQapIzkMzpZrNKLLiUuGxktHuYG+yLDob+IFo8+d0Uhy4VWt a7IA== X-Gm-Message-State: AC+VfDzvpSX97rz8ISpSiozLQbTXkNs+43GZhgcTD/a4tOK75SPQfo1H Mc2gBmyvA9r+vKt4ipbKnXs= X-Google-Smtp-Source: ACHHUZ7FtmSMOib8Ov0ArZ3oVpwS2pIyq4LIkauz+GxfTaYPkIg0JToW3ToziUlQWKilosw5qbF0cA== X-Received: by 2002:a2e:3e0e:0:b0:2ac:82c1:5a3d with SMTP id l14-20020a2e3e0e000000b002ac82c15a3dmr3693931lja.23.1685341475524; Sun, 28 May 2023 23:24:35 -0700 (PDT) Received: from fedora (62-78-225-252.bb.dnainternet.fi. [62.78.225.252]) by smtp.gmail.com with ESMTPSA id s10-20020a2e98ca000000b002aa4713b925sm2305506ljj.21.2023.05.28.23.24.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 May 2023 23:24:34 -0700 (PDT) Date: Mon, 29 May 2023 09:24:30 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?iso-8859-1?q?Neusch=E4fer?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v7 8/9] net-next: mvpp2: relax return value check for IRQ get Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org fwnode_irq_get[_byname]() were changed to not return 0 anymore. Drop check for return value 0. Signed-off-by: Matti Vaittinen --- Revision history: v5 =>: - No changes v4 = v5: Fix the subject, mb1232 => mvpp2 The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone. --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index adc953611913..5b987af306a5 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -5833,7 +5833,7 @@ static int mvpp2_multi_queue_vectors_init(struct mvpp2_port *port, v->irq = of_irq_get_byname(port_node, irqname); else v->irq = fwnode_irq_get(port->fwnode, i); - if (v->irq <= 0) { + if (v->irq < 0) { ret = -EINVAL; goto err; } @@ -6764,7 +6764,7 @@ static int mvpp2_port_probe(struct platform_device *pdev, err = -EPROBE_DEFER; goto err_deinit_qvecs; } - if (port->port_irq <= 0) + if (port->port_irq < 0) /* the link irq is optional */ port->port_irq = 0;