From patchwork Fri May 26 06:38:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 686504 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D5BC7EE23 for ; Fri, 26 May 2023 06:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242242AbjEZGjN (ORCPT ); Fri, 26 May 2023 02:39:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242258AbjEZGjJ (ORCPT ); Fri, 26 May 2023 02:39:09 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7418E12F; Thu, 25 May 2023 23:39:04 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4f4db9987f8so1285550e87.1; Thu, 25 May 2023 23:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685083143; x=1687675143; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ekbpAMbogTlMCWxkxFZ/eQBJQS9KZeZKKkgzxsIBTZY=; b=swo3Sx3G1UOBDNaL7TLrRZ5pQB/6afRbf8eQBpp9b1OaBl7qkV9Yxk0SqRq0yePA18 ZKv1bPnEl7wMGTPLzvoaZtjDHe8nkwbU5pybFPwKDNauvtpgVcg/O+tw5mTdjHSjStBG yyP3YnlUR51SJ2O95YR7Sp3Ji9z1kAInjJVXtbFGs5Adtb48Zyh7ttRnntgEvp+hF88q v2G+jHWagwpjRk3ZrlNpgM08lGmFRHBp5VCx/SEBP+MX32Hxmjg133eGpcr5PaK5BKel L88+H53RnL1ZExbKN0NwzYroA481IHdtNGLAfDr9xx1sTeo4kYglbNM3i6Jj3uVmhfjz 5p7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685083143; x=1687675143; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ekbpAMbogTlMCWxkxFZ/eQBJQS9KZeZKKkgzxsIBTZY=; b=FB6TpBrt4hbM+ybDODTgSU4zJRIK5Jwn8LkOHknM5L3sEqnFEImuvHY8jMFOHkepxp Pg4cJrV6gcZtxRzvyDstQj/W3XumAe/ayhxIFYGeR2mnyW8Ey522nG3/VfWPyfbjmPf+ AAErGi55HjeqLg+/db5w7OLuVABYxrqZBV177gK+kufFq+HTGk7bQ/AfGrvoXdx7uZIQ 5Qumy1dzXUOSNyM85QgUsgR/DJcEDr1ygaydt+8Xyldy4JK+PUMzesDDoV2vnXNtfZoK CJKaLdMkiTlVxZwDpZp+H5Cfvg4Vge0CwHx+fIsr7KCCL0mnCzqpjQu4qf38WBYAEV/I PMRg== X-Gm-Message-State: AC+VfDxI3tvNR+SNr7/JU7F+CbJN08cz1WbikS/kevx+7W9CEYj1QRRY iAyC8dd9hO9XFaXB/Dqo1s8= X-Google-Smtp-Source: ACHHUZ7knF9sTUOLQBiCcAr+wHS3578rbREvAyWpopCpkBaInOiXDERlRe36k4kgZYkg7rsGnuWrZQ== X-Received: by 2002:a05:6512:3d90:b0:4f3:a55c:ebdc with SMTP id k16-20020a0565123d9000b004f3a55cebdcmr1440553lfv.17.1685083142646; Thu, 25 May 2023 23:39:02 -0700 (PDT) Received: from fedora ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id p11-20020a05651211eb00b004f13ca69dc8sm486674lfs.72.2023.05.25.23.39.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 23:39:01 -0700 (PDT) Date: Fri, 26 May 2023 09:38:58 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?iso-8859-1?q?Neusch=E4fer?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v6 6/8] pinctrl: pistachio: relax return value check for IRQ get Message-ID: <9db9653eb33d345d305e918215216348a8f193da.1685082026.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org fwnode_irq_get[_byname]() were changed to not return 0 anymore. Drop check for return value 0. Signed-off-by: Matti Vaittinen Acked-by: Linus Walleij Reviewed-by: Jonathan Cameron --- Revision history: - No changes Please note, I took Linus' reply to v4 cover-letter as ack && added the tag. Please let me know if this was not Ok. The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone. --- drivers/pinctrl/pinctrl-pistachio.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c index 53408344927a..8c50e0091b32 100644 --- a/drivers/pinctrl/pinctrl-pistachio.c +++ b/drivers/pinctrl/pinctrl-pistachio.c @@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i); goto err; } - if (!ret) { - fwnode_handle_put(child); - dev_err(pctl->dev, "No IRQ for bank %u\n", i); - ret = -EINVAL; - goto err; - } irq = ret; bank = &pctl->gpio_banks[i];