From patchwork Mon Dec 16 20:11:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 851477 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 309611CF5EC for ; Mon, 16 Dec 2024 20:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379921; cv=none; b=dgSwBJXZCHBusH8/OpVB3azxvZHfBHkygHF4Ae7++5QivzJ3qggSsupHZ/wO7iNKC+tHg1opdC75awC1xPqg7TotNOcu5L4hgo6x63ymyy0uSEmEhQmfZyjuwtAbMcLX7XyUe/7aGbq3AdJO+erU4yLzGtRTQMika6X1XGqRNO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379921; c=relaxed/simple; bh=7jxU4hpAwSWmevfX99YkDoTD1JGxKAVZgzPD8jgn35M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XCHt8Jbl8phvdbYMLVkf9iWvFQCbrS8rWe7Sbm4b2kjYQsY+nLaqPHgBvQXAWs7VdfNfIqzqL+ieSkRrmA/hWGS5BVJo1n3wfNZd/xP4e0u5jrmWE/1wouY84613e4P+EQobyUWub5kWq3PfoUnP/HffBxq1thEVUWKwxNpvLro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CNdanyNU; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CNdanyNU" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-725dc290c00so4308816b3a.0 for ; Mon, 16 Dec 2024 12:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734379919; x=1734984719; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rqa++bQfJwX3ua/s3cRo3Ckug/2w2jf2s5usPRs7cJ8=; b=CNdanyNUq4OPpiruLbQnSyqtd0ycqSKEQxMIWRqYCAScBtfZEnK6Tjy9U3l7hErlNH tIgU500AGccqO4DY3FmhY6Tvk9j6RTNs9C+AJE/ufTzIjYMCqvZ0HzdpaojP2FrhRImq 4ZJu5yKy6pyFMHRA//y+PJflXxBL4BCEaczSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379919; x=1734984719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rqa++bQfJwX3ua/s3cRo3Ckug/2w2jf2s5usPRs7cJ8=; b=oq3HHcVc0X5f7wY5Pbc0scBXABRb0xrWVjuZPWufLJNoZIcTaBHndKgDYCyI2TWPCs 231gMsx+DnT7MHOvB/JgOt/kTU+8e7MHYyoXmmRbCCWE6UKn7HCkOCiZLoIudNFfKawj b1p4j49BcyRE4zkaoyPe+Lqu5rEuU9GoCfcDdAFLj+PhN0hYehyDbftsMiRLuPvza/SD pgiTRoHkD9vkwygkBZJbHbR9Qgt+vaRkB0ocd4O2rKHdROqNnjYhFyNGnNLTi2KYMozw 1tJvSEVaRhT7nzASs4G8Ucyk9YAN1dYdxTLN8WfqdRvfJXl+oJY670auf50m2wv7SL1W e4gg== X-Forwarded-Encrypted: i=1; AJvYcCVTtGBnfJjmC2K7Oj04px7mmDDfFfLY4oDfHMdA7c/0f517cZsTcg/N43j8xk734YGvVIA3fJNaDwh1@vger.kernel.org X-Gm-Message-State: AOJu0YwyAy8IAWM/V8wv5liUH/4XQH8eMgOcvge/UxkcVEOVECjJVqX3 icChxfRxr7wXPf83An+lg4ayxY4HLmuQHdqJwqA667eCeqjNXMNP9tYUNdAfaA== X-Gm-Gg: ASbGnctQ8aiBKy9sfWWkvbbmLnyYXAgsyp/z4YMPfKoJ+sQhDL7viSGpyHTp2DwXt+j kn++lYNwZEorh8si4tj72dezz6YFB5DfKO22OrXS50q6gVMfAVFMKcI1FL/z40dHfLLiIbT/V1v mk8gxxM5e3JxJIq0NSwSztrte8Rn/2Oa7f7SScH6YQf8nMNTkr87Lj8Kt7O0fY77sBxnn29saVJ jaEgIYokGmozpisGON23XH76VNr+/7rB8RZx5kPBpsN+BbzF12+oqfsGbwEvhzSezhYuesCuJOB KUpTApZWRXr2AqbKPA== X-Google-Smtp-Source: AGHT+IFgqfe+kqsUtZy9+xGWMGhOgzZuAgj5lfe6mAr4/ZjzImfvHLnClnHam5X0h2CYqu1MJB3xkw== X-Received: by 2002:a17:90b:51cf:b0:2ee:c30f:33c9 with SMTP id 98e67ed59e1d1-2f2d883bf1emr990096a91.14.1734379919583; Mon, 16 Dec 2024 12:11:59 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:953:5b91:a52c:e817]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2f142d90bcdsm8423943a91.5.2024.12.16.12.11.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 12:11:59 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: Maxime Ripard , linux-acpi@vger.kernel.org, Rae Moar , Rob Herring , David Gow , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Brian Norris , "Rafael J. Wysocki" Subject: [PATCH v3 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc Date: Mon, 16 Dec 2024 12:11:42 -0800 Message-ID: <20241216201148.535115-2-briannorris@chromium.org> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog In-Reply-To: <20241216201148.535115-1-briannorris@chromium.org> References: <20241216201148.535115-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 of_find_device_by_node(), bus_find_device_by_of_node(), bus_find_device_by_fwnode(), ..., all produce arbitrary results when provided with a NULL of_node, fwnode, ACPI handle, etc. This is counterintuitive, and the source of a few bugs, such as the one fixed by commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if one actually exists"). It's hard to imagine a good reason that these device_match_*() APIs should return 'true' for a NULL argument. Augment these to return 0 (false). Reviewed-by: Rob Herring (Arm) Acked-by: Rafael J. Wysocki Signed-off-by: Brian Norris Acked-by: David Gow Acked-by: Shuah Khan --- Changes in v3: * Add Rafael's Acked-by Changes in v2: * Add Rob's Reviewed-by drivers/base/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 94865c9d8adc..2b7b13fc36d7 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -5246,13 +5246,13 @@ EXPORT_SYMBOL_GPL(device_match_name); int device_match_of_node(struct device *dev, const void *np) { - return dev->of_node == np; + return np && dev->of_node == np; } EXPORT_SYMBOL_GPL(device_match_of_node); int device_match_fwnode(struct device *dev, const void *fwnode) { - return dev_fwnode(dev) == fwnode; + return fwnode && dev_fwnode(dev) == fwnode; } EXPORT_SYMBOL_GPL(device_match_fwnode); @@ -5264,13 +5264,13 @@ EXPORT_SYMBOL_GPL(device_match_devt); int device_match_acpi_dev(struct device *dev, const void *adev) { - return ACPI_COMPANION(dev) == adev; + return adev && ACPI_COMPANION(dev) == adev; } EXPORT_SYMBOL(device_match_acpi_dev); int device_match_acpi_handle(struct device *dev, const void *handle) { - return ACPI_HANDLE(dev) == handle; + return handle && ACPI_HANDLE(dev) == handle; } EXPORT_SYMBOL(device_match_acpi_handle);