| Message ID | 20230909141816.58358-3-hdegoede@redhat.com |
|---|---|
| State | Accepted |
| Commit | 6cc64f6173751d212c9833bde39e856b4f585a3e |
| Headers | show |
| Series | x86-android-tablets: Stop using gpiolib private APIs | expand |
On Sat, Sep 9, 2023 at 5:18 PM Hans de Goede <hdegoede@redhat.com> wrote: > > On the Peaq C1010 2-in-1 INT33FC:00 pin 3 is connected to > a "dolby" button. At the ACPI level an _AEI event-handler > is connected which sets an ACPI variable to 1 on both > edges. This variable can be polled + cleared to 0 using WMI. > > Since the variable is set on both edges the WMI interface is pretty > useless even when polling. So instead of writing a custom WMI > driver for this the x86-android-tablets code instantiates > a gpio-keys platform device for the "dolby" button. > > Add an ignore_interrupt quirk for INT33FC:00 pin 3 on the Peaq C1010, > so that it is not seen as busy when the gpio-keys driver requests it. > > Note this replaces a hack in x86-android-tablets where it would > call acpi_gpiochip_free_interrupts() on the INT33FC:00 GPIO > controller. acpi_gpiochip_free_interrupts() is considered private > (internal) gpiolib API so x86-android-tablets should stop using it. Yeah, OEMs often don't know what they are doing in firmwares... Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
On Sat, Sep 09, 2023 at 04:18:10PM +0200, Hans de Goede wrote: > On the Peaq C1010 2-in-1 INT33FC:00 pin 3 is connected to > a "dolby" button. At the ACPI level an _AEI event-handler > is connected which sets an ACPI variable to 1 on both > edges. This variable can be polled + cleared to 0 using WMI. > > Since the variable is set on both edges the WMI interface is pretty > useless even when polling. So instead of writing a custom WMI > driver for this the x86-android-tablets code instantiates > a gpio-keys platform device for the "dolby" button. > > Add an ignore_interrupt quirk for INT33FC:00 pin 3 on the Peaq C1010, > so that it is not seen as busy when the gpio-keys driver requests it. > > Note this replaces a hack in x86-android-tablets where it would > call acpi_gpiochip_free_interrupts() on the INT33FC:00 GPIO > controller. acpi_gpiochip_free_interrupts() is considered private > (internal) gpiolib API so x86-android-tablets should stop using it. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Sat, Sep 9, 2023 at 4:18 PM Hans de Goede <hdegoede@redhat.com> wrote: > > On the Peaq C1010 2-in-1 INT33FC:00 pin 3 is connected to > a "dolby" button. At the ACPI level an _AEI event-handler > is connected which sets an ACPI variable to 1 on both > edges. This variable can be polled + cleared to 0 using WMI. > > Since the variable is set on both edges the WMI interface is pretty > useless even when polling. So instead of writing a custom WMI > driver for this the x86-android-tablets code instantiates > a gpio-keys platform device for the "dolby" button. > > Add an ignore_interrupt quirk for INT33FC:00 pin 3 on the Peaq C1010, > so that it is not seen as busy when the gpio-keys driver requests it. > > Note this replaces a hack in x86-android-tablets where it would > call acpi_gpiochip_free_interrupts() on the INT33FC:00 GPIO > controller. acpi_gpiochip_free_interrupts() is considered private > (internal) gpiolib API so x86-android-tablets should stop using it. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index 80b9650a2424..583ac5da9d41 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -1654,6 +1654,26 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = { .ignore_wake = "SYNA1202:00@16", }, }, + { + /* + * On the Peaq C1010 2-in-1 INT33FC:00 pin 3 is connected to + * a "dolby" button. At the ACPI level an _AEI event-handler + * is connected which sets an ACPI variable to 1 on both + * edges. This variable can be polled + cleared to 0 using + * WMI. But since the variable is set on both edges the WMI + * interface is pretty useless even when polling. + * So instead the x86-android-tablets code instantiates + * a gpio-keys platform device for it. + * Ignore the _AEI handler for the pin, so that it is not busy. + */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "PEAQ"), + DMI_MATCH(DMI_PRODUCT_NAME, "PEAQ PMM C1010 MD99187"), + }, + .driver_data = &(struct acpi_gpiolib_dmi_quirk) { + .ignore_interrupt = "INT33FC:00@3", + }, + }, {} /* Terminating entry */ };
On the Peaq C1010 2-in-1 INT33FC:00 pin 3 is connected to a "dolby" button. At the ACPI level an _AEI event-handler is connected which sets an ACPI variable to 1 on both edges. This variable can be polled + cleared to 0 using WMI. Since the variable is set on both edges the WMI interface is pretty useless even when polling. So instead of writing a custom WMI driver for this the x86-android-tablets code instantiates a gpio-keys platform device for the "dolby" button. Add an ignore_interrupt quirk for INT33FC:00 pin 3 on the Peaq C1010, so that it is not seen as busy when the gpio-keys driver requests it. Note this replaces a hack in x86-android-tablets where it would call acpi_gpiochip_free_interrupts() on the INT33FC:00 GPIO controller. acpi_gpiochip_free_interrupts() is considered private (internal) gpiolib API so x86-android-tablets should stop using it. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpio/gpiolib-acpi.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)