| Message ID | 20230301214952.2190757-2-saravanak@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | Remove use of fw_devlink_purge_absent_suppliers() | expand |
On Wed, Mar 01, 2023 at 01:49:48PM -0800, Saravana Kannan wrote: > This reverts commit 6b63376722d9 (usb: typec: stusb160x: Don't block > probing of consumer of "connector" nodes, 2021-07-16). > > After recent changes to fw_devlink that ended with commit 4a032827daa8 > ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer > cares about the "compatible" property and figures out the correct struct > device at runtime. So, we no longer need to call > fw_devlink_purge_absent_suppliers(). > > Signed-off-by: Saravana Kannan <saravanak@google.com> > Cc: Amelie Delaunay <amelie.delaunay@foss.st.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/stusb160x.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c > index 494b371151e0..482bffeb8a8f 100644 > --- a/drivers/usb/typec/stusb160x.c > +++ b/drivers/usb/typec/stusb160x.c > @@ -685,15 +685,6 @@ static int stusb160x_probe(struct i2c_client *client) > if (!fwnode) > return -ENODEV; > > - /* > - * This fwnode has a "compatible" property, but is never populated as a > - * struct device. Instead we simply parse it to read the properties. > - * This it breaks fw_devlink=on. To maintain backward compatibility > - * with existing DT files, we work around this by deleting any > - * fwnode_links to/from this fwnode. > - */ > - fw_devlink_purge_absent_suppliers(fwnode); > - > /* > * When both VDD and VSYS power supplies are present, the low power > * supply VSYS is selected when VSYS voltage is above 3.1 V. > -- > 2.39.2.722.g9855ee24e9-goog
diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c index 494b371151e0..482bffeb8a8f 100644 --- a/drivers/usb/typec/stusb160x.c +++ b/drivers/usb/typec/stusb160x.c @@ -685,15 +685,6 @@ static int stusb160x_probe(struct i2c_client *client) if (!fwnode) return -ENODEV; - /* - * This fwnode has a "compatible" property, but is never populated as a - * struct device. Instead we simply parse it to read the properties. - * This it breaks fw_devlink=on. To maintain backward compatibility - * with existing DT files, we work around this by deleting any - * fwnode_links to/from this fwnode. - */ - fw_devlink_purge_absent_suppliers(fwnode); - /* * When both VDD and VSYS power supplies are present, the low power * supply VSYS is selected when VSYS voltage is above 3.1 V.
This reverts commit 6b63376722d9 (usb: typec: stusb160x: Don't block probing of consumer of "connector" nodes, 2021-07-16). After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, we no longer need to call fw_devlink_purge_absent_suppliers(). Signed-off-by: Saravana Kannan <saravanak@google.com> Cc: Amelie Delaunay <amelie.delaunay@foss.st.com> --- drivers/usb/typec/stusb160x.c | 9 --------- 1 file changed, 9 deletions(-)