From patchwork Tue Feb 21 09:50:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pin-yen Lin X-Patchwork-Id: 655425 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC2AC64EC7 for ; Tue, 21 Feb 2023 09:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234062AbjBUJve (ORCPT ); Tue, 21 Feb 2023 04:51:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234049AbjBUJv3 (ORCPT ); Tue, 21 Feb 2023 04:51:29 -0500 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 632A5252B0 for ; Tue, 21 Feb 2023 01:51:27 -0800 (PST) Received: by mail-pj1-x102e.google.com with SMTP id x34so725334pjj.0 for ; Tue, 21 Feb 2023 01:51:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=84m3FSulx+pWKCpnyEJ3RgcMwe/Bo6Rt70rnUQNfHew=; b=Teyu6n12+9jHyEBpVJMRsPinTHx4mlBvUReMYsnpwoUDixoB2lEOVV2Xog1BzRpAvJ VYi/SSy+LXeg6/qYwipRJqeLiYxgN+YsKEYFdVZcVBmF+G/kGBAuKijJtP0BtO+IUFH4 GvwOruadQ0wlgGnbAyXdRip2lNBYu8fXadKC8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=84m3FSulx+pWKCpnyEJ3RgcMwe/Bo6Rt70rnUQNfHew=; b=Wuer0s5h3M+/5tlXOsoT8G1jrPiE1bubGLQzF+1AOHswd4OmNy9HXGBWtRkgPtSoRw jzjfQG1bRIL+PqIi/0lPRWksQMFQ6QpkFqN1rj0IcmQUTJz7eoNUrc2M62jhwrr03NNc Kuz4SAqaSKGo04tFOu/egDMxB/+Eawbq8MD2FnXs0zjXKWO4Ut+aGv+WCjPYAz9qPLHE 3tlpb4GVsc4rg26rD7DstTocxzihxg7HxTRF+y5kCEfG2/ilGzSxPr+LLHuuT5s0eat1 KI3ZxWsoWpTa9O+AXL0Acyzjw7fQnbjTfHGgR6+eo2lS62LhkmYJtK24st5RZXI7vHRB VpWg== X-Gm-Message-State: AO0yUKUcUr+bK5UwAgo0EqHVI2Wci39o7k7fjb9NhBoysQBKiBKQaVPD UHjkwdRKgXbx3e/IWrW8b7m3Yw== X-Google-Smtp-Source: AK7set9uPErKNPWkA0C6wXikny0rBTip0v+7aGBXZ2ecMwWeSiY/MrX0F0uijgQvHPcAH9Y6v3wTAg== X-Received: by 2002:a05:6a21:3394:b0:bc:cff9:f092 with SMTP id yy20-20020a056a21339400b000bccff9f092mr4888829pzb.10.1676973086834; Tue, 21 Feb 2023 01:51:26 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:a1f5:f58d:584e:5906]) by smtp.gmail.com with ESMTPSA id t25-20020a656099000000b004eca54eab50sm3524918pgu.28.2023.02.21.01.51.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 01:51:26 -0800 (PST) From: Pin-yen Lin To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck Cc: Pin-yen Lin , linux-kernel@vger.kernel.org, Hsin-Yi Wang , Marek Vasut , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Xin Ji , Lyude Paul , Allen Chen , devicetree@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , chrome-platform@lists.linux.dev, Javier Martinez Canillas , linux-acpi@vger.kernel.org, Stephen Boyd , Chen-Yu Tsai Subject: [PATCH v12 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks Date: Tue, 21 Feb 2023 17:50:46 +0800 Message-Id: <20230221095054.1868277-3-treapking@chromium.org> X-Mailer: git-send-email 2.39.2.637.g21b0678d19-goog In-Reply-To: <20230221095054.1868277-1-treapking@chromium.org> References: <20230221095054.1868277-1-treapking@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-connector (i.e the child of the port driver) as a supplier, fw_devlink will not be able to resolve the cyclic dependency correctly. As a result, the mode-switch driver probe() never runs, so mode-switches are never registered. Because of that, the port driver probe constantly fails with -EPROBE_DEFER, because the Type-C connector class requires all switch devices to be registered prior to port registration. To break this deadlock and allow the mode-switch registration to occur, purge all the usb-c-connector nodes' absent suppliers. This eliminates the connector as a supplier for a switch and allows it to be probed. Signed-off-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Acked-by: Heikki Krogerus --- (no changes since v11) Changes in v11: - Collected Acked-by tag Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v7: - Fix the long comment lines Changes in v6: - New in v6 drivers/platform/chrome/cros_ec_typec.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 001b0de95a46..bbc95a3ba5a7 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -385,6 +385,16 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) return -EINVAL; } + /* + * OF graph may have set up some device links with switches, + * since connectors have their own compatible. Purge these + * to avoid a deadlock in switch probe (the switch mistakenly + * assumes the connector is a supplier). + */ + if (dev_of_node(dev)) + device_for_each_child_node(dev, fwnode) + fw_devlink_purge_absent_suppliers(fwnode); + /* DT uses "reg" to specify port number. */ port_prop = dev->of_node ? "reg" : "port-number"; device_for_each_child_node(dev, fwnode) {