From patchwork Thu Apr 21 16:42:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 565355 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CA4C433EF for ; Thu, 21 Apr 2022 16:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232155AbiDUQp7 (ORCPT ); Thu, 21 Apr 2022 12:45:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbiDUQp4 (ORCPT ); Thu, 21 Apr 2022 12:45:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9CFF548E55 for ; Thu, 21 Apr 2022 09:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650559385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+Bjh4A2xgvA65XgQNDvQgstLNivQfww0GqMpHMFLzMk=; b=XxcHHESF1ktRllaZMJAEpFTvcbaapMSnHTNSJ80pLmtGyXUsbHsBmK+Ngw3xhtoTPvkaiF gtF8PU1WVhfoOK6B37BMiLGzp5jtukqckKn2pWBLm7fBrKtI7sYms6aNz+je28dKmJGo0Q cQeFehS13Y8ZdjMqzFEQHSEbWzNfF+E= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-410-bM-J-634PWCAgMk2HQafHA-1; Thu, 21 Apr 2022 12:43:04 -0400 X-MC-Unique: bM-J-634PWCAgMk2HQafHA-1 Received: by mail-qk1-f199.google.com with SMTP id q12-20020ae9e40c000000b0069f091022dbso880887qkc.3 for ; Thu, 21 Apr 2022 09:43:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+Bjh4A2xgvA65XgQNDvQgstLNivQfww0GqMpHMFLzMk=; b=JKrocvIwuxGpwITVgPgwaTyVSXt7JaFaNXYjjpINivWEnpUcXiF49OfUXXe4wW42gv KbcHCbW4FgXk+K9eSwETN9ZkSQE+sFk1r9vKBTS3Ye34lqK4of0aQKoBI5FWi4EDvbN/ +/vniU9SPw7EbIlhaQxmOIzcqUp2HM5X2iVpvw65N9ovzcZygYLGWOrJ7e0kTDa2Ax3F ghk3aLTK2vpk72nH1zbWOJBcnyJmQ5Gw3KyY2c7zivRNWaNxbQYi3pnzd6Ql1wFZmtY+ L2/I9b/8AJE5NgIhmSXQe6uSmzVKmgkfwX+OshHWFe1w0YEHQWIo4o+G+ArcymN7rdoF 3nhw== X-Gm-Message-State: AOAM531ArODblfAMPJUOY8NotcObnnNMTsAUVOQ8ud9bOa0VVJ/RBSJX TPx+fGlpx6XvUY5RyYTKoVQqpIsI3T89x/bRsxkM0lUMJRCBqKf7YtSD4R4cHOe8FH+smE/Ltah I8SQ3z0wQQtko4JEzxScJjg== X-Received: by 2002:a37:65ca:0:b0:69e:d32a:91ff with SMTP id z193-20020a3765ca000000b0069ed32a91ffmr213238qkb.766.1650559383963; Thu, 21 Apr 2022 09:43:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNg8tV2VAaDIcr+Juw0PHofmf5dHfJBDMtp/TlbLkvBCvx+GsRyiFAk7MK5zPhP5ECQJbrTw== X-Received: by 2002:a37:65ca:0:b0:69e:d32a:91ff with SMTP id z193-20020a3765ca000000b0069ed32a91ffmr213227qkb.766.1650559383776; Thu, 21 Apr 2022 09:43:03 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id z8-20020ac87f88000000b002e1cecad0e4sm3631641qtj.33.2022.04.21.09.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 09:43:03 -0700 (PDT) From: Tom Rix To: rafael@kernel.org, lenb@kernel.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] ACPI: bgrt: use static for BGRT_SHOW kobj_attribute defines Date: Thu, 21 Apr 2022 12:42:54 -0400 Message-Id: <20220421164254.859162-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Smatch reports this repesentative issue bgrt.c:26:1: warning: symbol 'bgrt_attr_version' was not declared. Should it be static? Similar for *status,type,xoffset,yoffset These variables are defined with the BGRT_SHOW macro. For the definition of bgrt_attr_##_name, the storage-class specifier should be static Signed-off-by: Tom Rix --- drivers/acpi/bgrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/bgrt.c b/drivers/acpi/bgrt.c index 02d208732f9a..e4fb9e225ddf 100644 --- a/drivers/acpi/bgrt.c +++ b/drivers/acpi/bgrt.c @@ -21,7 +21,7 @@ static struct kobject *bgrt_kobj; { \ return sysfs_emit(buf, "%d\n", bgrt_tab._member); \ } \ - struct kobj_attribute bgrt_attr_##_name = __ATTR_RO(_name) + static struct kobj_attribute bgrt_attr_##_name = __ATTR_RO(_name) BGRT_SHOW(version, version); BGRT_SHOW(status, status);