From patchwork Fri Jan 28 02:37:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Won Chung X-Patchwork-Id: 537641 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AA4C433F5 for ; Fri, 28 Jan 2022 02:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345446AbiA1Ch7 (ORCPT ); Thu, 27 Jan 2022 21:37:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345450AbiA1Ch7 (ORCPT ); Thu, 27 Jan 2022 21:37:59 -0500 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0414EC061714 for ; Thu, 27 Jan 2022 18:37:59 -0800 (PST) Received: by mail-pg1-x549.google.com with SMTP id p29-20020a634f5d000000b003624b087f05so2541600pgl.7 for ; Thu, 27 Jan 2022 18:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=Tx91uzRklLUZsIGK6wpPBgEZN67pGca2y2X/Cf0r4s0=; b=c2Fwu+ijB/lJQVEG2CcXr/o64uO33R9F+A4ozcUrSOMK2qCTO9m7/d9t/fgFkzWOi+ yE7BZGkaFba8hFusCWoP5ZYtBeKUQPJrSmgWwAb0f+IB1pBhIbQ+A4aIhsSYp0BAA8+R Qcl64n/iVHvA9oDtmMS9gSGiWo2dYsk7VXbJC9NoIcUbAHXEwYQgAkyNrKl1Spbg+6mr bphN9mnO0wlU3mwd1f32XpIKyG5v4AlJ3beQ+gLmgn5svmvqjnmB4z5NmvjzqoMHtVg1 ubB74peFREjNzvvVWT0aBxhlmTHLisxms/znuRcpYlcwXU/9Tgw2nqVBaM3Q1WqDBurO d1SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=Tx91uzRklLUZsIGK6wpPBgEZN67pGca2y2X/Cf0r4s0=; b=5Q41DgzS+LYW5LZ5ycYt5cQ3oXr0iS794AsFsU4QzYNmo+hTX3zQlU6fPEFAdcpn4K S/kf5tdSa3TPGh56cu9FViDkPoAwCPNqyu1C4UAlyMlCnT+UXlio8Derp73YLyzsEKZq hbiWgQgyWmQ0bf4NG2l7r7kWT1o9kz7BcyIVdj4rSKhtFTutY2k77GH5HIEoNnjyOESi j8Wd3Q5tXVkEJI0QhAH+21XzoKZbTXsonlf+Ygb5CHX1Ir1jEpCyLsvZtlSwQIYU+0nh GkNXdUPWMpbBeyMyvQcRGzt6CXGBNgt4zzfok32P3ExrO/AYNPqWP5rzD8LDWREC8u0h sWfg== X-Gm-Message-State: AOAM533Mw7k2F5KMXeLnLH77ES0V4fKyn505SJJdkui7c2llwPDoEkYc jLT71xCDth05EvFjj3O3B2FZznsoRtYlUw== X-Google-Smtp-Source: ABdhPJxjteEi7YryfGCT4sjW6oKYz1W4HfbCKEU8ZNQaI72C6U64V/sdJZ3UsCVNmr8G5kuVk03pG8stidL93w== X-Received: from wonchungspecialist.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1440]) (user=wonchung job=sendgmr) by 2002:aa7:8b13:: with SMTP id f19mr6097173pfd.62.1643337478516; Thu, 27 Jan 2022 18:37:58 -0800 (PST) Date: Fri, 28 Jan 2022 02:37:54 +0000 Message-Id: <20220128023754.2235811-1-wonchung@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.0.rc0.227.g00780c9af4-goog Subject: [PATCH v2] ACPI: device_sysfs: Add sysfs support for _PLD From: Won Chung To: "Rafael J . Wysocki" , Len Brown , Benson Leung , Prashant Malani , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Won Chung Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org When ACPI table includes _PLD fields for a device, create a new file (pld) in sysfs to share _PLD fields. Signed-off-by: Won Chung --- Documentation/ABI/testing/sysfs-bus-acpi | 53 ++++++++++++++++++++++++ drivers/acpi/device_sysfs.c | 42 +++++++++++++++++++ 2 files changed, 95 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-acpi b/Documentation/ABI/testing/sysfs-bus-acpi index 58abacf59b2a..3a9c6a4f4603 100644 --- a/Documentation/ABI/testing/sysfs-bus-acpi +++ b/Documentation/ABI/testing/sysfs-bus-acpi @@ -96,3 +96,56 @@ Description: hardware, if the _HRV control method is present. It is mostly useful for non-PCI devices because lspci can list the hardware version for PCI devices. + +What: /sys/bus/acpi/devices/.../pld +Date: Jan, 2022 +Contact: Won Chung +Description: + This attribute contains the output of the device object's + _PLD control method, if present. This information provides + details on physical location of a port. + + Description on each _PLD field from ACPI specification: + + =============== ============================================ + GROUP_TOKEN Unique numerical value identifying a group. + GROUP_POSITION Identifies this device connection point’s + position in the group. + USER_VISIBLE Set if the device connection point can be + seen by the user without disassembly. + DOCK Set if the device connection point resides + in a docking station or port replicator. + BAY Set if describing a device in a bay or if + device connection point is a bay. + LID Set if this device connection point resides + on the lid of laptop system. + PANEL Describes which panel surface of the system’s + housing the device connection point resides on: + 0 - Top + 1 - Bottom + 2 - Left + 3 - Right + 4 - Front + 5 - Back + 6 - Unknown (Vertical Position and Horizontal + Position will be ignored) + HORIZONTAL_ 0 - Left + POSITION 1 - Center + 2 - Right + VERTICAL_ 0 - Upper + POSITION 1 - Center + 2 - Lower + SHAPE Describes the shape of the device connection + point. + 0 - Round + 1 - Oval + 2 - Square + 3 - Vertical Rectangle + 4 - Horizontal Rectangle + 5 - Vertical Trapezoid + 6 - Horizontal Trapezoid + 7 - Unknown - Shape rendered as a Rectangle + with dotted lines + 8 - Chamfered + 15:9 - Reserved + =============== =============================================== diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c index d5d6403ba07b..8d4df5fb1c45 100644 --- a/drivers/acpi/device_sysfs.c +++ b/drivers/acpi/device_sysfs.c @@ -509,6 +509,40 @@ static ssize_t status_show(struct device *dev, struct device_attribute *attr, } static DEVICE_ATTR_RO(status); +static ssize_t pld_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct acpi_device *acpi_dev = to_acpi_device(dev); + acpi_status status; + struct acpi_pld_info *pld; + + status = acpi_get_physical_device_location(acpi_dev->handle, &pld); + if (ACPI_FAILURE(status)) + return -ENODEV; + + return sprintf(buf, "GROUP_TOKEN=%u\n" + "GROUP_POSITION=%u\n" + "USER_VISIBLE=%u\n" + "DOCK=%u\n" + "BAY=%u\n" + "LID=%u\n" + "PANEL=%u\n" + "HORIZONTAL_POSITION=%u\n" + "VERTICAL_POSITION=%u\n" + "SHAPE=%u\n", + pld->group_token, + pld->group_position, + pld->user_visible, + pld->dock, + pld->bay, + pld->lid, + pld->panel, + pld->horizontal_position, + pld->vertical_position, + pld->shape); +} +static DEVICE_ATTR_RO(pld); + /** * acpi_device_setup_files - Create sysfs attributes of an ACPI device. * @dev: ACPI device object. @@ -595,6 +629,12 @@ int acpi_device_setup_files(struct acpi_device *dev) &dev_attr_real_power_state); } + if (acpi_has_method(dev->handle, "_PLD")) { + result = device_create_file(&dev->dev, &dev_attr_pld); + if (result) + goto end; + } + acpi_expose_nondev_subnodes(&dev->dev.kobj, &dev->data); end: @@ -645,4 +685,6 @@ void acpi_device_remove_files(struct acpi_device *dev) device_remove_file(&dev->dev, &dev_attr_status); if (dev->handle) device_remove_file(&dev->dev, &dev_attr_path); + if (acpi_has_method(dev->handle, "_PLD")) + device_remove_file(&dev->dev, &dev_attr_pld); }