From patchwork Thu Jul 8 18:08:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 471277 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp526036jao; Thu, 8 Jul 2021 11:09:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0Dpxm6SUAmQDScfB2W10mdIaXxx/urGjk8Hwx/bAPtzGyjpbJfNq49/16EbISXu7JNTzL X-Received: by 2002:a05:6402:510d:: with SMTP id m13mr39651438edd.179.1625767753037; Thu, 08 Jul 2021 11:09:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625767753; cv=none; d=google.com; s=arc-20160816; b=LzLGMJ3GeCgSf6okDdz0PygNZyL0GjxuN1aIS35Qj/iiT0bsu6vMw8ZCO478lR4uA3 HAMG9MWHlmxuQZuJ5EtUXYr+hXArXZVqcvDvRWeWv6/BZ+1XKk3d0dE/1MVUB3n+zxSl CnP32qw+2pzFDmPU9AukvD2qUM06B39I/9gE6d0gpx9I1i+7zldDML54aRIPkbKAJUaJ KKUm3eLaodGG7O6f44k7hsDiIdjcAjd+VyYMBlnWjRbF/yGjftzpiykvsFy266p5lqf8 jAoP3+O2HukFy62m/S811iFYcJ/jz5hQSa0P8IZgzw0uS27+iHaXisEwWaBANahC/xAm UBXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=N6QnEANcEJnWKhIUTk0kGp8KUldmRM7MdJN0qBm/24M=; b=uA1xNMoM+jcywVtoNRBO4mv9Eb08L/tP1uj7fGA2OBMCjIhnZE72iQxkFAg+58nXnd EyFANwz1dX40Yk7LCNvk83DQoZN5pabIjaaNRLv+P9fs0At0KJaesAe7hs5TWXl43kPK Dw2+MFSsfMgaMpkwp9RGYyr+f6YhjOL4IqD1f8+r3VfthLPXob4J/8H98ddU5GpatvAJ MdFcvQSSr3cGOga6nrP9k6ppePO1lfCjbkGZBzjAvPn9/+/3a4AI1pEuHBWuJv3ZarRH nCwkx8V5JWW/RT3W81At5i0kRp2GU9kuPbC+KWc/yqW8mFQtbIIbO9+egzRrFzvJxXKv gBAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-acpi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-acpi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si3810568ejc.395.2021.07.08.11.09.12; Thu, 08 Jul 2021 11:09:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-acpi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-acpi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-acpi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230271AbhGHSLx (ORCPT + 4 others); Thu, 8 Jul 2021 14:11:53 -0400 Received: from foss.arm.com ([217.140.110.172]:36026 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230191AbhGHSLu (ORCPT ); Thu, 8 Jul 2021 14:11:50 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4DB03D6E; Thu, 8 Jul 2021 11:09:08 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 66E6B3F66F; Thu, 8 Jul 2021 11:09:07 -0700 (PDT) From: Sudeep Holla To: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sudeep Holla , Cristian Marussi , "Rafael J . Wysocki" , Jassi Brar Subject: [PATCH 08/13] mailbox: pcc: Rename doorbell ack to platform interrupt ack register Date: Thu, 8 Jul 2021 19:08:46 +0100 Message-Id: <20210708180851.2311192-9-sudeep.holla@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210708180851.2311192-1-sudeep.holla@arm.com> References: <20210708180851.2311192-1-sudeep.holla@arm.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org The specification refers this register and associated bitmask as platform interrupt acknowledge register. Let us rename it so that it is easier to map and understand. Signed-off-by: Sudeep Holla --- drivers/mailbox/pcc.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) -- 2.25.1 diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index 49971e007e40..c4eecccac4b8 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c @@ -69,13 +69,14 @@ static struct mbox_chan *pcc_mbox_channels; * * @chan: PCC channel information with Shared Memory Region info * @db_vaddr: cached virtual address for doorbell register - * @db_ack_vaddr: cached virtual address for doorbell ack register + * @plat_irq_ack_vaddr: cached virtual address for platform interrupt + * acknowledge register * @db_irq: doorbell interrupt */ struct pcc_chan_info { struct pcc_mbox_chan chan; void __iomem *db_vaddr; - void __iomem *db_ack_vaddr; + void __iomem *plat_irq_ack_vaddr; int db_irq; }; @@ -198,12 +199,12 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p) doorbell_ack_preserve = pcct2_ss->ack_preserve_mask; doorbell_ack_write = pcct2_ss->ack_write_mask; - ret = read_register(pchan->db_ack_vaddr, + ret = read_register(pchan->plat_irq_ack_vaddr, &doorbell_ack_val, doorbell_ack->bit_width); if (ret) return IRQ_NONE; - ret = write_register(pchan->db_ack_vaddr, + ret = write_register(pchan->plat_irq_ack_vaddr, (doorbell_ack_val & doorbell_ack_preserve) | doorbell_ack_write, doorbell_ack->bit_width); @@ -406,10 +407,10 @@ static int pcc_parse_subspace_irq(struct pcc_chan_info *pchan, if (pcct_ss->header.type == ACPI_PCCT_TYPE_HW_REDUCED_SUBSPACE_TYPE2) { struct acpi_pcct_hw_reduced_type2 *pcct2_ss = (void *)pcct_ss; - pchan->db_ack_vaddr = + pchan->plat_irq_ack_vaddr = acpi_os_ioremap(pcct2_ss->platform_ack_register.address, pcct2_ss->platform_ack_register.bit_width / 8); - if (!pchan->db_ack_vaddr) { + if (!pchan->plat_irq_ack_vaddr) { pr_err("Failed to ioremap PCC ACK register\n"); return -ENOMEM; }