mbox series

[0/3] CXL: ACPI: faux: Fix cxl_core.ko module load regression

Message ID 20250607033228.1475625-1-dan.j.williams@intel.com
Headers show
Series CXL: ACPI: faux: Fix cxl_core.ko module load regression | expand

Message

Dan Williams June 7, 2025, 3:32 a.m. UTC 
git bisect flags:

6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device interface")

...as the reason basic CXL unit tests are failing on latest mainline. In
addition to the fix to einj-core.c, this also needs some updates to
faux_device to make it behave more like platform_driver_probe(). Details
in the individual patches.

Dan Williams (3):
  driver core: faux: Suppress bind attributes
  driver core: faux: Quiet probe failures
  ACPI: APEI: EINJ: Do not fail einj_init() on faux_device_create()
    failure

 drivers/acpi/apei/einj-core.c | 9 +++------
 drivers/base/faux.c           | 3 ++-
 2 files changed, 5 insertions(+), 7 deletions(-)


base-commit: a9dfb7db96f7bc1f30feae673aab7fdbfbc94e9c

Comments

Dave Jiang June 9, 2025, 3:04 p.m. UTC | #1 
On 6/6/25 8:32 PM, Dan Williams wrote:
> git bisect flags:
> 
> 6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device interface")
> 
> ...as the reason basic CXL unit tests are failing on latest mainline. In
> addition to the fix to einj-core.c, this also needs some updates to
> faux_device to make it behave more like platform_driver_probe(). Details
> in the individual patches.
> 
> Dan Williams (3):
>   driver core: faux: Suppress bind attributes
>   driver core: faux: Quiet probe failures
>   ACPI: APEI: EINJ: Do not fail einj_init() on faux_device_create()
>     failure

LGTM
Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> 
>  drivers/acpi/apei/einj-core.c | 9 +++------
>  drivers/base/faux.c           | 3 ++-
>  2 files changed, 5 insertions(+), 7 deletions(-)
> 
> 
> base-commit: a9dfb7db96f7bc1f30feae673aab7fdbfbc94e9c
Greg KH June 10, 2025, 10:12 a.m. UTC | #2 
On Mon, Jun 09, 2025 at 08:58:26PM +0200, Rafael J. Wysocki wrote:
> On Mon, Jun 9, 2025 at 5:04 PM Dave Jiang <dave.jiang@intel.com> wrote:
> >
> >
> >
> > On 6/6/25 8:32 PM, Dan Williams wrote:
> > > git bisect flags:
> > >
> > > 6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device interface")
> > >
> > > ...as the reason basic CXL unit tests are failing on latest mainline. In
> > > addition to the fix to einj-core.c, this also needs some updates to
> > > faux_device to make it behave more like platform_driver_probe(). Details
> > > in the individual patches.
> > >
> > > Dan Williams (3):
> > >   driver core: faux: Suppress bind attributes
> > >   driver core: faux: Quiet probe failures
> > >   ACPI: APEI: EINJ: Do not fail einj_init() on faux_device_create()
> > >     failure
> >
> > LGTM
> > Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> >
> > >
> > >  drivers/acpi/apei/einj-core.c | 9 +++------
> > >  drivers/base/faux.c           | 3 ++-
> > >  2 files changed, 5 insertions(+), 7 deletions(-)
> 
> Greg, I think it's better if I route this through the ACPI tree as the
> issue being fixed was introduced through it.
> 
> Any concerns regarding this?

None from me!

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>