mbox series

[RFC,0/2] "custom" ACPI platform profile support

Message ID 20240926025955.1728766-1-superm1@kernel.org
Headers show
Series "custom" ACPI platform profile support | expand

Message

Mario Limonciello Sept. 26, 2024, 2:59 a.m. UTC 
From: Mario Limonciello <mario.limonciello@amd.com>

There are two major ways to tune platform performance in Linux:
 * ACPI platform profile
 * Manually tuning APU performance

Changing the ACPI platform profile is a "one stop shop" to change
performance limits and fan curves all at the same time.

On AMD systems the manual tuning methods typically involve changing
values of settings such as fPPT, sPPT or SPL.

The problem with changing these settings manually is that the definition
of the ACPI platform profile if supported by the hardware is no longer
accurate.  At best this can cause misrepresenting the state of the
platform to userspace and at worst can cause the state machine into an
invalid state.

The existence and continued development of projects such as ryzenadj which
manipulate debugging interfaces show there is a demand for manually tuning
performance.

Furthermore some systems (such as ASUS and Lenovo handhelds) offer an
ACPI-WMI interface for changing these settings. If using anything outside
that WMI interface the state will be wrong.  If using that WMI interface
the platform profile will be wrong.

This series introduces a "custom" ACPI platform profile and adds support
for the AMD PMF driver to use it when a user has enabled manual
adjustments.

If agreeable a similar change should be made to asus-armoury and any other
drivers that export the ability to change these settings but also a
platform profile.

Mario Limonciello (2):
  ACPI: Add support for a 'custom' profile
  platform/x86/amd: pmf: Add manual control support

 Documentation/ABI/testing/sysfs-amd-pmf       | 10 +++
 .../ABI/testing/sysfs-platform_profile        |  1 +
 drivers/acpi/platform_profile.c               |  1 +
 drivers/platform/x86/amd/pmf/Makefile         |  1 +
 drivers/platform/x86/amd/pmf/core.c           |  9 ++
 drivers/platform/x86/amd/pmf/manual.c         | 88 +++++++++++++++++++
 drivers/platform/x86/amd/pmf/pmf.h            |  5 ++
 drivers/platform/x86/amd/pmf/sps.c            |  4 +
 include/linux/platform_profile.h              |  1 +
 9 files changed, 120 insertions(+)
 create mode 100644 drivers/platform/x86/amd/pmf/manual.c