mbox series

[v2,0/5] gpiolib: Add and utilise for_each_gpio_property_name()

Message ID 20240819142945.327808-1-andriy.shevchenko@linux.intel.com
Headers show
Series gpiolib: Add and utilise for_each_gpio_property_name() | expand

Message

Andy Shevchenko Aug. 19, 2024, 2:28 p.m. UTC 
There are a few of duplication of the same for-loop against GPIO
suffixes. This series addresses that along with proposal to eliminate
the exported gpio_suffix_count by converting the array to be
NULL-terminated.

v2:
- fixed a rebase issue (LKP)

Andy Shevchenko (5):
  gpiolib: Introduce for_each_gpio_property_name() helper
  gpiolib: swnode: Unify return code variable name
  gpiolib: swnode: Introduce swnode_gpio_get_reference() helper
  gpiolib: swnode: Make use of for_each_gpio_property_name()
  gpiolib: Replace gpio_suffix_count with NULL-terminated array

 drivers/gpio/gpiolib-acpi.c   | 21 ++----------
 drivers/gpio/gpiolib-of.c     | 25 +++------------
 drivers/gpio/gpiolib-swnode.c | 60 ++++++++++++++++-------------------
 drivers/gpio/gpiolib.c        |  3 +-
 drivers/gpio/gpiolib.h        | 16 ++++++++--
 5 files changed, 49 insertions(+), 76 deletions(-)

Comments

Bartosz Golaszewski Aug. 20, 2024, 8:33 a.m. UTC | #1 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 19 Aug 2024 17:28:55 +0300, Andy Shevchenko wrote:
> There are a few of duplication of the same for-loop against GPIO
> suffixes. This series addresses that along with proposal to eliminate
> the exported gpio_suffix_count by converting the array to be
> NULL-terminated.
> 
> v2:
> - fixed a rebase issue (LKP)
> 
> [...]

Applied, thanks!

[1/5] gpiolib: Introduce for_each_gpio_property_name() helper
      commit: ef3d4b94d2d88b160887ff9ca737a5f8ec101579
[2/5] gpiolib: swnode: Unify return code variable name
      commit: e42fce0ff99658b5b43e8dae4f7acc43d38a00ef
[3/5] gpiolib: swnode: Introduce swnode_gpio_get_reference() helper
      commit: 7fd6809888a82055fcca9d14417d5e2675f0acc5
[4/5] gpiolib: swnode: Make use of for_each_gpio_property_name()
      commit: a975a64692c39991fdde2f1d990b7bdd48d183fc
[5/5] gpiolib: Replace gpio_suffix_count with NULL-terminated array
      commit: 4b91188dced811e2d867574b672888406cb7114c

Best regards,
Linus Walleij Aug. 24, 2024, 2:43 p.m. UTC | #2 
On Mon, Aug 19, 2024 at 4:29 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> There are a few of duplication of the same for-loop against GPIO
> suffixes. This series addresses that along with proposal to eliminate
> the exported gpio_suffix_count by converting the array to be
> NULL-terminated.

Too late to the show, but excellent patches Andy!

Yours,
Linus Walleij
Rafael J. Wysocki Aug. 29, 2024, 10:45 a.m. UTC | #3 
On Mon, Aug 19, 2024 at 4:29 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> There are a few of duplication of the same for-loop against GPIO
> suffixes. This series addresses that along with proposal to eliminate
> the exported gpio_suffix_count by converting the array to be
> NULL-terminated.
>
> v2:
> - fixed a rebase issue (LKP)

All patches in this set look good to me:

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> Andy Shevchenko (5):
>   gpiolib: Introduce for_each_gpio_property_name() helper
>   gpiolib: swnode: Unify return code variable name
>   gpiolib: swnode: Introduce swnode_gpio_get_reference() helper
>   gpiolib: swnode: Make use of for_each_gpio_property_name()
>   gpiolib: Replace gpio_suffix_count with NULL-terminated array
>
>  drivers/gpio/gpiolib-acpi.c   | 21 ++----------
>  drivers/gpio/gpiolib-of.c     | 25 +++------------
>  drivers/gpio/gpiolib-swnode.c | 60 ++++++++++++++++-------------------
>  drivers/gpio/gpiolib.c        |  3 +-
>  drivers/gpio/gpiolib.h        | 16 ++++++++--
>  5 files changed, 49 insertions(+), 76 deletions(-)
>
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
>