mbox series

[0/3] ACPI/video / platform/x86: Add backlight=native quirk for Dell OptiPlex 7760 AIO

Message ID 20240814190159.15650-1-hdegoede@redhat.com
Headers show
Series ACPI/video / platform/x86: Add backlight=native quirk for Dell OptiPlex 7760 AIO | expand

Message

Hans de Goede Aug. 14, 2024, 7:01 p.m. UTC 
Hi Rafael,

6.10 has a new backlight driver for UART attached backlight controller
boards found in some Dell All in One models.

Now the first AIO has turned up which has not only the DSDT bits for this,
but also an actual controller attached to the UART, yet it is not using
this controller for backlight control (it needs GPU native control).

I did not tie the dell-uart-backlight into acpi_video_get_backlight_type()
yet, so the first 2 patches in this series deal with that and the third
patch adds a DMI quirk to select native backlight control on top.

Backlight control used to work on the Dell OptiPlex 7760 AIO with kernel
6.9 and older, so this is a regression and I would like to see this
series merged as fixes for 6.11.

Rafael, the drivers/platform/x86/dell/dell-uart-backlight.c are small
and isolated. So I believe it is best if you take the entire series,
to avoid conflicts if any other drivers/apci/video_detect.c DMI quirks
show up this cycle.

Regards,

Hans


Hans de Goede (3):
  ACPI: video: Add Dell UART backlight controller detection
  platform/x86: dell-uart-backlight: Use acpi_video_get_backlight_type()
  ACPI: video: Add backlight=native quirk for Dell OptiPlex 7760 AIO

 drivers/acpi/video_detect.c                   | 22 +++++++++++++++++++
 drivers/platform/x86/dell/Kconfig             |  1 +
 .../platform/x86/dell/dell-uart-backlight.c   |  8 +++++++
 include/acpi/video.h                          |  1 +
 4 files changed, 32 insertions(+)

Comments

Andy Shevchenko Aug. 14, 2024, 8:09 p.m. UTC | #1 
On Wed, Aug 14, 2024 at 09:01:56PM +0200, Hans de Goede wrote:
> Hi Rafael,
> 
> 6.10 has a new backlight driver for UART attached backlight controller
> boards found in some Dell All in One models.
> 
> Now the first AIO has turned up which has not only the DSDT bits for this,
> but also an actual controller attached to the UART, yet it is not using
> this controller for backlight control (it needs GPU native control).
> 
> I did not tie the dell-uart-backlight into acpi_video_get_backlight_type()
> yet, so the first 2 patches in this series deal with that and the third
> patch adds a DMI quirk to select native backlight control on top.
> 
> Backlight control used to work on the Dell OptiPlex 7760 AIO with kernel
> 6.9 and older, so this is a regression and I would like to see this
> series merged as fixes for 6.11.
> 
> Rafael, the drivers/platform/x86/dell/dell-uart-backlight.c are small
> and isolated. So I believe it is best if you take the entire series,
> to avoid conflicts if any other drivers/apci/video_detect.c DMI quirks
> show up this cycle.

FWIW,
Reviewed-by: Andy Shevchenko <andy@kernel.org>

I find this quite small and I agree this would be nice to have as fixes.
Rafael J. Wysocki Aug. 19, 2024, 1:59 p.m. UTC | #2 
On Wed, Aug 14, 2024 at 10:10 PM Andy Shevchenko <andy@kernel.org> wrote:
>
> On Wed, Aug 14, 2024 at 09:01:56PM +0200, Hans de Goede wrote:
> > Hi Rafael,
> >
> > 6.10 has a new backlight driver for UART attached backlight controller
> > boards found in some Dell All in One models.
> >
> > Now the first AIO has turned up which has not only the DSDT bits for this,
> > but also an actual controller attached to the UART, yet it is not using
> > this controller for backlight control (it needs GPU native control).
> >
> > I did not tie the dell-uart-backlight into acpi_video_get_backlight_type()
> > yet, so the first 2 patches in this series deal with that and the third
> > patch adds a DMI quirk to select native backlight control on top.
> >
> > Backlight control used to work on the Dell OptiPlex 7760 AIO with kernel
> > 6.9 and older, so this is a regression and I would like to see this
> > series merged as fixes for 6.11.
> >
> > Rafael, the drivers/platform/x86/dell/dell-uart-backlight.c are small
> > and isolated. So I believe it is best if you take the entire series,
> > to avoid conflicts if any other drivers/apci/video_detect.c DMI quirks
> > show up this cycle.
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
> I find this quite small and I agree this would be nice to have as fixes.

Applied as fixes for 6.11-rc, thanks!