mbox series

[RESEND,v3,0/1] RAS: Report ARM processor information to userspace

Message ID 20231214232330.306526-1-danielf@os.amperecomputing.com
Headers show
Series RAS: Report ARM processor information to userspace | expand

Message

Daniel Ferguson Dec. 14, 2023, 11:23 p.m. UTC 
The original patch remain unmodified. This is merely a resubmission
of the patch to get it moving forward again.

Links:
https://lore.kernel.org/lkml/20220214030813.135766-1-lostway@zju.edu.cn/T/

Shengwei Luo (1):
  RAS: Report ARM processor information to userspace

 drivers/acpi/apei/ghes.c |  3 +--
 drivers/ras/ras.c        | 46 ++++++++++++++++++++++++++++++++++++--
 include/linux/ras.h      | 15 +++++++++++--
 include/ras/ras_event.h  | 48 +++++++++++++++++++++++++++++++++++-----
 4 files changed, 101 insertions(+), 11 deletions(-)

Comments

Luck, Tony Dec. 14, 2023, 11:36 p.m. UTC | #1 
>  drivers/acpi/apei/ghes.c |  3 +--
>  drivers/ras/ras.c        | 46 ++++++++++++++++++++++++++++++++++++--
>  include/linux/ras.h      | 15 +++++++++++--
>  include/ras/ras_event.h  | 48 +++++++++++++++++++++++++++++++++++-----
>  4 files changed, 101 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c
> index 95540ea8dd9d..2a7f424d59b9 100644
> --- a/drivers/ras/ras.c
> +++ b/drivers/ras/ras.c
> @@ -21,9 +21,51 @@ void log_non_standard_event(const guid_t *sec_type, const guid_t *fru_id,
>       trace_non_standard_event(sec_type, fru_id, fru_text, sev, err, len);
>  }
>
> -void log_arm_hw_error(struct cper_sec_proc_arm *err)
> +void log_arm_hw_error(struct cper_sec_proc_arm *err, const u8 sev)
>  {

What GIT tree is this patch based on? I don't see this log_arm_hw_error()
function in drivers/ras/ras.c upstream, or in intel-next.

Should ARM specific code like this be in a file with "arm" in its name? Or at least
be inside some #ifdef CONFIG_ARM.

-Tony
Luck, Tony Dec. 14, 2023, 11:38 p.m. UTC | #2 
> What GIT tree is this patch based on? I don't see this log_arm_hw_error()
> function in drivers/ras/ras.c upstream, or in intel-next.

Thirty seconds after hitting SEND, I see I was looking at the wrong GIT tree. This
code is based on upstream. Ooops.

> Should ARM specific code like this be in a file with "arm" in its name? Or at least
> be inside some #ifdef CONFIG_ARM.

But I stand by this part.

-Tony