From patchwork Fri Sep 13 13:02:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 20282 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f197.google.com (mail-qc0-f197.google.com [209.85.216.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5627020358 for ; Fri, 13 Sep 2013 13:30:09 +0000 (UTC) Received: by mail-qc0-f197.google.com with SMTP id r5sf1218368qcx.0 for ; Fri, 13 Sep 2013 06:30:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=TCKcjcdKsCPfyhQ9ubAZoXzc8r3S6e2+dARmJCx+kaE=; b=bbUPmIxd813pXCBMJ7DkOWtkugwXQm6NlzvYYK7erieVoZyZPS0yI1DBT/Z+k7x6+C t4Y7F/92aEyAcTLgnBoy2E6RiwrYtr+5eziahaxjASjwsdPkumAm+pLr9J7MJc8tahLo vlHbH0DLvhqvnNW9gkZILMUknUc0Xdde7bDeQYS5YU43l8/C40ayY7In51Qd336lvEVk BzcHSHiqw8GwY+5rIQTS3y3ot3oNVagUJuzt2jfXvuzdAwjCWK4IMivanITTkbpkVkOy QCSL5CaJ20gSh3uMzDQIWouThoR671aAOIkwAFByfVhdM/UQ9GiFYK8CmHYrSpyP9d9m oMJw== X-Gm-Message-State: ALoCoQlwcYHG2CCCbSs4ftgHTvvvr8I0LayGzG9hmRynJrEdHOFJgQ9dtlKdkKVgTxfQRefJ/OVq X-Received: by 10.236.94.205 with SMTP id n53mr5032595yhf.44.1379079009139; Fri, 13 Sep 2013 06:30:09 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.38.70 with SMTP id e6ls1202613qek.77.gmail; Fri, 13 Sep 2013 06:30:08 -0700 (PDT) X-Received: by 10.52.24.4 with SMTP id q4mr715817vdf.34.1379079008931; Fri, 13 Sep 2013 06:30:08 -0700 (PDT) Received: from mail-vb0-f52.google.com (mail-vb0-f52.google.com [209.85.212.52]) by mx.google.com with ESMTPS id th8si3114507veb.134.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Sep 2013 06:30:08 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.212.52 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.52; Received: by mail-vb0-f52.google.com with SMTP id f12so881924vbg.25 for ; Fri, 13 Sep 2013 06:30:08 -0700 (PDT) X-Received: by 10.52.163.234 with SMTP id yl10mr5165vdb.47.1379079008851; Fri, 13 Sep 2013 06:30:08 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp80843vcz; Fri, 13 Sep 2013 06:30:08 -0700 (PDT) X-Received: by 10.68.98.101 with SMTP id eh5mr13438766pbb.65.1379079007981; Fri, 13 Sep 2013 06:30:07 -0700 (PDT) Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by mx.google.com with ESMTPS id tb4si11249520pab.145.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Sep 2013 06:30:07 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.50 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.220.50; Received: by mail-pa0-f50.google.com with SMTP id fb10so2526926pad.37 for ; Fri, 13 Sep 2013 06:30:07 -0700 (PDT) X-Received: by 10.68.211.233 with SMTP id nf9mr13706522pbc.26.1379079007584; Fri, 13 Sep 2013 06:30:07 -0700 (PDT) Received: from localhost ([122.167.78.148]) by mx.google.com with ESMTPSA id yg3sm18114263pab.16.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 13 Sep 2013 06:30:07 -0700 (PDT) From: Viresh Kumar To: rjw@sisk.pl Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Viresh Kumar Subject: [PATCH 228/228] cpufreq: unicore2: use cpufreq_generic_get() routine Date: Fri, 13 Sep 2013 18:32:54 +0530 Message-Id: X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e In-Reply-To: References: In-Reply-To: References: X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.52 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We have common infrastructure available with us for getting a CPUs clk rate. Lets use it for this driver. We also do clk_get() once instead of doing it again and again in target & init. Signed-off-by: Viresh Kumar --- drivers/cpufreq/unicore2-cpufreq.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/cpufreq/unicore2-cpufreq.c b/drivers/cpufreq/unicore2-cpufreq.c index 653ae29..951152f 100644 --- a/drivers/cpufreq/unicore2-cpufreq.c +++ b/drivers/cpufreq/unicore2-cpufreq.c @@ -11,6 +11,7 @@ * published by the Free Software Foundation. */ +#include #include #include #include @@ -33,26 +34,16 @@ static int ucv2_verify_speed(struct cpufreq_policy *policy) return 0; } -static unsigned int ucv2_getspeed(unsigned int cpu) -{ - struct clk *mclk = clk_get(NULL, "MAIN_CLK"); - - if (cpu) - return 0; - return clk_get_rate(mclk)/1000; -} - static int ucv2_target(struct cpufreq_policy *policy, unsigned int target_freq, unsigned int relation) { - unsigned int cur = ucv2_getspeed(0); + unsigned int cur = policy->cur; struct cpufreq_freqs freqs; - struct clk *mclk = clk_get(NULL, "MAIN_CLK"); cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); - if (!clk_set_rate(mclk, target_freq * 1000)) { + if (!clk_set_rate(policy->clk, target_freq * 1000)) { freqs.old = cur; freqs.new = target_freq; } @@ -66,9 +57,13 @@ static int __init ucv2_cpu_init(struct cpufreq_policy *policy) { if (policy->cpu != 0) return -EINVAL; + policy->min = policy->cpuinfo.min_freq = 250000; policy->max = policy->cpuinfo.max_freq = 1000000; policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL; + policy->clk = clk_get(NULL, "MAIN_CLK"); + if (IS_ERR(policy->clk)) + return PTR_ERR(policy->clk); return 0; } @@ -76,7 +71,7 @@ static struct cpufreq_driver ucv2_driver = { .flags = CPUFREQ_STICKY, .verify = ucv2_verify_speed, .target = ucv2_target, - .get = ucv2_getspeed, + .get = cpufreq_generic_get, .init = ucv2_cpu_init, .name = "UniCore-II", };