From patchwork Tue Apr 15 04:25:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 28377 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5A6512036A for ; Tue, 15 Apr 2014 04:26:12 +0000 (UTC) Received: by mail-ob0-f199.google.com with SMTP id gq1sf8565548obb.10 for ; Mon, 14 Apr 2014 21:26:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=qrpnwcz5PqKEm0j7jacjntNQLVFYyC6NqJjz6HA1BVY=; b=RGQhuyzbD+l2xSQNEBffVR4ExWIZtwppYkGSmCBva2ipgOysPsD9gd3M9c7LVNowud 4yMpnYCFtfa748chivB/0J3Tp0UMjFCTtBbFAVq4jNsRzp2zWyenEIRDRiwaRE9HB0LG FxYKFPfp7oggSmSraB+YbGQFZySYWejYAHmy0TPBcCD5g2bCqdBCXskY/aBjTY5dpvrg B/UfhYmSHJcweCRqlEoDKGXzW3FEl7DKxhkzfaVEpZwTjSjr9sCkqXwJqU8Yer9AHdo6 FcI+hMtH11t2yxTmEhSK5QX1QDN3AOFCTIu6gNKMKehYwP/GzutXyvPdOJbwJadPTKlB uIEg== X-Gm-Message-State: ALoCoQmnyUdxCnEVM8KxZ06RSWI6RbzRKijsYgCIK0gkCrGXfDSdbQiqjkair+HmAN3qrafKS0pT X-Received: by 10.182.29.196 with SMTP id m4mr22144024obh.26.1397535971219; Mon, 14 Apr 2014 21:26:11 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.21.40 with SMTP id 37ls3047581qgk.32.gmail; Mon, 14 Apr 2014 21:26:11 -0700 (PDT) X-Received: by 10.52.95.135 with SMTP id dk7mr4351549vdb.32.1397535971118; Mon, 14 Apr 2014 21:26:11 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id rn1si3181837vec.24.2014.04.14.21.26.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 14 Apr 2014 21:26:11 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id il7so8334218vcb.4 for ; Mon, 14 Apr 2014 21:26:10 -0700 (PDT) X-Received: by 10.58.122.164 with SMTP id lt4mr40883281veb.2.1397535970916; Mon, 14 Apr 2014 21:26:10 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp200144vcb; Mon, 14 Apr 2014 21:26:10 -0700 (PDT) X-Received: by 10.66.251.101 with SMTP id zj5mr989463pac.154.1397535969892; Mon, 14 Apr 2014 21:26:09 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id hu10si2052968pbc.315.2014.04.14.21.26.09; Mon, 14 Apr 2014 21:26:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbaDOEZz (ORCPT + 26 others); Tue, 15 Apr 2014 00:25:55 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:51530 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbaDOEZw (ORCPT ); Tue, 15 Apr 2014 00:25:52 -0400 Received: by mail-wi0-f180.google.com with SMTP id q5so5027408wiv.1 for ; Mon, 14 Apr 2014 21:25:51 -0700 (PDT) X-Received: by 10.180.98.165 with SMTP id ej5mr496268wib.33.1397535951460; Mon, 14 Apr 2014 21:25:51 -0700 (PDT) Received: from localhost ([213.122.173.131]) by mx.google.com with ESMTPSA id h10sm27193646wix.2.2014.04.14.21.25.48 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 14 Apr 2014 21:25:50 -0700 (PDT) From: Viresh Kumar To: peterz@infradead.org Cc: linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, mingo@redhat.com, fweisbec@gmail.com, Viresh Kumar Subject: [PATCH V2] sched/core: fix formatting issues in sched_can_stop_tick() Date: Tue, 15 Apr 2014 09:55:40 +0530 Message-Id: X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , sched_can_stop_tick() was using 7 spaces instead of 8 spaces or a 'tab' at the beginning of each line. Which doesn't align with the Coding Guidelines. Also it removes the *rq variable as it was used at only one place and hence we can directly use this_rq() instead. Signed-off-by: Viresh Kumar --- V1->V2: Rebased over: https://lkml.org/lkml/2014/3/19/456 kernel/sched/core.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 1fadf61..3a4bb63 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -666,19 +666,15 @@ static inline bool got_nohz_idle_kick(void) #ifdef CONFIG_NO_HZ_FULL bool sched_can_stop_tick(void) { - struct rq *rq; - - rq = this_rq(); - - /* - * More than one running task need preemption. - * nr_running update is assumed to be visible - * after IPI is sent from wakers. - */ - if (rq->nr_running > 1) - return false; + /* + * More than one running task need preemption. + * nr_running update is assumed to be visible + * after IPI is sent from wakers. + */ + if (this_rq()->nr_running > 1) + return false; - return true; + return true; } #endif /* CONFIG_NO_HZ_FULL */