From patchwork Wed Nov 13 10:09:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 21476 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f200.google.com (mail-vc0-f200.google.com [209.85.220.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B8D27202E2 for ; Wed, 13 Nov 2013 10:09:32 +0000 (UTC) Received: by mail-vc0-f200.google.com with SMTP id ht17sf305070vcb.11 for ; Wed, 13 Nov 2013 02:09:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=/ixymPBCXjfAUmmsngAPtYmv47lNaxkOGQykHxuNLf4=; b=TZaDnZUfe80Ia0Qsxy7Q+dtTcYxtBe98YjH/jfhYkAEu8DiR9mPjk+9CarTjHzfNh2 kJu9KqXD2GCom3/5jXZINRm1YWgcMyDuK4IALbvQkX+5KfD29t4mKTIKu9BNKubAxmZb SzNqax7kLLMpadzX1faaBWXxhMmzBZNa0OeKdwUvZL1xk5QPwYqtC1W2G7xGoIq5f8xG qsq430y3DaSPGkeMpULnOGgCOW6LcQKNbEmwAFMlHnI99rvsvMO5CvRWlyMXZfGEErE8 PfIqAohV6Fpz/hcdzuUYRhW4bGcjYNr79BjG006ldRvVAvAigy53vzGNKK8Bq1RD2uIz xK6A== X-Gm-Message-State: ALoCoQkuV7jJA1dseg8RPAMJNrRZVikoSt9Au77QX0xv2NRVv1rHsF2I1FRG3hpvw6t+/JdJElTq X-Received: by 10.58.134.110 with SMTP id pj14mr12236703veb.14.1384337372133; Wed, 13 Nov 2013 02:09:32 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.29.229 with SMTP id n5ls438433qeh.73.gmail; Wed, 13 Nov 2013 02:09:32 -0800 (PST) X-Received: by 10.58.161.231 with SMTP id xv7mr33460019veb.2.1384337371976; Wed, 13 Nov 2013 02:09:31 -0800 (PST) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by mx.google.com with ESMTPS id lw10si14262232vec.5.2013.11.13.02.09.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 13 Nov 2013 02:09:31 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.181; Received: by mail-vc0-f181.google.com with SMTP id lf12so120915vcb.26 for ; Wed, 13 Nov 2013 02:09:31 -0800 (PST) X-Received: by 10.52.164.16 with SMTP id ym16mr126153vdb.39.1384337371575; Wed, 13 Nov 2013 02:09:31 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp226662vcz; Wed, 13 Nov 2013 02:09:31 -0800 (PST) X-Received: by 10.229.43.201 with SMTP id x9mr35641543qce.10.1384337370743; Wed, 13 Nov 2013 02:09:30 -0800 (PST) Received: from mail-qc0-f182.google.com (mail-qc0-f182.google.com [209.85.216.182]) by mx.google.com with ESMTPS id r4si22298269qec.59.2013.11.13.02.09.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 13 Nov 2013 02:09:30 -0800 (PST) Received-SPF: neutral (google.com: 209.85.216.182 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.216.182; Received: by mail-qc0-f182.google.com with SMTP id n7so84721qcx.41 for ; Wed, 13 Nov 2013 02:09:30 -0800 (PST) X-Received: by 10.49.35.179 with SMTP id i19mr64233475qej.5.1384337370550; Wed, 13 Nov 2013 02:09:30 -0800 (PST) Received: from localhost (git.linaro.org. [54.235.93.228]) by mx.google.com with ESMTPSA id j15sm7998014qaa.6.2013.11.13.02.09.29 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 13 Nov 2013 02:09:29 -0800 (PST) From: Viresh Kumar To: rjw@sisk.pl Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, santosh.shilimkar@ti.com, Viresh Kumar Subject: [PATCH] cpufreq: OMAP: Fix compilation error 'r & ret undeclared' Date: Wed, 13 Nov 2013 15:39:23 +0530 Message-Id: X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , With a recent change "d4019f0 cpufreq: move freq change notifications to cpufreq core" few variables (r & ret) are removed by mistake and hence these warnings: drivers/cpufreq/omap-cpufreq.c: In function omap_target: drivers/cpufreq/omap-cpufreq.c:64:2: error: ret undeclared (first use in this function) drivers/cpufreq/omap-cpufreq.c:64:2: note: each undeclared identifier is reported only once for each function it appears in drivers/cpufreq/omap-cpufreq.c:94:3: error: r undeclared (first use in this function) drivers/cpufreq/omap-cpufreq.c:116:1: warning: control reaches end of non-void function [-Wreturn-type] Lets fix them by declaring those variables again. Reported-by: Sebastian Capella Signed-off-by: Viresh Kumar --- drivers/cpufreq/omap-cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c index be6d143..a0acd0b 100644 --- a/drivers/cpufreq/omap-cpufreq.c +++ b/drivers/cpufreq/omap-cpufreq.c @@ -53,6 +53,7 @@ static unsigned int omap_getspeed(unsigned int cpu) static int omap_target(struct cpufreq_policy *policy, unsigned int index) { + int r, ret; struct dev_pm_opp *opp; unsigned long freq, volt = 0, volt_old = 0, tol = 0; unsigned int old_freq, new_freq;