From patchwork Thu Jul 17 05:18:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 33770 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f198.google.com (mail-pd0-f198.google.com [209.85.192.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 89C4A201F1 for ; Thu, 17 Jul 2014 05:20:10 +0000 (UTC) Received: by mail-pd0-f198.google.com with SMTP id fp1sf12697261pdb.5 for ; Wed, 16 Jul 2014 22:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=NApLxvUhEBCniADk1Up8Ais6rLEMCnCdhRBOVoG9VlQ=; b=NfRUb9QxxYvWnG1RWFZM8gRBscqVI+Fv0xjhwtG+8snA3X4S1Fc8lRmJcXcwCdAWuJ zj+odMI3ILSs+yDzWcGCIQdNWP9CWb6/C+NISbasZ0DUQvWkCOx3yqgEhXF69CfRiorr 6k2xdYOd/GG0PqfhGUF6UMiyfFGJALEelNxu/HXFmELZyeWixX8CFa8gVc4nrPRtzndt JT8RFFYHbRoAjjRcE3blojL4ErvIaKNe/841zUmkY4fpcbaexRyEkneZ9kOiEhSVhboC onAH9ZKuPYTDLRHN3EfYO4iQtC+0/6VUUzUGXMN0tlwp/MH4E/l8sFzz9wzw4MJnCGIq BN4A== X-Gm-Message-State: ALoCoQlyXaxXg+D3q9WSGSRQc+Lk6CojVr5SqG0dR1zCoTliIYOZxELAXsmmKS9Io9dhFcV+gLFm X-Received: by 10.66.232.229 with SMTP id tr5mr17840522pac.16.1405574409842; Wed, 16 Jul 2014 22:20:09 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.85.40 with SMTP id m37ls587373qgd.18.gmail; Wed, 16 Jul 2014 22:20:09 -0700 (PDT) X-Received: by 10.220.203.134 with SMTP id fi6mr35847979vcb.18.1405574409744; Wed, 16 Jul 2014 22:20:09 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id o6si1324408vcn.83.2014.07.16.22.20.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Jul 2014 22:20:09 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id hq11so2050826vcb.16 for ; Wed, 16 Jul 2014 22:20:09 -0700 (PDT) X-Received: by 10.221.47.9 with SMTP id uq9mr14415883vcb.48.1405574409678; Wed, 16 Jul 2014 22:20:09 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp5974vcb; Wed, 16 Jul 2014 22:20:09 -0700 (PDT) X-Received: by 10.66.246.229 with SMTP id xz5mr20580675pac.119.1405574408870; Wed, 16 Jul 2014 22:20:08 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id mu3si623908pdb.77.2014.07.16.22.20.08; Wed, 16 Jul 2014 22:20:08 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753245AbaGQFUH (ORCPT + 15 others); Thu, 17 Jul 2014 01:20:07 -0400 Received: from mail-qc0-f180.google.com ([209.85.216.180]:50433 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752635AbaGQFUG (ORCPT ); Thu, 17 Jul 2014 01:20:06 -0400 Received: by mail-qc0-f180.google.com with SMTP id l6so1718681qcy.11 for ; Wed, 16 Jul 2014 22:20:05 -0700 (PDT) X-Received: by 10.224.29.201 with SMTP id r9mr52729748qac.25.1405574405676; Wed, 16 Jul 2014 22:20:05 -0700 (PDT) Received: from localhost (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id x1sm2746670qaj.19.2014.07.16.22.20.01 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 16 Jul 2014 22:20:05 -0700 (PDT) From: Viresh Kumar To: rjw@rjwysocki.net Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, arvind.chauhan@arm.com, srivatsa@mit.edu, skannan@codeaurora.org, ybu@qti.qualcomm.com, Viresh Kumar Subject: [PATCH V1 Resend 3/4] cpufreq: propagate error returned by kobject_move() Date: Thu, 17 Jul 2014 10:48:27 +0530 Message-Id: X-Mailer: git-send-email 2.0.0.rc2 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We are returning -EINVAL instead of the error returned from kobject_move() when it fails. Propagate the actual error number. Also add a meaningful print when sysfs_create_link() fails. Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index e572d51..ec25ca6 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1322,10 +1322,12 @@ static int cpufreq_nominate_new_policy_cpu(struct cpufreq_policy *policy, ret = kobject_move(&policy->kobj, &cpu_dev->kobj); if (ret) { pr_err("%s: Failed to move kobj: %d\n", __func__, ret); - ret = sysfs_create_link(&cpu_dev->kobj, &policy->kobj, - "cpufreq"); - return -EINVAL; + if (sysfs_create_link(&cpu_dev->kobj, &policy->kobj, "cpufreq")) + pr_err("%s: Failed to restore kobj link to cpu:%d\n", + __func__, cpu_dev->id); + + return ret; } return cpu_dev->id;