From patchwork Fri Aug 16 11:43:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 19224 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f71.google.com (mail-yh0-f71.google.com [209.85.213.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5CB66246AB for ; Fri, 16 Aug 2013 11:44:43 +0000 (UTC) Received: by mail-yh0-f71.google.com with SMTP id f64sf642637yha.6 for ; Fri, 16 Aug 2013 04:44:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=/FkbEurlsaTe1mnMcO+aVvvCy4mu9ktYdG30dNBDBls=; b=QCVb0xk4CZyAIkQs9BjDGdzti1CTj1mgIp/uJcPupqooHjeQbl93pQ93+b7r4sqaDf mITR20K19tXgeZPYmxtAqQkpw84r8vLwHCRw8vEhjiEuZO+YCmyubzktp9lolG87uoxW VACLjhB7MXJuA0Nac/HCJGmR88YR6iWwGHY9yD3CmsMg60qFM6itnL3+RZ8JmuUwVrRS jBn1PxMmQPi8uv7KZZ/JulLoPu1ilW+Iis/sIBR3bYVDlM8rltnedYKlKcO9CTc2z7fa +RFJ/mqTsZJVQlGApfQsfNNycdwJPAQyQ0gISL379wpwLgSmuASH9DRbnAsOIc4iEQcc Hd0g== X-Received: by 10.236.4.234 with SMTP id 70mr58575yhj.57.1376653483125; Fri, 16 Aug 2013 04:44:43 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.134.74 with SMTP id pi10ls748267qeb.35.gmail; Fri, 16 Aug 2013 04:44:43 -0700 (PDT) X-Received: by 10.52.69.142 with SMTP id e14mr143915vdu.29.1376653482976; Fri, 16 Aug 2013 04:44:42 -0700 (PDT) Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by mx.google.com with ESMTPS id zt2si212002vec.150.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 Aug 2013 04:44:42 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.176; Received: by mail-vc0-f176.google.com with SMTP id ha11so1334355vcb.21 for ; Fri, 16 Aug 2013 04:44:42 -0700 (PDT) X-Gm-Message-State: ALoCoQnWZrEKW3frJ3bPZzFSLC13+cNgVNRxuHy5eeCnWSUdn3LfqHMZbrC+Ekm4khv770BOmAKP X-Received: by 10.58.201.227 with SMTP id kd3mr887313vec.14.1376653482909; Fri, 16 Aug 2013 04:44:42 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp64132vcz; Fri, 16 Aug 2013 04:44:42 -0700 (PDT) X-Received: by 10.68.115.15 with SMTP id jk15mr1231366pbb.36.1376653482123; Fri, 16 Aug 2013 04:44:42 -0700 (PDT) Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com [209.85.192.181]) by mx.google.com with ESMTPS id qh6si1523213pac.47.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 Aug 2013 04:44:42 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.192.181 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.192.181; Received: by mail-pd0-f181.google.com with SMTP id g10so2134425pdj.40 for ; Fri, 16 Aug 2013 04:44:41 -0700 (PDT) X-Received: by 10.66.254.194 with SMTP id ak2mr1516691pad.167.1376653481736; Fri, 16 Aug 2013 04:44:41 -0700 (PDT) Received: from localhost ([122.172.193.46]) by mx.google.com with ESMTPSA id sp4sm1633700pbc.45.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 16 Aug 2013 04:44:41 -0700 (PDT) From: Viresh Kumar To: gregkh@linuxfoundation.org, jslaby@suse.cz Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, linux-serial@vger.kernel.org, Viresh Kumar Subject: [PATCH 10/25] tty: serial: lpc32xx_hs: don't call tty_flip_buffer_push() twice Date: Fri, 16 Aug 2013 17:13:11 +0530 Message-Id: X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e In-Reply-To: References: In-Reply-To: References: X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , serial_lpc32xx_interrupt() calls __serial_lpc32xx_rx() first and then tty_flip_buffer_push() immediately after that. But last statement of __serial_lpc32xx_rx() already called tty_flip_buffer_push().. So, probably its not required to be called twice. Lets remove one of them. Signed-off-by: Viresh Kumar --- drivers/tty/serial/lpc32xx_hs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c index dffea6b..8fdf6a8 100644 --- a/drivers/tty/serial/lpc32xx_hs.c +++ b/drivers/tty/serial/lpc32xx_hs.c @@ -351,10 +351,8 @@ static irqreturn_t serial_lpc32xx_interrupt(int irq, void *dev_id) } /* Data received? */ - if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT)) { + if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT)) __serial_lpc32xx_rx(port); - tty_flip_buffer_push(tport); - } /* Transmit data request? */ if ((status & LPC32XX_HSU_TX_INT) && (!uart_tx_stopped(port))) {