From patchwork Thu Jul 3 02:11:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 33009 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f199.google.com (mail-pd0-f199.google.com [209.85.192.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9BD4B20672 for ; Thu, 3 Jul 2014 02:11:39 +0000 (UTC) Received: by mail-pd0-f199.google.com with SMTP id r10sf56292450pdi.10 for ; Wed, 02 Jul 2014 19:11:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=8Wi/kLb+TU7umpXHAh8HoqTHv5SRpxL2gNks+H9Jz1Y=; b=RfslQTm06oe6SPli0K9HnfFnYnZ3r3C6zrHovMXDNIh07zRJDzON30Vw1rBuxaVW5H Q+VQFnocSUmBMr5xZ3Z5eltA0TVZtskFGEKRT4VSLR5wbEdSXHZkMzKQoakqIiALUWb+ GDKAl2JdsjaphrWo2CQBoSLZfO8t097pD6PBOh1V2NmFXWOZaye8sQGQxxZMf0dhl7AZ z8YaVR29aF6Y2zXcMF309Z5lIHfWhtTj1O+mmd1FbF9Jz7WAQh+BWGNtVOfYI49dur5l f3uMYtD9qJsOorTi/RK/YodPXDNg9Cf8qjf7ts44WyuQSil4qz4slpG3HpMMrekeETt+ sWDQ== X-Gm-Message-State: ALoCoQlJG2rt/ZIW7EYv4NYqq9ryxCi/fazlW4HN3k021JV1Omoj9JYm0cnddvMD+DALV8yWSRq1 X-Received: by 10.66.175.173 with SMTP id cb13mr1008849pac.10.1404353498857; Wed, 02 Jul 2014 19:11:38 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.31.139 with SMTP id f11ls304153qgf.87.gmail; Wed, 02 Jul 2014 19:11:38 -0700 (PDT) X-Received: by 10.58.150.1 with SMTP id ue1mr1035217veb.11.1404353498527; Wed, 02 Jul 2014 19:11:38 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id xy3si13653923vec.77.2014.07.02.19.11.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 02 Jul 2014 19:11:38 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id lf12so10966180vcb.18 for ; Wed, 02 Jul 2014 19:11:38 -0700 (PDT) X-Received: by 10.58.182.234 with SMTP id eh10mr39874vec.41.1404353498451; Wed, 02 Jul 2014 19:11:38 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp337365vcb; Wed, 2 Jul 2014 19:11:38 -0700 (PDT) X-Received: by 10.68.78.66 with SMTP id z2mr74290350pbw.71.1404353497725; Wed, 02 Jul 2014 19:11:37 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o15si479837pdl.440.2014.07.02.19.11.37; Wed, 02 Jul 2014 19:11:37 -0700 (PDT) Received-SPF: none (google.com: linux-arm-msm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754029AbaGCCLg (ORCPT + 3 others); Wed, 2 Jul 2014 22:11:36 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:56873 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802AbaGCCLf (ORCPT ); Wed, 2 Jul 2014 22:11:35 -0400 Received: by mail-ob0-f181.google.com with SMTP id wp4so13224840obc.40 for ; Wed, 02 Jul 2014 19:11:34 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.101.170 with SMTP id fh10mr1475129oeb.39.1404353494738; Wed, 02 Jul 2014 19:11:34 -0700 (PDT) Received: by 10.182.233.166 with HTTP; Wed, 2 Jul 2014 19:11:34 -0700 (PDT) In-Reply-To: <53B4A718.3050702@codeaurora.org> References: <53B4A718.3050702@codeaurora.org> Date: Thu, 3 Jul 2014 07:41:34 +0530 Message-ID: Subject: Re: [PATCH 09/14] cpufreq: cpu0: Move per-cluster initialization code to ->init() From: Viresh Kumar To: Stephen Boyd Cc: "Rafael J. Wysocki" , Shawn Guo , Lists linaro-kernel , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Arvind Chauhan , linux-arm-msm@vger.kernel.org, Sachin Kamat , Thomas P Abraham , Nishanth Menon , Tomasz Figa Sender: linux-arm-msm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 3 July 2014 06:13, Stephen Boyd wrote: > drivers/cpufreq/cpufreq-generic.c:313:13: warning: 'cdev' may be used > uninitialized in this function [-Wmaybe-uninitialized] > > So I guess we should initialize it to NULL? I somehow didn't got this, I checked again. I have fixed it this way: policy->driver_data = priv; --- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c index e6dc8ea..05a18bd 100644 --- a/drivers/cpufreq/cpufreq-cpu0.c +++ b/drivers/cpufreq/cpufreq-cpu0.c @@ -240,10 +240,11 @@ static int cpu0_cpufreq_init(struct cpufreq_policy *policy) dev_err(cpu_dev, "running cpufreq without cooling device: %ld\n", PTR_ERR(cdev)); + else + priv->cdev = cdev; } of_node_put(np); - priv->cdev = cdev; priv->cpu_dev = cpu_dev; priv->cpu_reg = cpu_reg;