From patchwork Mon Feb 17 09:20:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 24746 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6DCEE202B2 for ; Mon, 17 Feb 2014 09:20:26 +0000 (UTC) Received: by mail-pa0-f69.google.com with SMTP id fa1sf36706369pad.8 for ; Mon, 17 Feb 2014 01:20:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=TF6NzLwiu98DJigI9GaEu1C3CQAdM8EoTFkUdmBcGzQ=; b=l1aEttyRjkTrHQNcoqEHyfZg0HFJoghphbRE9t0o5rI4H+r+f9zVopOj7iydCYqNbS 27NXHm9G7kZXEzJHRH61YbL8CtT7Auw7H9fN77Emrv+BYDqDg4I2tbf9UQt3g1IjioRJ vUwyDtslxWBgr4xiZ71nLMLm30rvwQUD/VVUHMCEoQAUfinHKtqgZgQk6YvxKuVgK69B X72euecX59Cl4LGrIpRDvMqEbQ0rkLED1svaPFRdWtV0ZZRZ4HV+cQdnQtx/urchGsCu gv/T7K4skUjgRXDc8AsxXyArlgQODPdBmsgyr8xZ4GgFKmXmpssNYqDAK+K7JloubxzW 5TXA== X-Gm-Message-State: ALoCoQkLOnPi378ncNRGChkMr9sarZbjVIclb6XADKzPoJsvFIyQlI5fggvfEgbSM8nJ5+e1DLPi X-Received: by 10.66.221.137 with SMTP id qe9mr9881061pac.4.1392628825632; Mon, 17 Feb 2014 01:20:25 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.49.113 with SMTP id p104ls833319qga.41.gmail; Mon, 17 Feb 2014 01:20:25 -0800 (PST) X-Received: by 10.52.95.233 with SMTP id dn9mr13677525vdb.3.1392628825534; Mon, 17 Feb 2014 01:20:25 -0800 (PST) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id tr5si4327336vdc.143.2014.02.17.01.20.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Feb 2014 01:20:25 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id ld13so11366198vcb.18 for ; Mon, 17 Feb 2014 01:20:24 -0800 (PST) X-Received: by 10.220.139.198 with SMTP id f6mr861vcu.47.1392628824936; Mon, 17 Feb 2014 01:20:24 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp123349vcz; Mon, 17 Feb 2014 01:20:24 -0800 (PST) X-Received: by 10.68.197.66 with SMTP id is2mr25261002pbc.96.1392628824072; Mon, 17 Feb 2014 01:20:24 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id sd3si14118237pbb.252.2014.02.17.01.20.23; Mon, 17 Feb 2014 01:20:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbaBQJUW (ORCPT + 11 others); Mon, 17 Feb 2014 04:20:22 -0500 Received: from mail-ob0-f182.google.com ([209.85.214.182]:57863 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663AbaBQJUT (ORCPT ); Mon, 17 Feb 2014 04:20:19 -0500 Received: by mail-ob0-f182.google.com with SMTP id wm4so16634805obc.41 for ; Mon, 17 Feb 2014 01:20:19 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.60.103.134 with SMTP id fw6mr20044784oeb.34.1392628818941; Mon, 17 Feb 2014 01:20:18 -0800 (PST) Received: by 10.182.28.168 with HTTP; Mon, 17 Feb 2014 01:20:18 -0800 (PST) In-Reply-To: <52FEAECA.5080905@wwwdotorg.org> References: <52FE71BD.3020103@wwwdotorg.org> <2869027.iYHxWOSS2C@vostro.rjw.lan> <52FEAECA.5080905@wwwdotorg.org> Date: Mon, 17 Feb 2014 14:50:18 +0530 Message-ID: Subject: Re: [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() From: Viresh Kumar To: Stephen Warren Cc: "Rafael J. Wysocki" , Lists linaro-kernel , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Nishanth Menon , Kgene Kim , jinchoi@broadcom.com, Lan Tianyu , Sebastian Capella , Jonghwan Choi Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 15 February 2014 05:33, Stephen Warren wrote: > On 02/14/2014 03:23 PM, Rafael J. Wysocki wrote: >> Well, it would be good to verify which part, then. > > Patch 2/7 appears to stop that message from being printed during > suspend, and perhaps reduce the number of times it's printed during > resume. Patch 7/7 stops the message being printed at all. > > Looking at patch 7, I wonder if it's simply because tegra_target() was > modified never to return -EBUSY, so the bug is still there, but it's > just been hidden. No, the bug is removed now. Its hidden in current linus/master :) >>> Also, I sometimes see the following during resume. I saw it twice with >>> Linus's tree, but then I did 10 more reboot+suspend+resume cycles and >>> couldn't repro it, and I saw it once with Linus's tree plus this series >>> applied, then couldn't reproduce it in 5 more tries. > > Oops. I screwed up my re-testing (tested on the wrong board, without > cpufreq active:-/). The message below is reproducible 100% of the time > with or without this series. Somehow I missed it. Following will fix it, sending a separate patch for it as well: if (new_cpu >= 0) { --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 2dfbb7e..48315e0 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1326,8 +1326,7 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, up_read(&policy->rwsem); if (cpu != policy->cpu) { - if (!frozen) - sysfs_remove_link(&dev->kobj, "cpufreq"); + sysfs_remove_link(&dev->kobj, "cpufreq"); } else if (cpus > 1) { new_cpu = cpufreq_nominate_new_policy_cpu(policy, cpu);